gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4
History
Jonathan Druart 92e6c8029a
Bug 29486: _koha_marc_update_bib_ids no longer needed for GetMarcBiblio 
This subroutine is ensuring that the biblionumber and biblioitemnumber
will be part of the MARC record.
We should not need that, unless there is something broken somewhere
else.

This line has been added by the following commit:
  commit 4e95e94727
  Bug 6789: biblios with many items can result in broken search results link

"""
To this end, it also moves the fix_biblio_ids portion of get_corrected_marc_record out of rebuild_zebra.pl,
and makes it a part of GetMarcBiblio (right before EmbedItemsInMarcBiblio, so the 952s still come last).  fix_biblio_ids
is kept as a subroutine for the deletion portion of rebuild_zebra.pl, which still uses it.
"""

But it does not explain why it's better to have it in GetMarcBiblio.
If we need it for the reindexation process, we shouldn't impact
GetMarcBiblio which is used from several different places.

We might then consider adding the fix_biblio_ids call to
rebuild_zebra.pl, but I am failing to understand in which cases it could
be useful.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
 		2023-06-12 12:35:55 -03:00
..
AuthoritiesMarc Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Barcodes Bug 26328: Cast barcode from varchar to integer for incremental barcode 2022-03-25 09:58:10 -04:00
ClassSortRoutine Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
ClassSplitRoutine Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
Creators Bug 24001: Fix Card template/rpinter profile creation and edit 2022-05-06 13:47:21 -04:00
External Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Form Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
Heading Bug 33100: Remove all punctuation at end of record 2023-05-03 20:32:35 +02:00
ILSDI Bug 22379: Fix checks not made by ILS-DI method CancelHold 2022-05-13 11:48:54 -04:00
Installer Bug 30731: Remove Readonly::XS::MAGIC_COOKIE 2022-06-21 14:17:04 +02:00
Labels Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Linker Bug 28676: Cache and retrieve match_count when searching a cached heading 2021-09-20 12:06:56 +02:00
Members Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
OAI Bug 30308: Fix bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData) 2022-09-12 13:50:06 +02:00
Output Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Patroncards Bug 31259: Escape infinite loop when lime cannot wrap enough 2023-05-03 21:09:45 +02:00
Reports Bug 31276: Report results are limited to 999,999 no matter the actual number of results 2022-10-12 16:34:39 +02:00
SIP Bug 33216: Catch and handle RegisterRequired exceptions for SIP fee paid messages 2023-05-23 20:43:31 +02:00
Search Bug 29915: Tiny session adjustments 2022-03-17 11:37:57 -04:00
Serials Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Utils Bug 30110: Fix concatenation during assignements 2022-03-25 10:40:18 -04:00
Accounts.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Acquisition.pm Bug 31649: Fix acquisition basket group CSV export if biblio does not exist 2022-12-14 14:38:57 +01:00
Auth.pm Bug 32205: Remove unnecessary syspref template params for failed OPAC auth 2023-03-29 14:53:56 +02:00
Auth_cas_servers.yaml.sample Bug 17065 - Rename C4/Auth_cas_servers.yaml.orig 2016-08-08 13:16:36 +00:00
Auth_with_cas.pm Bug 28417: Don't require C4::Auth_with_cas from opac-user if not needed 2021-11-03 15:40:52 +01:00
Auth_with_ldap.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Auth_with_shibboleth.pm Bug 31244: [21.11.x] Fix 500 if logout and not logged in 2023-01-27 11:06:32 +01:00
AuthoritiesMarc.pm Bug 32279: Add GetAuthorizedHeading method export C4::AuthoritiesMarc 2023-05-03 21:14:00 +02:00
BackgroundJob.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Barcodes.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Biblio.pm Bug 29486: _koha_marc_update_bib_ids no longer needed for GetMarcBiblio 2023-06-12 12:35:55 -03:00
Breeding.pm Bug 32279: Add GetAuthorizedHeading method export C4::AuthoritiesMarc 2023-05-03 21:14:00 +02:00
Budgets.pm Bug 30359: GetBudgetHierarchy is slow on order receive page 2022-12-14 10:30:38 +01:00
Calendar.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Charset.pm Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
Circulation.pm Bug 33309: Index items after renewal transaction completes 2023-05-03 20:37:34 +02:00
ClassSortRoutine.pm Bug 29951: Fix EXPORT for C4::ClassS*Routine modules 2022-08-16 15:00:35 +02:00
ClassSource.pm Bug 29951: Fix EXPORT for C4::ClassS*Routine modules 2022-08-16 15:00:35 +02:00
ClassSplitRoutine.pm Bug 29951: Fix EXPORT for C4::ClassS*Routine modules 2022-08-16 15:00:35 +02:00
Context.pm Bug 28327: (follow-up) Comma as default CSV delimiter 2022-10-19 05:07:19 +02:00
Contract.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
CourseReserves.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Creators.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
HTML5Media.pm Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
Heading.pm Bug 25616: [21.11.x] Uppercase hard coded lower case boolean operators for Elasticsearch 2022-03-04 09:20:36 -05:00
HoldsQueue.pm Bug 29015: Add options for itemtype, collection, and shelving location to view_holdsqueue.pl 2021-11-03 15:40:52 +01:00
ImportBatch.pm Bug 32279: Add GetAuthorizedHeading method export C4::AuthoritiesMarc 2023-05-03 21:14:00 +02:00
ImportExportFramework.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
InstallAuth.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Installer.pm Bug 33341: Address some perlcritic errors in 5.36 2023-05-03 21:03:35 +02:00
ItemCirculationAlertPreference.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Items.pm Bug 27683: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref 2022-08-26 15:10:37 +02:00
Koha.pm Bug 33341: Address some perlcritic errors in 5.36 2023-05-03 21:03:35 +02:00
Labels.pm Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Languages.pm Bug 33341: Address some perlcritic errors in 5.36 2023-05-03 21:03:35 +02:00
Letters.pm Bug 27265: (follow-up) Use existing parameter 2022-12-22 19:39:14 +01:00
Linker.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Log.pm Bug 30984: (QA follow-up) Ternary formatting style 2022-10-12 13:12:37 +02:00
MarcModificationTemplates.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Matcher.pm Bug 33183: Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6 2023-04-20 11:18:22 +02:00
Members.pm Bug 28943: Lower the risk of accidental patron deletion 2022-02-07 06:54:09 -05:00
Message.pm Bug 30838: (QA follow-up) Add missing semicolon 2022-09-14 11:43:53 +02:00
Output.pm Bug 30969: Cross site scripting (XSS) attack in OPAC authority search ( opac-authorities-home.pl ) 2022-07-25 10:27:24 +02:00
Overdues.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Patroncards.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Record.pm Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
Reports.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Reserves.pm Bug 28529: Make biblio-level hold itemtype count against max rules 2022-07-21 16:35:44 +02:00
Ris.pm Bug 33341: Address some perlcritic errors in 5.36 2023-05-03 21:03:35 +02:00
RotatingCollections.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
SMS.pm Bug 27673: Replace YAML with YAML::XS 2021-02-16 14:54:50 +01:00
Scheduler.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Scrubber.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Search.pm Bug 13976: Sort popularity numerically in Zebra 2023-05-03 21:08:50 +02:00
Serials.pm Bug 33040: Add "Date published (text)" to serials tab on record view (detail.pl) 2023-05-23 20:43:30 +02:00
Service.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
ShelfBrowser.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
SocialData.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Stats.pm Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
Suggestions.pm Bug 28855: Purging suggestions test should not be on timestamp 2021-12-17 09:48:54 -05:00
TTParser.pm Bug 26673: Remove #!/usr/bin/env perl from .pm modules too 2020-10-26 00:14:42 +01:00
Tags.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Templates.pm Bug 31390: Remove noisy warns in C4::Templates 2022-10-19 05:07:19 +02:00
TmplToken.pm Bug 16011: $VERSION - Remove the $VERSION init 2016-03-24 17:20:28 +00:00
TmplTokenType.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
UsageStats.pm Bug 5229: Remove system preference 'OPACItemsResultsDisplay' 2021-11-19 15:23:27 +01:00
XISBN.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
XSLT.pm Bug 29687: Uninitialized warning C4/XSLT line 286 2022-03-04 08:26:17 -05:00