Colin Campbell d9ee325e8b Bug 28052: Do not check SYSENV values only keys in loop ... Loop is only interested in key values, because 'keys' is omitted it is checking values as well. This can lead to misleading errors being logged (e.g. key is undefined) Extract keys only to loop array as in the other loops below this Testing: 1 - tail /var/lib/koha/kohadev/sip-output.log 2 - in another tab use the sip cli tester: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m checkin --item CHESS1 3 - Note errors: Use of uninitialized value $key in index at /kohadevbox/koha/C4/SIP/Sip/MsgType.pm line 337, <STDIN> line 1. Use of uninitialized value $key in index at /kohadevbox/koha/C4/SIP/Sip/MsgType.pm line 337, <STDIN> line 2. 4 - Apply patch and restart all the things 5 - Repeat 2 6 - Errors mentioned are gone Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit cd40febe67) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> (cherry picked from commit 0a7cf00d20) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>		2021-04-24 16:37:29 +00:00
..
Checksum.pm	Bug 7904 Change SIP modules to use standard LIB path	2015-02-05 14:44:54 -03:00
Configuration.pm	Bug 15253: Rename syslog() to siplog()	2020-05-12 11:46:46 +01:00
Constants.pm	Bug 7904 Change SIP modules to use standard LIB path	2015-02-05 14:44:54 -03:00
MsgType.pm	Bug 28052: Do not check SYSENV values only keys in loop	2021-04-24 16:37:29 +00:00