gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4
History
Galen Charlton b7cbf8b531 do some validation of the KohaOpacRecentSearches cookie 
Add validation of the value of the KohaOpacRecentSearches.  In
particular, this patch avoids the generation of an internal server
error when the OPAC is presented with an old cookie that uses the
old Storable-based serialization.

This patch also moves parsing of the cookie value into a
new routine in C4::Auth, ParseSearchHistoryCookie, and adds
a test case.

To test (in conjunction with the previous patch):

Exercise the OPAC search history functionality, after
turning on the EnableOpacSearchHistory syspref:

- As an anonymous user, conduct a variety of searches,
  including ones that include non-ASCII characters
- Check the search history and verify that all searches
  are listed
- Apply this patch and the previous one.
- Do *not* clear the KohaOpacRecentSearches cookie
- Check the search history and verify that no searches
  are listed any more
- As an anonymous user, conduct a variety of searches,
  including ones that include non-ASCII characters
- Check the search history and verify that all searches
  are listed
- Log into the OPAC
- Verify that current and past searches are listed in
  search history.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 2932860374670ac2656261db15e3375c6ed2e9f1)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
 		2013-07-29 08:47:11 -04:00
..
AuthoritiesMarc Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Barcodes Bug 5385 - Fixing an error that crept in with the POD cleanup 2010-11-12 10:42:19 +13:00
Cache Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
ClassSortRoutine Bug 4265: Fix padding of short callnumbers and Bib-1 attribute for sorting 2011-03-29 21:54:12 +13:00
Creators Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser 2012-08-11 07:29:22 -04:00
External Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Form Fix for Bug 6458 - incorrect parsing result in translation processing 2011-09-15 08:38:58 +12:00
Heading bug 7284: fix package build problem, move BEGIN into new 2012-05-08 17:48:48 -04:00
ILSDI Bug 8275: xml parsing error when the webservice GetPatronInfo/show_loans is called 2012-10-12 22:00:37 -04:00
Installer Bug 7532 - remove dependency on Date::ICal 2012-02-19 21:00:38 -05:00
Labels Bug 7356 - Fix various typos and mis-spellings 2012-01-18 10:10:53 -05:00
Linker Bug 8447: Make sure we have enough subfields for broader_headings 2012-10-12 22:00:05 -04:00
Members bug_6253: Unified member Search() 2011-10-19 16:23:02 +13:00
Output Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Patroncards fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00
Reports Bug 8594 - prevent the report system from breaking some subqueries 2012-10-12 21:59:10 -04:00
SIP Bug 8216: Allow SIP modules to pass critic tests 2012-08-11 07:29:31 -04:00
Search Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
VirtualShelves Fix for Bug 7083 - [SIGNED-OFF] Show creator name on list of public lists 2012-02-02 20:34:41 -05:00
tests Bug 2505 - Add commented use warnings where missing in the C4/ directory 2010-04-21 20:25:32 +12:00
Accounts.pm Bug 6634 : 3 more cases of manager_id not populated 2012-08-11 07:29:34 -04:00
Acquisition.pm Bug 7807: [SIGNED-OFF] Fix call to GetSuggestionFromBiblionumber 2012-08-11 07:29:13 -04:00
Auth.pm do some validation of the KohaOpacRecentSearches cookie 2013-07-29 08:47:11 -04:00
Auth_cas_servers.yaml.orig Bug 5630 CAS improvements 2011-10-13 10:49:49 +13:00
Auth_with_cas.pm Bug 5630 CAS improvements 2011-10-13 10:49:49 +13:00
Auth_with_ldap.pm Bug 6022: Auth_with_ldap check if categorycode is valid 2011-12-06 14:10:33 -05:00
AuthoritiesMarc.pm Bug 9123: Authorities search ordered by authid does not work 2012-12-24 11:39:43 +13:00
BackgroundJob.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Barcodes.pm Bug 5681: Fixes leading zeroes in Add Mulpiple Copies 2011-02-03 10:08:50 +13:00
Biblio.pm Bug 7921: Software error while placing order 2012-12-24 10:52:00 +13:00
Bookseller.pm Bug 3388: Restore account number on vendor page 2011-12-02 15:47:23 -05:00
Boolean.pm Bug 5448: Refactor Boolean.pm 2010-12-02 08:51:33 +13:00
Branch.pm Bug 7034: de-nesting C4/Branch.pm 2011-10-19 03:23:31 +13:00
Breeding.pm Bug 8350: warning in logs when searching for nonexistent ISBN 2012-10-12 22:00:51 -04:00
Budgets.pm bug_4831: Use unitprice (actual cost) when totalling spent amounts for "All available funds", as in "Already received" 2011-09-22 19:35:40 +12:00
Cache.pm Bug 5363 - Removing unused module (C4::Cache::FastMemcached) 2010-11-04 20:05:36 +13:00
Calendar.pm Fix for Bug 4991, Overhaul of Calendar interface 2010-11-02 15:02:54 +13:00
Category.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-07-12 21:15:41 -04:00
Charset.pm bug 5579 : Fixes several exports to embed items 2011-04-19 22:35:15 +12:00
Circulation.pm Bug 7758 - Koha allowing LOST items to check out without alert 2012-05-08 17:49:40 -04:00
ClassSortRoutine.pm Bug 7035 de-nesting C4::ClassSource & ClassSortRoutine 2011-10-19 03:25:59 +13:00
ClassSource.pm Bug 7035 de-nesting C4::ClassSource & ClassSortRoutine 2011-10-19 03:25:59 +13:00
Context.pm Bug 6132: Update sysprefs cache in set_preference 2012-01-18 10:10:56 -05:00
Contract.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Creators.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-07-12 21:15:41 -04:00
Csv.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Dates.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-07-12 21:15:41 -04:00
Debug.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Heading.pm Bug 7617: Sort authority results by authid 2012-05-08 17:49:32 -04:00
ImportBatch.pm Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted because they are issued. 2012-08-11 07:29:26 -04:00
ImportExportFramework.pm Bug 7476 Remove executable bit from files that probably should not be executed 2012-02-19 21:00:11 -05:00
Input.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Installer.pm Bug 6699 follow-up 2011-12-03 07:12:05 -05:00
ItemCirculationAlertPreference.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-07-12 21:15:41 -04:00
ItemType.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-07-12 21:15:41 -04:00
Items.pm Bug 7847: OPAC search dies with Plack 2012-07-12 21:15:42 -04:00
Koha.pm Bug 8025: corrects the return of a zero value for authorised values 2012-06-14 07:44:15 -04:00
Labels.pm Bringing label, patroncard, and creator modules into conformity with the rest of C4 style. 2010-02-08 20:54:34 -05:00
Languages.pm Bug 8954: Make languages list in advanced search translatable (revision 1) 2012-11-28 14:12:45 +13:00
Letters.pm 6302 follow up 2012-01-16 15:43:09 -05:00
Linker.pm Bug 7284: Authority matching improvements 2012-05-08 17:48:47 -04:00
Log.pm Bug 6460: alternative fix, updating template and script instead of C4::Log 2011-09-24 10:01:09 +12:00
Maintainance.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Matcher.pm Bug 5415 Let calls of SimpleSearch utilize considtent interface 2011-04-08 13:52:57 +12:00
Members.pm Bug 8533 - Non-numeric cardnumbers screw up autoMemberNum 2012-10-12 21:22:10 -04:00
Message.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-07-12 21:15:41 -04:00
NewsChannels.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Output.pm Bug 7535: ampersands not showing properly in non-XSLT OPAC 2012-02-22 09:41:46 -05:00
Overdues.pm Bug 6987 Make return from Overdues::GetFine consistent 2011-12-08 11:13:08 -05:00
Patroncards.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
Print.pm Bug 6627 [Signed Off] - Update to improve security in specified log files - bug 6627 2012-01-16 15:59:42 -05:00
Record.pm Bug 7345: Enable exporting records sans private fields 2012-02-19 21:00:19 -05:00
Reports.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Reserves.pm bug 7016 further followup: clarify return of GetItemnumbersForBiblio 2012-06-21 10:07:43 -04:00
Review.pm Bug 1623 - Provide view of approved comments 2012-01-16 15:47:29 -05:00
Ris.pm bug 5780 followup: RIS export now includes all URLs 2011-10-14 10:37:31 +13:00
RotatingCollections.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
SMS.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-07-12 21:15:41 -04:00
SQLHelper.pm Bug 7432 : Fixing caching for SQLHelper 2012-02-19 21:00:23 -05:00
Scheduler.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Scrubber.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-07-12 21:15:41 -04:00
Search.pm Bug 7690: hidelostitems not working in Normal Display 2012-10-12 22:00:31 -04:00
Serials.pm Bug 6655 - Sorting order of serial issues in OPAC 2012-10-12 21:16:32 -04:00
Service.pm POD Cleanups 2010-06-09 08:38:59 -04:00
ShelfBrowser.pm Bug 5551 - allow shelf browser filters to be changed 2011-01-21 11:08:42 +13:00
Stats.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Suggestions.pm Bug 5346: Linking suggestions and orders. 2012-02-19 21:00:33 -05:00
TTParser.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-07-12 21:15:41 -04:00
Tags.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-07-12 21:15:41 -04:00
Templates.pm Stop unnecessary warnings in get_language 2012-05-23 20:50:43 -04:00
TmplToken.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-07-12 21:15:41 -04:00
TmplTokenType.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-07-12 21:15:41 -04:00
UploadedFile.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Utils.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-07-12 21:15:41 -04:00
VirtualShelves.pm Revert "Bug 6875 de-nesting C4::VirtualShelves" 2012-02-22 14:42:33 -05:00
XISBN.pm Fix for Bug 5570 - item types not showing on other editions 2011-01-07 14:18:09 +13:00
XSLT.pm Bug 7092 - Complete-subfield searches TraceCompleteSubfields syspref not working correctly 2012-05-08 17:49:04 -04:00
Z3950.pm fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00