gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4
History
Galen Charlton ac8c47e187 do some validation of the KohaOpacRecentSearches cookie 
Add validation of the value of the KohaOpacRecentSearches.  In
particular, this patch avoids the generation of an internal server
error when the OPAC is presented with an old cookie that uses the
old Storable-based serialization.

This patch also moves parsing of the cookie value into a
new routine in C4::Auth, ParseSearchHistoryCookie, and adds
a test case.

To test (in conjunction with the previous patch):

Exercise the OPAC search history functionality, after
turning on the EnableOpacSearchHistory syspref:

- As an anonymous user, conduct a variety of searches,
  including ones that include non-ASCII characters
- Check the search history and verify that all searches
  are listed
- Apply this patch and the previous one.
- Do *not* clear the KohaOpacRecentSearches cookie
- Check the search history and verify that no searches
  are listed any more
- As an anonymous user, conduct a variety of searches,
  including ones that include non-ASCII characters
- Check the search history and verify that all searches
  are listed
- Log into the OPAC
- Verify that current and past searches are listed in
  search history.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
 		2013-07-28 03:23:44 +00:00
..
AuthoritiesMarc Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Barcodes Bug 5385 - Fixing an error that crept in with the POD cleanup 2010-11-12 10:42:19 +13:00
Cache Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
ClassSortRoutine Bug 4265: Fix padding of short callnumbers and Bib-1 attribute for sorting 2011-03-29 21:54:12 +13:00
Creators Bug 7215 - changed callnumber PRESET field to itemcallnumber 2012-01-18 10:48:13 -05:00
External Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Form Fix for Bug 6458 - incorrect parsing result in translation processing 2011-09-15 20:20:28 -04:00
Heading Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
ILSDI Bug #6142 - Delete sub CanBookBeReserved and delete function's reference on @EXPORT 2012-01-20 23:29:59 -05:00
Installer Bug 7532 - remove dependency on Date::ICal 2012-02-19 22:27:58 -05:00
Labels bug 5653: use itemcallnumber in bib label layouts 2011-06-13 20:59:37 -04:00
Members bug_6253: Unified member Search() 2011-10-25 19:32:30 -04:00
Output Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Patroncards fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00
Reports Bug 6024 : add "Run report" link on the new report creation success page 2011-04-08 13:29:58 +12:00
SIP Revert "Bug 7238 Followup - fix sip_run to require path to SIPconfig.xml" 2012-02-21 07:49:42 -05:00
Search Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
VirtualShelves Fix for Bug 7083 - [SIGNED-OFF] Show creator name on list of public lists 2012-02-19 21:31:54 -05:00
tests Bug 2505 - Add commented use warnings where missing in the C4/ directory 2010-04-21 20:25:32 +12:00
Accounts.pm Bug 7160: paying fines throws error 2012-01-20 15:01:52 -05:00
Acquisition.pm Bug 5473 follow-up : removed warn & replace some tabs by 4 spaces 2012-02-19 21:33:17 -05:00
Auth.pm do some validation of the KohaOpacRecentSearches cookie 2013-07-28 03:23:44 +00:00
Auth_cas_servers.yaml.orig Bug 5630 CAS improvements 2011-10-19 15:53:36 -04:00
Auth_with_cas.pm Bug 5630 CAS improvements 2011-10-19 15:53:36 -04:00
Auth_with_ldap.pm Bug 5995 Followup: checkpw was returning inconsistent values 2011-10-19 16:02:36 -04:00
AuthoritiesMarc.pm Use MARCAuthorityControlField008 in AddAuthority for empty 008s 2012-01-20 23:21:58 -05:00
BackgroundJob.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Barcodes.pm Bug 5681: Fixes leading zeroes in Add Mulpiple Copies 2011-02-03 10:08:50 +13:00
Biblio.pm Bug 3264 UnCloneField() / minus button in MARC editor can clear all subfields (authorities AND biblio) 2012-02-19 22:27:53 -05:00
Bookseller.pm Bug5063: C4::Bookseller Changes 2011-03-12 08:42:26 +13:00
Boolean.pm Bug 5448: Refactor Boolean.pm 2010-12-02 08:51:33 +13:00
Branch.pm Bug 7034: de-nesting C4/Branch.pm 2011-10-25 19:25:36 -04:00
Breeding.pm Fix for Bug 4290 - search for author in repository 2011-03-06 08:22:06 +13:00
Budgets.pm bug_4831: Use unitprice (actual cost) when totalling spent amounts for "All available funds", as in "Already received" 2011-10-08 12:17:52 -04:00
Cache.pm Bug 5363 - Removing unused module (C4::Cache::FastMemcached) 2010-11-04 20:05:36 +13:00
Calendar.pm Fix for Bug 4991, Overhaul of Calendar interface 2010-11-02 15:02:54 +13:00
Category.pm Bug 6989 Patron categories not properly displayed if not pure ASCII 2011-11-16 09:00:19 -05:00
Charset.pm bug 5579 : Fixes several exports to embed items 2011-04-19 22:35:15 +12:00
Circulation.pm Bug 6137: fix a Circulation bug. userenv null 2012-02-19 22:27:57 -05:00
ClassSortRoutine.pm Bug 7035 de-nesting C4::ClassSource & ClassSortRoutine 2011-10-25 19:25:50 -04:00
ClassSource.pm Bug 7035 de-nesting C4::ClassSource & ClassSortRoutine 2011-10-25 19:25:50 -04:00
Context.pm Bug 6132: Update sysprefs cache in set_preference 2012-01-21 01:23:08 -05:00
Contract.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Creators.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
Csv.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Dates.pm Bug 929 : Follow up adding unit tests, discovered C4::Dates cached the syspref with no way to clear it, fixed also. 2012-01-21 01:22:41 -05:00
Debug.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Heading.pm Bug 6875 de-nesting C4::Heading 2012-02-19 22:27:51 -05:00
ImportBatch.pm Bug 5859: Allow user to set encoding for import 2011-04-19 13:05:48 +12:00
ImportExportFramework.pm Bug 7476 Remove executable bit from files that probably should not be executed 2012-02-19 22:27:41 -05:00
Input.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Installer.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
ItemCirculationAlertPreference.pm POD Cleanups 2010-06-09 08:38:59 -04:00
ItemType.pm Bug 6371 Item Types description not properly displayed if not pure ASCII 2011-10-08 17:57:55 -04:00
Items.pm Bug 6488 adding a 2nd \n to silence logs 2012-02-19 22:27:38 -05:00
Koha.pm Bug 6875 de-nesting C4::Koha.pm 2012-02-19 22:27:50 -05:00
Labels.pm Bringing label, patroncard, and creator modules into conformity with the rest of C4 style. 2010-02-08 20:54:34 -05:00
Languages.pm Bug 7432 : Fixing caching for C4::Languages 2012-02-19 22:27:49 -05:00
Letters.pm 6302 follow up 2012-01-20 23:12:53 -05:00
Log.pm Bug 6460: alternative fix, updating template and script instead of C4::Log 2011-10-08 12:47:44 -04:00
Maintainance.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Matcher.pm Bug 5415 Let calls of SimpleSearch utilize considtent interface 2011-04-08 13:52:57 +12:00
Members.pm Bug 7139 : Log addition and deletion of circulation messages 2012-01-20 15:01:13 -05:00
Message.pm POD Cleanups 2010-06-09 08:38:59 -04:00
NewsChannels.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Output.pm Bug 6098 Followup -- doesn't replace NSB/NSE by space 2012-01-21 00:33:14 -05:00
Overdues.pm Bug 6927-- Typo in C4::Overdues.pm 2011-10-08 17:43:00 -04:00
Patroncards.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
Print.pm Bug 6627 [Signed Off] - Update to improve security in specified log files - bug 6627 2012-01-20 23:40:44 -05:00
Record.pm Bug 7345: Enable exporting records sans private fields 2012-02-19 22:27:45 -05:00
Reports.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Reserves.pm bug_2830: Remove reserve when checking out if the borrower is not the first one in the reserve queue 2012-01-20 23:11:51 -05:00
Review.pm Bug 1623 - Provide view of approved comments 2012-01-20 23:28:10 -05:00
Ris.pm bug 5780 followup: RIS export now includes all URLs 2011-10-19 15:56:59 -04:00
RotatingCollections.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
SMS.pm More POD cleanups 2010-06-09 08:38:58 -04:00
SQLHelper.pm Bug 7432 : Fixing caching for SQLHelper 2012-02-19 22:27:48 -05:00
Scheduler.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Scrubber.pm Bug 5611: Simple typo fix in the comments 2011-01-13 08:17:27 +13:00
Search.pm Bug 6488 - followup - fixes issue with bibs with no items and serials being suppressed 2012-02-20 16:01:09 -05:00
Serials.pm Bug 7357: display serial title instead of '---' 2012-02-19 22:27:59 -05:00
Service.pm POD Cleanups 2010-06-09 08:38:59 -04:00
ShelfBrowser.pm Bug 5551 - allow shelf browser filters to be changed 2011-01-21 11:08:42 +13:00
Stats.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Suggestions.pm Bug 5947 Suggestions : add date to the search query 2011-04-05 11:06:28 +12:00
TTParser.pm Bug 7476 Remove executable bit from files that probably should not be executed 2012-02-19 22:27:41 -05:00
Tags.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Templates.pm Bug 7511 [ENH] Template caching (T::T feature) 2012-02-19 22:27:45 -05:00
TmplToken.pm Bug 6458 Template Toolkit files test case 2011-08-18 06:53:48 -04:00
TmplTokenType.pm Bug 6458 Template Toolkit files test case 2011-08-18 06:53:48 -04:00
UploadedFile.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Utils.pm Big LDAP changes, module test for Context.pm, still more yet to come. 2007-12-04 17:27:06 -06:00
VirtualShelves.pm Bug 6875 de-nesting C4::VirtualShelves 2012-02-19 22:27:51 -05:00
XISBN.pm Fix for Bug 5570 - item types not showing on other editions 2011-01-07 14:18:09 +13:00
XSLT.pm Bug 7476 Remove executable bit from files that probably should not be executed 2012-02-19 22:27:41 -05:00
Z3950.pm fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00