#!/usr/bin/perl use Modern::Perl; use C4::Reserves qw( ModReserve ModReserveAffect ); use Koha::DateUtils qw( dt_from_string ); use t::lib::Mocks; use t::lib::TestBuilder; use Test::NoWarnings; use Test::More tests => 14; use_ok( 'C4::Reserves', qw( ModReserve ModReserveAffect ) ); my $schema = Koha::Database->new->schema; $schema->storage->txn_begin; my $dbh = C4::Context->dbh; $dbh->do(q{DELETE FROM library_single_closures}); $dbh->do(q{DELETE FROM library_closure_exceptions}); $dbh->do(q{DELETE FROM library_weekly_closures}); $dbh->do(q{DELETE FROM library_repeating_closures}); $dbh->do("DELETE FROM reserves"); my $builder = t::lib::TestBuilder->new(); # Category, branch and patrons $builder->build( { source => 'Category', value => { categorycode => 'XYZ1', }, } ); $builder->build( { source => 'Branch', value => { branchcode => 'LIB1', }, } ); $builder->build( { source => 'Branch', value => { branchcode => 'LIB2', }, } ); my $patron1 = $builder->build( { source => 'Borrower', value => { categorycode => 'XYZ1', branchcode => 'LIB1', }, } ); my $patron2 = $builder->build( { source => 'Borrower', value => { categorycode => 'XYZ1', branchcode => 'LIB2', }, } ); my $biblio = $builder->build_sample_biblio; my $biblio2 = $builder->build_sample_biblio; my $biblio3 = $builder->build_sample_biblio; my $biblio4 = $builder->build_sample_biblio; my $biblio5 = $builder->build_sample_biblio; my $biblio6 = $builder->build_sample_biblio; my $item1 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } ); my $item2 = $builder->build_sample_item( { biblionumber => $biblio2->biblionumber } ); my $item3 = $builder->build_sample_item( { biblionumber => $biblio3->biblionumber } ); my $item4 = $builder->build_sample_item( { biblionumber => $biblio4->biblionumber } ); my $item5 = $builder->build_sample_item( { biblionumber => $biblio5->biblionumber } ); my $item6 = $builder->build_sample_item( { biblionumber => $biblio6->biblionumber } ); Koha::CirculationRules->set_rules( { categorycode => undef, itemtype => undef, branchcode => undef, rules => { holds_pickup_period => undef, } } ); my $today = dt_from_string(); my $reserve1_reservedate = $today->clone; $reserve1_reservedate->subtract( days => 20 ); my $reserve1_expirationdate = $today->clone; $reserve1_expirationdate->add( days => 6 ); my $reserve1 = $builder->build( { source => 'Reserve', value => { borrowernumber => $patron1->{borrowernumber}, reservedate => $reserve1_reservedate->ymd, patron_expiration_date => undef, biblionumber => $biblio->biblionumber, branchcode => 'LIB1', priority => 1, found => '', }, } ); t::lib::Mocks::mock_preference( 'ExpireReservesMaxPickUpDelay', 1 ); t::lib::Mocks::mock_preference( 'ReservesMaxPickUpDelay', 6 ); ModReserveAffect( $item1->itemnumber, $patron1->{borrowernumber} ); my $r = Koha::Holds->find( $reserve1->{reserve_id} ); is( $r->waitingdate, $today->ymd, 'Waiting date should be set to today' ); is( $r->expirationdate, $reserve1_expirationdate->ymd, 'Expiration date should be set to today + 6' ); is( $r->found, 'W', 'Reserve status is now "waiting"' ); is( $r->priority, 0, 'Priority should be 0' ); is( $r->itemnumber, $item1->itemnumber, 'Item number should be set correctly' ); my $reserve2 = $builder->build( { source => 'Reserve', value => { borrowernumber => $patron2->{borrowernumber}, reservedate => $reserve1_reservedate->ymd, patron_expiration_date => undef, biblionumber => $biblio2->biblionumber, branchcode => 'LIB1', priority => 1, found => '', }, } ); ModReserveAffect( $item2->itemnumber, $patron2->{borrowernumber}, 1 ); my $r2 = Koha::Holds->find( $reserve2->{reserve_id} ); is( $r2->found, 'T', '2nd reserve - Reserve status is now "To transfer"' ); is( $r2->priority, 0, '2nd reserve - Priority should be 0' ); is( $r2->itemnumber, $item2->itemnumber, '2nd reserve - Item number should be set correctly' ); my $reserve3 = $builder->build( { source => 'Reserve', value => { borrowernumber => $patron2->{borrowernumber}, reservedate => $reserve1_reservedate->ymd, patron_expiration_date => undef, biblionumber => $biblio3->biblionumber, branchcode => 'LIB1', priority => 1, found => '', }, } ); my $special_holiday1_dt = $today->clone; $special_holiday1_dt->add( days => 2 ); my $holiday = $builder->build_object( { class => 'Koha::Library::Calendar::SingleClosures', value => { library_id => 'LIB1', date => $special_holiday1_dt->ymd, title => 'My special holiday', description => '' } } ); my $special_holiday2_dt = $today->clone; $special_holiday2_dt->add( days => 4 ); my $holiday2 = $builder->build_object( { class => 'Koha::Library::Calendar::SingleClosures', value => { library_id => 'LIB1', date => $special_holiday2_dt->ymd, title => 'My special holiday 2', description => '' } } ); Koha::Caches->get_instance->flush_all; t::lib::Mocks::mock_preference( 'ExcludeHolidaysFromMaxPickUpDelay', 1 ); ModReserveAffect( $item3->itemnumber, $patron2->{borrowernumber} ); # Add 6 days of pickup delay + 1 day of holiday. my $expected_expiration = $today->clone; $expected_expiration->add( days => 8 ); my $r3 = Koha::Holds->find( $reserve3->{reserve_id} ); is( $r3->expirationdate, $expected_expiration->ymd, 'Expiration date should be set to today + 7' ); my $reserve4_reservedate = $today->clone; my $requested_expiredate = $today->clone()->add( days => 6 ); my $reserve4 = $builder->build( { source => 'Reserve', value => { borrowernumber => $patron2->{borrowernumber}, reservedate => $reserve4_reservedate->ymd, patron_expiration_date => $requested_expiredate->ymd, biblionumber => $biblio4->biblionumber, branchcode => 'LIB1', priority => 1, found => '', }, } ); t::lib::Mocks::mock_preference( 'ReservesMaxPickUpDelay', 10 ); ModReserveAffect( $item4->itemnumber, $patron2->{borrowernumber}, 0, $reserve4->{reserve_id} ); my $r4 = Koha::Holds->find( $reserve4->{reserve_id} ); is( $r4->expirationdate, $requested_expiredate->ymd, 'Requested expiration date should be kept' ); Koha::CirculationRules->set_rules( { categorycode => $patron1->{categorycode}, itemtype => undef, branchcode => undef, rules => { holds_pickup_period => '3', } } ); t::lib::Mocks::mock_preference( 'ReservesMaxPickUpDelay', 7 ); my $reserve5_reservedate = $today->clone; my $reserve5_expirationdate = $reserve5_reservedate->add( days => 3 ); my $reserve5 = $builder->build( { source => 'Reserve', value => { borrowernumber => $patron1->{borrowernumber}, reservedate => $reserve5_reservedate->ymd, expirationdate => undef, biblionumber => $biblio5->biblionumber, branchcode => 'LIB2', priority => 1, found => '', patron_expiration_date => undef, }, } ); ModReserveAffect( $item5->itemnumber, $patron1->{borrowernumber} ); my $r5 = Koha::Holds->find( $reserve5->{reserve_id} ); is( $r5->expirationdate, $reserve5_expirationdate->ymd, 'Expiration date should be set to today + 3 based on circulation rules' ); my $reserve6_reservedate = $today->clone; # add 3 days of pickup + 1 day of holiday my $reserve6_expirationdate = $reserve6_reservedate->add( days => 5 ); my $reserve6 = $builder->build( { source => 'Reserve', value => { borrowernumber => $patron1->{borrowernumber}, reservedate => $reserve6_reservedate->ymd, expirationdate => undef, biblionumber => $biblio6->biblionumber, branchcode => 'LIB1', priority => 1, found => '', patron_expiration_date => undef, }, } ); ModReserveAffect( $item6->itemnumber, $patron1->{borrowernumber} ); my $r6 = Koha::Holds->find( $reserve6->{reserve_id} ); is( $r6->expirationdate, $reserve6_expirationdate->ymd, 'Expiration date should be set to today + 4 based on circulation rules and including a holiday' ); $schema->storage->txn_rollback;