Commit Graph

372 Commits

Author SHA1 Message Date
koha 05965fb56d Bug 5283 NEWS ITEM FOR RECEIPT SLIP
There is no on-off global parameter for it since if a library does not want to
use it, then the library will not use the "slip" category in news - this is
similar to the OPAC news and Staff news categories in the news feature.

We have been using this for months in Koha 3.0 and the librarians like it and
so does PR as it gives a way to advertise events and news to patrons with every
checkout.

The files modified are:
koha-news.tmpl
moremember-receipt.tmpl
moremember.pl

Darrell Ulm

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-17 09:39:11 +13:00
Chris Cormack 00408e262f Merge remote branch 'kc/new/bug_5030' into kcmaster 2010-12-02 09:20:14 +13:00
Owen Leonard 9f0495238d Fix for Bug 5030 - Improve handling of duplicate patrons
- Making duplicate patron warning dialog simpler but more explicit
- Pointing duplicate patron preview window to new brief version
  of moremember.pl to display more patron details than the previous
  version.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 09:16:07 +13:00
Owen Leonard f7b3b0c75b Fix for Bug 5029 - Update patron deletion error page
- Styling error message with "dialog alert" class
- Adding sidebar patron details to match other patron pages

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-02 09:13:38 +13:00
Koustubha Kale 7f0c1e4fcb Bug 4440: Revised combined patch to print fee receipts and invoices
This patch adds a small enhancement to allow printing of Fees  / Fines
receipts from the Fines page.

Patch adds print links to the Fines page next to Fines or Receipts
transactions.

Clicking on the link will pop a new window and will print that with
total outstanding as on date.

You can edit koha-tmpl/intranet-tmpl/prog/en/css/printreceiptinvoice.css
to better control printing this type of material.

18-Oct-2010 Changed template and script names to match. Corrected
invalid markup in the templates.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-18 14:33:27 +13:00
Owen Leonard bbb0819f0f Fix for Bug 5037 - If patron category is empty it shouldn't show
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-17 21:07:13 +13:00
Andrew Elwell 9fa574f609 Bug 5385: POD Cleanups (part 1)
working through the master branch to eliminate all
podchecker warnings/errors

Actual improvement to the quality of the POD will
come later (hopefully with assistance of others)

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-12 10:06:55 +13:00
Katrin Fischer 63fdd8768a Bug 5112: Organisation does not show links to professionals
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-12 09:40:50 +13:00
Katrin Fischer 863830f3f9 Bug 5003: Can not search for organisation by name
Rebased to current HEAD, small error fixed.
Should also apply to 3.2

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-11 09:35:41 +13:00
Colin Campbell 171802b174 Fix compile time warning in member.pl
variable to declared twice

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:58:40 -04:00
Frédéric Demians 03ff10ba02 Bug 5201 Patron surname dropped
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:18:52 -04:00
Owen Leonard f976eaa916 Follow-up fix for Bug 5013, "New patron" menu button broken
Menu was working on members-home.pl but not on members.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-19 10:35:47 -04:00
Owen Leonard 3452d0f267 Fix for Bug 5013 "New patron" menu button broken on patron select screen
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-15 22:05:19 -04:00
Henri-Damien LAURENT 5f5d093c5b (bug #4954) allow date expiry modification only on step 0 and 3
This add a verification, to allow automatic modification of expiry date, only if we are on a page that allow modification of expiry date.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-07 12:10:33 -04:00
Garry Collum d4f6974581 Bug 2725: Fixes uppercasesurnames preference.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-06 08:18:47 -04:00
Galen Charlton d3ece118f1 bug 4808: allow limited-permission circ operators to print receipts
Staff users now only need circulation privileges to print
checkout receipts and slips; the 'borrowers' permission, which
allows editing patron records, is no longer required.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-02 14:57:25 -04:00
Galen Charlton 573ac9488f remove a bunch of unconditional debug warns
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-02 10:57:08 -04:00
Galen Charlton 0700a8b732 bug 4896: granular permissions now always on (DB rev 138)
Per the following koha-devel thread, the use of
staff user subpermissions, AKA granular permissions, is
now the default behavior in Koha.  This patch removes
the GranularPermissions system preference.

[1] http://lists.koha-community.org/pipermail/koha-devel/2010-February/033670.html

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 07:56:03 -04:00
Galen Charlton 340f8f0725 bug 4508: fix crash when editing patron attributes or message prefs
When editing patron attributes or messaging preferences on the
patron editor, Koha would crash with the following error:

Software error:
Can't use an undefined value as an ARRAY reference at
/home/koha/kohaclone/C4/SQLHelper.pm line 186.

This would occur only when editing the specific attribute
or message preferences section, not when editing the entire
patron record.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-26 10:52:44 -04:00
Galen Charlton ef58c445d3 removed needless imports of the YAML module
Removed instances of 'use YAML' that were either completely
unnecessary or which were used only in debug code.  Also
removed a needless import of Data::Dumper.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 23:30:48 -04:00
Matthias Meusburger 6710641eee MT2582: Fix user deletion without permission
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 08:39:19 -04:00
Frédéric Demians 257a179c3e Bug 4470 Patron search result pagination bar
Obviously, Koha global pagination function could be improved. This patch
do something which belongs to this function. A CPAN module like
Data::Page could help or be an inspiration... 3.4?

There is also room for improvement in they way resultset are
constructed. The whole set is retrieved and just a subset is displayed.
It impacts performances for libraries with a great number of patrons.
The right solution would be:

  - to find the resultset size with SELECT COUNT(*)
  - to retrieved the exact subset with LIMIT and OFFSET SQL arguments

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 06:09:36 -04:00
Kyle M Hall 3a5b075c90 Fixed Patron Search Results
By default, the patron search was pulling results in *Descending* order,
then reordering the results on the page using javascript in *Ascending* order.

This was causing screwy results where the entire list of results of multiple
pages was not in complete alphabetical order.

Fixed by changing the SQL to pull in Ascending order.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 08:57:04 -04:00
Colin Campbell cb031bace9 Bug 2889 Remove toggle in boraccount display
Also remove the reverse column if no contents to be displayed
( otherwise looks like a markup error )
Rationalize the main loop now toggle not required

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-03 09:20:50 -04:00
Matthias Meusburger e4a6abbf1a MT3440: Display only borrower's messages in borrower's profile
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-01 09:11:44 -04:00
Kyle M Hall db8bda86ea Search Patrons - Make patron search more forgiving.
Patron search has only been searching fields for names
that either match or begin with the given search terms.

This is too strict a search.
For example, take the name "Billie Jo Robinson", "Billie Jo"
being the firstname, and "Robinson" being the last name. If one
were to search for "Billie Jo", this patron would not appear in
the search results.

 To remedy this, the search
type has been changed from 'begins_with' to 'contain'.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:45:29 -04:00
Colin Campbell e7bdbd0583 Bug 4248 Rework Cities dropdown for members entry
Garry Collum's patch correctly identified the core flaw in operation
looking closer revealed some other flaws (2 "blank" options, some vars
and documentation belonging to a superceded version, etc.
Changed GetCities to return a structure rather than the messy two returns
Let the template do the concatenation and removed the CGI::Popup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:20:36 -04:00
Henri-Damien LAURENT c1f91af476 MT3212 : members modification wipeout dateexpiry
Members modification when not in Library information mode would wipe out dateexpiry information

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:33:51 -04:00
Donovan Jones 0718cc8b6d Bug 2505 - Add commented use warnings where missing in the members/ directory 2010-04-21 20:19:50 +12:00
Galen Charlton d20305cca1 tweak display of issuing library on staff reading history
Following idea in patch submitted by Kyle Hall on 1 April 2010,
use issues.branchcode instead of issues.issuingbranch to set
displayed issuing library.  Also tweaked wording.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 10:57:47 -04:00
Paul Poulain b7ce86240e [MT3191] follow-up, removing warn
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 09:57:11 -04:00
Paul Poulain c6e04e8b40 [MT3191] various perl errors in script (merge conflict)
and SQL error solved

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 09:57:03 -04:00
Jean-André Santoni 732e1f954d [MT2195] Display issuing branch in reading record
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 09:56:54 -04:00
Nahuel ANGELINETTI c5c83ed8d7 (MT #2920) fix reading record scripts
This patch fix some perl ugly code to be more readable and lesser complex.
And it allow in intranet to order by issues.timestamp.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 09:56:33 -04:00
Jean-André Santoni 576e544d02 [MT2358] Display issue date in member reading record
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 09:56:23 -04:00
Lars Wirzenius e8df566734 Fix FSF address in directory members/
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:17:55 -04:00
Chris Nighswonger 7e3e572436 Enhancement: This patch adds a 'cardnumber' parameter and checks
to see if it is present when the script is called. If it is, the patron
information is retrieved and borrowernumber set from that. Otherwise,
the patron information is retrieved by borrowernumber.

The changes in this patch do not require porting to any other Koha code.

Sponsored by www.digital-loom.com

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-02 18:47:21 -05:00
Henri-Damien LAURENT e154413382 Revert "MT2232 : members/notices.pl and members/messaging.pl are doing the same thing"
This reverts commit 653de3c295b5b21ddfe11f0597b4ba7092f1effc.
Should remove members/notices.pl instead
2010-01-28 15:11:57 +01:00
Henri-Damien LAURENT 1e1c87a1af (followup MT2690) search on first letter
followup commit 5a669826fa8e6cfbf2c53aa40271e0a2f8465a6c
letters were not introduced in first page
2010-01-28 15:11:57 +01:00
Nahuel ANGELINETTI d639b9b79d (MT2690) fix search by letter
This patch fix searching by name that "begins" by one letter, using now the quicksearch arg.
And improve a bit the template, now it won't list all the alphabet...
2010-01-28 15:11:55 +01:00
Nahuel ANGELINETTI ed9d4873d4 Fix ordering in member search
This fix the default ordering when the librarian browser by "last name". It must be ordered by "family name".
2010-01-28 15:11:55 +01:00
Henri-Damien LAURENT 7540dda2eb Bug Fixing Search By initials incorrect
Adding a research scope : field_start_with
Using this kind of research if searching by initial
2010-01-28 15:11:55 +01:00
Henri-Damien LAURENT 6a3579b2f3 MT 2285 : enhancement for patronSearch 2010-01-28 15:11:51 +01:00
Nahuel ANGELINETTI 05b61e4f3a (bug #3745) fix deletion of borrowers rights detection
This patch fix the rights checking for borrower deletion.
2010-01-28 15:11:49 +01:00
Matthias Meusburger 20df800fae MT2232 : members/notices.pl and members/messaging.pl are doing the same thing 2010-01-28 15:11:45 +01:00
Nicole Engard 3c832b0375 Bug 2662: make rand password consider minPasswordLength pref 2009-12-22 00:01:03 +01:00
Henri-Damien LAURENT 151ea5a06b Adding userid to search in member.pl 2009-11-06 12:37:01 +01:00
Henri-Damien LAURENT ce8c3275a6 Removing default selection of userbranch for research 2009-11-06 12:33:15 +01:00
Henri-Damien LAURENT a2d34166d6 Improving patron search in serials routing
Adding category and library search
Unifying with central member search
2009-10-29 11:56:08 +01:00
Henri-Damien LAURENT 3c8607b0e1 MT 1716 : Followup : search by initial was broken
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-10-07 23:27:54 +02:00