Commit Graph

2944 Commits

Author SHA1 Message Date
David Bourgault bb2ff03ff7 Bug 19422: Missing DROP TABLES in kohastructure.sql
Adds DROP TABLE statements to the following tables
    - article_requests
    - biblio_metadata
    - deletedbiblio_metadata

Test plan :
Clean your database by running 'mysql < kohastructure.sql'.
Without patch you'll get error messages.
With patch everything will work fine, no warnings.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 2386e33dbb)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2018-01-31 09:05:43 +01:00
Jonathan Druart 3c7f2da486 Bug 19973: Fix SQL syntax error in uk-UA/mandatory/sample_notices.sql
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit a44804f015)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2018-01-31 08:30:11 +01:00
Jonathan Druart 56f1a54656 Bug 18915: Add CHECKOUT_NOTE notice template for other languages
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit ceeb92081a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2018-01-30 09:26:51 +01:00
Fridolin Somers f9efe84a2d Bug 18915: DBRev 17.05.08.001
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2018-01-30 09:26:40 +01:00
Marcel de Rooy 387b40bf23 Bug 18915: (QA follow-up) Add note for installs after 17.05
Since the 17.05 upgrade adds the note and the sql file did not yet include
the note, we should add it when it is not there (for example new 17.11s).

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested by running the dbrev while there is a letter and while not.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit e7dd617de0)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2018-01-30 09:20:20 +01:00
Aleisha Amohia 7d1409e188 Bug 18915: Fix checkout note email message
This patch replaces the <<biblio.item>> in the email with
<<biblio.title>> and uses CHECKOUT_NOTE instead of PATRON_NOTE.
This patch also adds the notice to
installer/data/mysql/en/mandatory/sample_notices.sql, and updates the
PATRON_NOTE entry in installer/data/mysql/updatedatabase.pl

To test:
1) Apply patch and update database
2) View the message_queue table in mysql
3) Check out an item if haven't already
4) Go to OPAC and set a checkout note for an item
5) View message_queue table and confirm it the title is included in the
email and all instances of 'patron note' have been replaced with
'checkout note'
6) Disable javascript in browser
7) repeat steps 4 and 5 and confirm all works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit c199ced310)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2018-01-30 09:14:22 +01:00
Fridolin Somers 605ff8292c Increment version for 17.05.08 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2018-01-23 08:58:40 +01:00
Fridolin Somers a8fd1b7a6f Increment version for 17.05.07 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-12-23 10:58:13 +01:00
Fridolin Somers ad91d8f732 Bug 19724: DBRev 17.05.06.001 2017-12-20 12:25:32 +01:00
Nick Clemens de025f7627 Bug 19724: Add timestamp to biblio_metadata and deletedbiblio_metadata
Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
We need to know the last modification time of the MARC record for some
features (like OAI-PMH parameters 'from' and 'until' for instance)

This patch only adds the missing column in biblio_metadata and
deletedbiblio_metadata

Test plan:
1. Run updatedatabase.pl
2. Verify that both tables have the new column, its value should be the
   greatest timestamp value from the corresponding biblio and
   biblioitems table entries
   You can verify with the following SQL query:
     SELECT b.biblionumber, b.timestamp as biblio_ts,
     bi.timestamp as biblioitems_ts, m.timestamp as biblio_metadata_ts
     FROM biblio_metadata m
     LEFT JOIN biblioitems bi ON (bi.biblionumber = m.biblionumber)
     LEFT JOIN biblio b ON (b.biblionumber = m.biblionumber);

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druat <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 4db611b5dc)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-12-20 12:14:54 +01:00
Mark Tompsett ba1af627c7 Bug 10222: Correct and expand to other languages
This added column names, and reformated to be a bit more readable.
This also adds this change to de-DE, es-ES, fr-CA, and nb-NO.
While there was printer_profiles for it-IT, the Italian file seems
to not use the same numbers, and does not visibly look like it needs
these changes.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit fdde85a521)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-12-20 12:09:13 +01:00
Chris Nighswonger 6279d087a5 Bug 10222: Error when saving Demco label templates
This patch fixes a bug whereby if you open either of the
Demco label templates (loaded by the sample data) and
click "save" without making any changes you will get an
error:

Can't bless non-reference value at C4/Creators/Profile.pm
line 92.

It also fixes another minor bug in the creator sample data.

To test:

1. Install all sample data in a clean database.
2. In the label tool, edit either of the Demco label templates.
3. Save the template and observe the error mentioned above.
4. Drop and recreate the database.
5. Apply the patch.
6. Repeate steps 1-3 and note the successful save.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit d3eef921f5)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-12-20 12:09:07 +01:00
Fridolin Somers f01a220abd Increment version for 17.05.06 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-11-22 14:58:59 +01:00
Fridolin Somers 6e37d51cbc Bug 19344: DBRev 17.05.05.003
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-10-27 14:11:11 +02:00
Jonathan Druart 8c5fbecd0a Bug 19344: Reorder lang and login_attempts in the [deleted]borrowers tables
Due to a bad rebase, the borrowers and deletedborrowers table structure
may different from a new install and upgraded install
For new installs, the order was: lang, login_attempts
For upgraded installs, it was lang, last_seen, login_attempts

After this patch, the order must be:
- last_seen
- lang
- login_attempts

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit e65ee89aae)
2017-10-27 14:04:36 +02:00
Jonathan Druart 6db90c0cb9 Bug 18801: DBRev 17.05.00.003
(cherry picked from commit 83e4adf0ab)
2017-10-23 15:56:38 +02:00
Marcel de Rooy ed45e76bf9 Bug 18801: [Follow-up] Dbrev to repair bad auth type codes
Test plan
Run updatedatabase.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit aa03981e79)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-10-23 15:56:38 +02:00
Jonathan Druart 96e747dca3 Bug 18811: DBRev 17.05.00.006
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit dc60c34476)
2017-10-23 15:35:40 +02:00
Marcel de Rooy 2ee997768d Bug 18811: Atomic update to print warning at upgrade time
The warning encourages people to run the auth_show_hidden_data script
to check for data in hidden fields and adjust their frameworks.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit f45fc4d10b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-10-23 15:32:26 +02:00
Fridolin Somers 17f207f2e9 Increment version for 17.05.05 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-10-23 14:46:37 +02:00
Serhij Dubyk {Сергій Дубик} e73f59c607 Bug 18537 - Update Ukrainian installer sample files for 17.05
Update and translate sample SQL files of the Ukrainian installer.

To test:
- Start with an empty database
- Install uk-UA
- Run the web installer in uk-UA/Ukrainian
- Verify all files load without any problems.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ce2561441c)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-09-29 15:33:00 +02:00
Tomas Cohen Arazi 1f19154532 Bug 19013: (QA followup) Set guarantorid to NULL patron sample data
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 0bcf6a7942)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-09-29 10:44:20 +02:00
Jonathan Druart b59ce0c617 Bug 19013: Fix borrowers.guarantorid in sammple_patrons.sql
That breaks randomly tests on Jenkins (Koha/Patrons.t)

It certainly affects data in other languages but I did not find a quick
and easy way to modify this file (replace all guarantorid values with
NULL)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Easy fix

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit b7d291a1ee)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-09-29 10:44:13 +02:00
Fridolin Somers d426333605 Increment version for 17.05.04 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-09-20 16:05:19 +02:00
Fridolin Somers 47a61e683f Increment version for 17.05.03 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-08-24 09:39:00 +02:00
Fridolin Somers 3c1ffea14e Increment version for 17.05.02 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-07-27 14:10:55 +02:00
Lee Jamison ad5d72658b Bug 18848: borrowers.lastseen comment typo
Typo in comment for the lastseen column in the borrowers table.

To test:
1. Verify lastseen column displays "last time a patron has been seed"
2. Apply patch
3. Verify lastseen column changed to "last time a patron has been seen"

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit e3bf4fc8bb)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-07-12 11:52:14 +02:00
Lee Jamison 0905eabc45 Bug 18848: borrowers.lastseen comment typo
Typo in comment for the lastseen column in the borrowers table.

To test:
1. Verify lastseen column displays "last time a patron has been seed"
2. Apply patch
3. Verify lastseen column changed to "last time a patron has been seen"

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 23b84c0b65)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-07-12 11:51:54 +02:00
Fridolin Somers 279b689a2b Increment version for 17.05.01 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-06-23 10:05:45 +02:00
Marc Véron 7ff2fd6e9a Bug 18690 - Typos in Koha database description (Table "borrowers")
This string patch fixes typos in kohastructure.sql as described in initial
comment.

To test:
- Carefully verify that string changes make sense

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 279126d710)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-06-12 10:55:49 +02:00
Kyle M Hall 5d94ff7513 DBRev 17.05.00.000 2017-05-30 03:14:40 +00:00
Kyle M Hall 2764251be3 Bug 18600 - DBRev 16.12.00.039
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-28 22:21:16 -04:00
Jonathan Druart ec4b976289 Bug 18600: Add pref TalkingTechItivaPhoneNotification if missing
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-28 22:19:20 -04:00
Kyle M Hall 1d7ecebfd2 Bug 18663 - DBRev 16.12.00.038
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-28 22:05:48 -04:00
Jonathan Druart 6f29c775d9 Bug 18663: Add pref ExportRemoveFields if missing
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-28 22:03:17 -04:00
Jonathan Druart 24313d2b8a Bug 17762 - (follow-up) DBRev 16.12.00.033 2017-05-15 14:43:33 -03:00
Kyle M Hall b8b5989292 Bug 18314 - DBRev 16.12.00.037
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-12 10:59:15 -04:00
Jonathan Druart 1e9f3e721d Bug 18314: Add pref FailedLoginAttempts and columns borrowers.login_attempts
And of course deletedborrowers.login_attempts

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-12 10:58:35 -04:00
Kyle M Hall e7a197a5e8 Bug 17465 - DBRev 16.12.00.036
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 21:20:40 +00:00
Aleisha Amohia 23a2cd5214 Bug 17465: NumSavedReports syspref
To test:
1) Apply patch and update database
2) Go to system preferences. Default value should be 20 reports.
3) Go to Reports -> Use saved. Confirm 20 results are showing
4) Change value in syspref to any integer (i.e. 50)
5) Go back to Reports -> Use saved. Confirm the number of results shown
is based on the value in the syspref.

Sponsored-by: Catalyst IT

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 21:17:53 +00:00
Kyle M Hall c6367282da Bug 15705 - DBRev 16.12.00.035
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 21:16:05 +00:00
Nick Clemens 10b94f676d Bug 15705 (QA Followup) Remove unused variable, fix typo and add due date to notice
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 21:09:09 +00:00
Nick Clemens 1bc3fe4d91 Bug 15705: DB Changes - Add [old_]issues.auto_renew_error and the AUTO_RENEWALS notice
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 21:09:09 +00:00
Kyle M Hall 115d4f7d2f Bug 15582 - DBRev 16.12.00.034
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 21:08:06 +00:00
Jonathan Druart 8924f1e236 Bug 15582: DB changes - add new pref OPACFineNoRenewalsBlockAutoRenew
Sponsored-by: University of the Arts London
Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>
Signed-off-by: Janet McGowan <janet.mcgowan@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 21:05:28 +00:00
Kyle M Hall 66ec5909ed Bug 17762 - DBRev 16.12.00.033
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 21:01:40 +00:00
Jonathan Druart f244dd3859 Bug 17762: Add lang to the PK of letter
We need to enlarge the PK of the letter table.

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud <hagud@orex.es>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 20:56:41 +00:00
Jonathan Druart 0137e49d6f Bug 17762: Remove FK on message_transports
I don't really understand where does come from this foreign key but at first glance it does not make sense.

Note that it seems we could also remove message_transports.branchcode

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud <hagud@orex.es>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 20:56:40 +00:00
Jonathan Druart 2b35e37d7f Bug 17762: Add the new TranslateNotices syspref
This whole patch set adds the ability to translate notices in different
languages.
That way, if a library has patrons from different countries, they will
not have to send the notices in only one language but they will be able to
translate them.

Test plan:
- Switch on TranslateNotices
- Translate the interface in different languages
- Edit patron's details
=> You should see a new "prefered language" entry
That language will be used to send notices to this patron
- Edit several notice templates
=> You should see different tabs, 1 tab per language translated at the
opac (which sounds to make sense)
- Now the notice generated for this patron should be the one translated
in the language picked for him
To confirm that, try to generate several notices for this patron.
If the notice is not translated, the default one should be used.

Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud <hagud@orex.es>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 20:56:40 +00:00
Jonathan Druart 613c6508f0 Bug 17762: DB changes - Add new 'lang' columns to letter and borrowers tables
Sponsored-by: Orex Digital

Signed-off-by: Hugo Agud <hagud@orex.es>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 20:56:40 +00:00