Commit Graph

1758 Commits

Author SHA1 Message Date
Fridolin Somers 4ffa5ff5cd Increment version for 3.14.15 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2015-04-23 09:42:50 +02:00
Fridolin Somers f4a46e8c3d Bug 13523 - DBrev 3.14.14.001 2015-04-22 09:13:42 +02:00
Benjamin Rokseth bd37451619 Bug 13523 - AddBiblio fails on mysql with STRICT_TRANS_TABLES
This patch removes the NOT NULL restriction on biblioitems.marcxml and
deletedbiblioitems.marcxml due to STRICT_TRANS_TABLES default in
Mysql 5.6.22 and onwards.

Test:

1. check mysql global settings:
   mysql > SELECT @@GLOBAL.sql_mode;
   verify that STRICT_TRANS_TABLES is not set
2. set STRICT_TRANS_TABLES (or upgrade mysql to > 5.6.21)
   mysql > SET @@GLOBAL.sql_mode = 'STRICT_TRANS_TABLES';
3. try to add biblio in Cataloguing module
   verify that it fails with a "software error"
4. apply patch
5. repeat 3 and verify that there is no "software error" any more

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I confirm with the problem with mariadb and STRICT_TRANS_TABLES enabled.
On adding a biblio (C4::Biblio::AddBiblio), biblioitems is populate in
_koha_add_biblioitem but marxcml is not generated yet. It's in
ModBiblioMarc, few lines later.
The NOT NULL condition is not valid here.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
(cherry picked from commit 4eaa86acff)

Conflicts:
	installer/data/mysql/updatedatabase.pl
2015-04-22 09:11:39 +02:00
Fridolin Somers c426d4617d Increment version for 3.14.14 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2015-03-25 17:39:17 +01:00
Fridolin Somers c38c77ee3c Increment version for 3.14.13 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2015-01-23 15:16:31 +01:00
Fridolin Somers 04e5270d77 Increment version for 3.14.12 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-12-22 17:46:35 +01:00
Fridolin Somers f1f566b771 Increment version for 3.14.11 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-10-02 14:38:41 +02:00
Fridolin Somers 439a4b9d0a Increment version for 3.14.10 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-09-03 17:38:42 +02:00
Jonathan Druart 5d5c15f873 Bug 10138: (follow-up) FIX sql errors
There were 2 INSERT in error.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I have gone ahead and fixed the typo pointed out by Mathieu:
Endommadgé-> Endommagé

Sample files install without problems, tests look good.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit e81513199c)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-08-13 09:25:12 +02:00
Mathieu Saby ee7fb5e8ec Bug 10138: Add some authorized values in French installer; small fixes in frameworks
This patch adds some categories of values in French installer :

- SUGGEST
- OPAC_SUG
- REPORT_GROUP
- LOST
- DAMAGED

SUGGEST and OPAC_SUG are used by Suggestions module.
REPORT_GROUP is used by Reports module.

It also adds a new status for "ETAT" (en commande)

It creates a 995$2 subfield in french frameworks when it did not exist.
It links existing 995$2 subfield with LOST category.

It cleans up the list of authorised values installed with "Lecture
publique" framework :

- some codes are moved in general 1-Obligatoire/authorised_values.sql
  (SUGGEST, REPORT_GROUP)
- some are suppressed, because they are also defined in
  1-Obligatoire/authorised_values.sql (langue, COUNTRY, statut)
- the code for inserting the ones left is changed (I suppress the `id`
  column)

To test :
1. Take a fresh new Koha
2. Install Koha choosing French installer and UNIMARC Lecture publique
3. Check the authorised values are imported
4. Check the cataloguing frameworks are usable :
   especially 995 $2 field, which must be mapped with LOST values :
   Perdu, Long retard, Perdu et remboursé, Introuvable
   you can also check 101$a (language codes), 102$a (country codes)
5. In OPAC, make a suggestion. See if you can select a cause for your
   suggestion ("Bestseller" or "'L'exemplaire en rayon est endommagé")
6. In staff interface, manage some suggestions. See if you can select a
   cause for rejection or acceptation ("Bestseller", "Budget
   insuffisant" etc)
7. In reports, see if you can sort reports according to values of
   REPORT_GROUP ("Circulation", "Catalogue", "Adhérents" etc)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comments on second patch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit e5fe771cc9)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-08-13 09:24:52 +02:00
Fridolin Somers 3664bc6cfd Bug 12052: DBrev 3.14.09.001
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-08-06 11:39:45 +02:00
Jonathan Druart 377218b506 Bug 12052: New syspref to display message on the OPAC patron summary page
Test plan:

Fill the OPACMySummaryNote with HTML code or just text.
The content should be displayed at the OPAC on the summary page for
patrons.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described. No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes tests and QA script.
Rephrased the pref text a little bit, using 'logged in' instead of
'connected', also added " so the description appears correctly in the
pref editor.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit f82d22b0df)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-08-06 11:37:39 +02:00
Fridolin Somers 7682e4203c Increment version for 3.14.9 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-07-25 14:54:36 +02:00
Galen Charlton d98d2721b3 Bug 10951: (follow-up) tweak description of the NoLoginInstructions system preferences
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit bebe165266)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Conflicts:
	koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
2014-07-11 09:12:27 +02:00
Fridolin Somers eebd413c51 Bug 10951: DBrev 3.14.08.001
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-07-11 09:09:57 +02:00
Jonathan Druart abde76056d Bug 10951: The new pref NoLoginInstructions should be empty by default.
We don't want to display an English message by default for everybody.
The default message is in the template, so the pref should be empty.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
(cherry picked from commit 71f0d16397)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-07-11 09:08:42 +02:00
blou 6cf5de9300 Bug 10951 - Adding NoLoginInstructions to system preferences
On a failed login, the default message is harcorded into opac-auth.tt.

     It would be preferable to allow for a preference to override that message (for example: ...Please bring an ID to t
     The changes modify
         -opac-auth.tt to allow for custom value
         -admin/preferences/opac.pref to add it to the preferences with a description
         -C4/Auth.pm for the loading of the preference
         -sysprefs.sql
         -updatedatabase.pl

     TESTING
         1) in OPAC, logged out, try login in by entering no or wrong credentials.  Acknowledge the "Don't have a p
         2) Apply the patch
         3) Regression Test: Redo step 1.  Same (default) message should appear.
         4) Log in to intranet,
             - select NoLoginInstructions in system preferences.
             - Enter new (xml) message.  Possible:
             <h5>Welcome to Koha, please bring your passport to the front office</h5>
            - and save
         5) refresh the OPAC, try login again with invalid credentials.  The new message should appear.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
(cherry picked from commit c67b397236)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Conflicts:
	installer/data/mysql/updatedatabase.pl
	koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
2014-07-11 09:07:16 +02:00
Fridolin Somers 9a1b64c518 Increment version for 3.14.8 release 2014-06-26 14:52:12 +02:00
Jonathan Druart 0e6a85ad7c Bug 11939: set active currency for non-English sample data
Revised Test Plan
-----------------
The following SQL commands were used to test this.

installer/data/mysql/en/optional/parameters.sql is part of the
first patch and didn't really need testing again.

installer/data/mysql/de-DE/optional/parameters.sql is not part
of the patch, but since I was playing with the script, which
is also attached here, it was included for good measure.

use kohadata;
SET FOREIGN_KEY_CHECKS=0;
TRUNCATE currency;
source /home/mtompset/kohaclone/installer/data/mysql/pl-PL/optional/parameters.sql
SET FOREIGN_KEY_CHECKS=0;
TRUNCATE currency;
source /home/mtompset/kohaclone/installer/data/mysql/es-ES/optional/parameters.sql
SET FOREIGN_KEY_CHECKS=0;
TRUNCATE currency;
source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql
SET FOREIGN_KEY_CHECKS=0;
TRUNCATE currency;
source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql
SET FOREIGN_KEY_CHECKS=0;
TRUNCATE currency;
source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql
SET FOREIGN_KEY_CHECKS=0;
TRUNCATE currency;
source /home/mtompset/kohaclone/installer/data/mysql/de-DE/optional/parameters.sql
SET FOREIGN_KEY_CHECKS=0;
TRUNCATE currency;
source /home/mtompset/kohaclone/installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql
SET FOREIGN_KEY_CHECKS=0;
TRUNCATE currency;
source /home/mtompset/kohaclone/installer/data/mysql/en/optional/parameters.sql

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit ed10e5226c)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-06-12 11:31:30 +02:00
Zeno Tajoli 9eb55874ca Bug 11939: set active currency when using English sample data
This patch offers a better default for currencies,
with USA dollar as default active currency.

To test the patch:
1)Install master without the patch, during web installation
select 'parameters.sql' file
2)Finish install and go to Administration -Currencies & Exchange rates
3)No active currency

4)Install master with this patch, during web installation
 select 'parameters.sql' file
5)Finish install and go to Administration -Currencies & Exchange rates
6)Now USA dollar is the active currency

NOTE: This does solve the problem of everything being NULL for active,
      and lacking an active value. It also corrects the description
      of the optional item to check related to currencies.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests and QA script.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 6a5c2d5181)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-06-12 11:31:15 +02:00
Fridolin Somers d2d782a2b9 Bug 11973 - DBRev 3.14.07.002
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-06-12 11:21:55 +02:00
Bernardo Gonzalez Kriegel b41e6ca1b6 Bug 11973 - Fix Armenian language description
This patch fix Armenian language description

To test:
1) Do a fake translation to Armenian,
   mkdir koha-tmpl/intranet-tmpl/prog/hy-Armn
2) Go to Administration > System preferences > I18N/L10N
3) Armenian description looks like the second string in Bug description
4) Apply the patch
5) Run updatedatabase.pl
6) Reload page, now description look as first string in
Bug description (it's the sixth letter, similar to 't')

Ammended patch, wrong column.

Signed-off-by: Holger Meißner <h.meissner.82@web.de>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch fixes the English sample file for translations and includes
a database update to correct the string in existing installations.
Passes all tests and QA script.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 8f8ce37e88)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-06-12 11:18:33 +02:00
Jonathan Druart a9a15f38f5 Bug 11957: reomve disused sample_only_param_tables.sql
This sql file tries to insert data into nonexistent tables.
It is useless and can be removed.

Test plan:
  git grep sample_only_param_tables
should not return any result.

NOTE: This is basically a git rm. Simple patch.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
File is not used by the installers and it wouldn't work
with today's Koha for trying to insert data into non-existant
tables and tables with different structure.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 9c7f137f5e)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-06-12 11:17:02 +02:00
Galen Charlton b612cbfc9c Bug 7372: (follow-up) remove last traces of roadtype table and admin pages
This patch removes the DBIC schema class for the 'roadtype' table
and staff interface templates that are no longer reachable with
the removal of the road type administration page.  It also removes
the creation of the table during installation.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 2be50eba0f)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-06-03 12:19:18 +02:00
Fridolin Somers 8bd1737caa Bug 7372: DBRev 3.14.07.001
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-06-03 12:19:14 +02:00
Jonathan Druart ae4bfafba2 Bug 7372: Move road types from the roadtype table to the ROADTYPE AV
Currently road types are stored in a specific table in DB. Moreover, an
admin page is present in order to manage them.
This patch proposes to remove this table and this page in favour of a
new authorised value category 'ROADTYPE'.

This patch:
- adds a new AV category 'ROADTYPE' (created from the roadtype table
  content).
- remove the roadtype table.
- remove the .pl and .tt file admin/roadtype
- remove the 2 routines C4::Members::GetRoadTypes and
  C4::Members::GetRoadTypeDetails

Test plan:
1/ Execute the updatedatabase entry and verify existing roadtypes are
now stored in the AV 'ROADTYPE'.
2/ Verify you can add/update a streettype for patrons.
3/ Verify on following pages the streettype is displayed in patron
information (top left):
  circ/circulation.pl
  members/memberentry.pl
  members/moremember.pl
  members/routing-lists.pl

Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit a691ebc3f1)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Conflicts:
	installer/data/mysql/updatedatabase.pl
2014-06-03 12:19:03 +02:00
Fridolin Somers c511b47cc0 Increment version for 3.14.7 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-05-27 18:24:21 +02:00
Fridolin Somers 3183ac7754 Bug 10012 - DBRev 3.14.06.005
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-05-27 18:10:57 +02:00
Galen Charlton 5a05930e12 Bug 10012: remove last traces of NoZebra
This patch removes the last traces of NoZebra:

[1] The DBIC schema class for the nozebra table
[2] References to the NoZebra and NoZebraIndexes sysprefs
    in the Italian SQL scripts.
[3] Deleting the NoZebraIndexes syspref if it's still present.

To test:

[1] Verify that after applying the patch and running the DB upgrade,
    that "NoZebraIndexes" is no longer to be found in the
    systempreferences table.
[2] Verify that "nozebra" is not referenced anywhere in the source
    code except for the database update scripts.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(cherry picked from commit ffb9e312a9)

Conflicts:
	installer/data/mysql/updatedatabase.pl
2014-05-27 18:09:06 +02:00
Jesse Maseto e83b77985e Bug 11731 - Fixed typo in message_transport_types.txt file.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
String change, all good.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit b648425aee)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-05-27 16:48:21 +02:00
Fridolin Somers d476676d9e Bug 3445 - DBRev 3.14.06.004
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-05-27 16:38:06 +02:00
Fridolyn SOMERS 0f1562c429 Bug 3445: add more indexes on the action_logs table
This patch adds database indexes for action_logs table to speed up the
"log viewer" page.

Removes the existing index on timestamp+user to add an index on each
column since search colums are separately defined in log viewer form.

Test plan:
- Update database
- Play with log viewer : /cgi-bin/koha/tools/viewlog.pl
- Perform searches with only one filter defined
- Also check you see indexes with SQL query :
    SHOW CREATE TABLE action_logs

Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Rephrased the updatedatabase message a bit:
Add indexes to action_logs table
Passes all tests and QA script.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 6f728fb050)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-05-27 16:36:58 +02:00
Fridolin Somers 442046712b Bug 11343: DBRev 3.14.06.003
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-05-27 16:33:30 +02:00
Jonathan Druart a8719d90ae Bug 11343: The max number of items to process in a batch is hardcoded
Until now, the maximum number of item records to process in a batch was
hardcoded to 1000.
This patch adds a syspref MaxItemsForBatch in order to allow to adapt
this value.

Test plan:
- set the pref to 2
- try to delete a batch of 3 items: they are not displayed
- try to modify a batch of 3 items: you are not allowed to do that
- set the pref to 1000 and try again. Now items are displayed and you
  are allow to modify them.

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 0e8f85a3b3)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Conflicts:
	installer/data/mysql/updatedatabase.pl
2014-05-27 16:32:18 +02:00
Jonathan Druart 1bfb679a08 Bug 11562: re-sort sysprefs.sql
The QA tools does not manage to catch error sorting on the sysprefs.sql
file if it is already badly sorted.

This patch tidies up the sysprefs file.

TEST PLAN
---------
[1] Verify that loading sysprefs.sql into an empty Koha
    database (or one whose system preferences table is
    is empty) works.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

RM note: I must point out that there ZERO functionality associated
with the order that system preferences occur in that SQL script; they are
sorted solely in an attempt to reduce the likelihood of merge conflicts
during the development process.  Consequently, I dislike language that
suggests it is an "error" if sysprefs.sql happens to not be perfectly
sorted; it is at most an inconvenience.

(cherry picked from commit 988dc3b64a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-05-21 10:34:58 +02:00
Fridolin Somers 388130d4b5 Bug 11611: DBRev 3.14.06.002
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-05-21 10:19:53 +02:00
Mathieu Saby 09073898e2 Bug 11611: Rephrase description and examples of 5 MARC related sysprefs
This patch rephrases the description or examples of 5 sysprefs:
1/ MARCAuthorityControlField008: "MARC" -> "MARC21"
2/ itemcallnumber: "Examples" -> "Examples (for MARC21 records)"
3/ DefaultLanguageField008: "Range 35-37" -> "Range 35-37 of MARC21 records"
4/ MARCOrgCode: "new MARC records" -> "new MARC21 records"
5/ UNIMARCAuthorityField100 description: "Do NOT include the date
   (position 00-05)." -> "position 08-35. Do NOT include the date
   (position 00-07)."

It also adds description in SQL systempreferences table for
UNIMARCAuthorityField100, MARCAuthorityControlField008 and MARCOrgCode.

Test plan:
- Apply and run updatedatabase.pl
- Check the changes are taken into account in syspref administration
  page
- Check the changes are taken into account in systempreferences table
  (for UNIMARCAuthorityField100, MARCAuthorityControlField008 and
   MARCOrgCode)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 68a7f7f445)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-05-21 10:18:08 +02:00
Sophie Meynieux 46b69c5a9f Bug 11628: add missing staffaccess permission to French userflags.sql file
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This permission exists in other installer files (for all other languages).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 1b08f92451)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-05-19 16:11:16 +02:00
Fridolin Somers e5c0783d20 Bug 11415: DBRev 3.14.06.001 2014-05-16 12:36:16 +02:00
JaTara Barnes e25da1fa43 Bug 11415: Add syspref to toggle SCO receipt printing
This patch adds the SelfCheckReceiptPrompt to control
whether receipts are automatically printed when a patron
finishes a SCO session.  This is on by default during
new installations and upgrades.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 9cc3b69a0c)

Conflicts:
	installer/data/mysql/updatedatabase.pl
2014-05-16 12:33:06 +02:00
Fridolin Somers 926a874443 Increment version for 3.14.6 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-04-30 17:19:37 +02:00
Galen Charlton 576e8966e9 Bug 11846: DBRev 3.14.05.001
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-04-23 17:32:32 +02:00
Fridolin Somers 730326e08a Bug 11846: Correct database update for restrictions with date 9999-12-31
The borrowers with indefinite restrictions have borrowers.debarred with '9999-12-31'.

Database update for this bug contained :
  INSERT INTO borrower_debarments ( borrowernumber, expiration, comment )
  SELECT borrowernumber, debarred, debarredcomment FROM borrowers WHERE debarred IS NOT NULL

For borrowers where borrowers.debarred is '9999-12-31', this value
is copied into borrower_debarments.expiration.

This is not correct because borrower_debarments.expiration must be
NULL for indefinite restrictions.

This patch corrects update 3.13.00.035 and also adds an update for
databases already updated.

Test plan :
- Use a database with version 3.13.00.000
- Set a borrower as restricted for ever (leave until empty)
- Use sources to master + patch
- Perform updatedatabase
- Look at borrower details, tab "Restrictions"
=> Without patch, you see Expiration 31/12/9999
=> With patch, you see Expiration Infinite

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

I tested both DB revisions by resetting Version of my database (and
adding a SetVersion after the revised older dbrev). This was possible
since the debarred field still exists in borrowers. (I have my doubts
about that, but that goes outside the scope of this report.)

Also note that routine _UpdateBorrowerDebarmentFlags puts back 9999-12-31
into borrowers for indefinite restrictions (which looks not very consistent).

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit f6131d8e60)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-04-23 17:28:47 +02:00
Fridolin Somers 22bd433615 Increment version for 3.14.5 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-03-26 11:37:18 +01:00
Fridolin Somers 1b1f24fbed Increment version for 3.14.4 release
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-02-26 12:48:20 +01:00
Galen Charlton a92da4c82f Bug 11260: (follow-up) repair German sample_z3950_servers.sql
Without this patch, the sample Z39.50 servers for de-DE
would fail to load.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 3c81c7b6f3)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-02-18 09:40:18 +01:00
Galen Charlton 6552616f5a Bug 11260: (follow-up) remove inadvertant change to English sample_z3950_servers.sql
Part of the patch for bug 11260 had the effect of undoing
commit 5aae737, thereby adding back two undesirable things:

- use of backticks in the SQL
- setting z3950servers.id explicitly

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit a39b728364)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-02-18 09:40:12 +01:00
Katrin Fischer ed8282a50a Bug 11260: Follow up - normalizing frequencies in English sample file a bit
After some discussion in IRC I am throwing in some changes for the
English sample frequencies:

- Change Vol to Vol.
- Change No to No.

We had both forms in the file, now it should be consistent.

To test:
- Run English web installer installing all sample files, especially
  frequencies
- Check installed frequencies
- Check available options creating a subscription

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 66bf3abf78)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-02-18 09:40:05 +01:00
Katrin Fischer 4ab0acc67c Bug 11260: Update German web installer - frequencies and numberpatterns
Translates the new files for frequencies and numberpatterns

To test:
- Run the German web installer with all sample files
- Check all files import without errors, especially frequencies and
  numbering patterns
- Check frequencies in serials
- Check numbering patterns in serials
- Create a subscription, check possible choices

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit fff04e59e7)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-02-18 09:39:58 +01:00
Katrin Fischer 5c8674a459 Bug 11260: Update German web installer for 3.14
Mandatory:
- adds auth_values.sql and .txt with YES_NO referenced in patron_attributes.sql
- updates sample notices with redone slip templates (ISSUESLIP, ISSUEQSLIP,
  RESERVSLIP, TRANSFERSLIP)
- adds German translations to subtag_registry.sql and copies updated file
  from en to de-DE
- adds translation for new course_reserves permission to userflags.sql
- adds translations for new permissions in userpermissions.sql
- Fixes typo IndependantBranches in English userpermissions.sql

Optional:
- adds csv_profiles.sql and translation of the serial claims profile
- adds z39.50 servers for authorities to sample_z3950_servers.sql

To test:
- Run web installer in English
  - check all sample files, make sure they all install without SQL errors
  - check language list on advanced search displays correctly still
  - check area/language list on tools > news displays correctly still
  - check permissions for correct spelling of IndependentBranches

- Run web installer in German
  - repeat checks from above
  - also check: authorised values, especially existence of YES_NO
  - all permissions are translated now
  - slip notices are all there and look right
  - new z39.50 servers for authorities are available
  - csv profile for serial claims is available and works as expected

... and anything else you can think of.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit bbe64974b0)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2014-02-18 09:39:42 +01:00