Commit Graph

657 Commits

Author SHA1 Message Date
Tomas Cohen Arazi 9f9b12e859 Bug 22428: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 337ac71167)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
2023-03-01 15:27:40 +00:00
Matt Blenkinsop 65b2c90f58 Bug 30642: (follow-up) Change sql and adapt for translations
New column has now been changed to an enum in line with comments and the strings have been amended to be picked up for translation. The file koha-tmpl/intranet-tmpl/prog/en/includes/str/checkout_renewals.inc has been removed as the variables can be included within the javascript file.

Test plan:
1) In the database shell run "show columns from checkout_renewals;" and observe that there is currently no column for recording the type of renewal
2) Apply patch
3) In the shell run "dbic" and "perl installer/data/mysql/updatedatabase.pl" to update the database schema with the new column.
4) Create some checkouts
5) Renew some checkouts manually and observe in the database that there is now a column called "renewal_type" that will have recorded these as "Manual"
6) Create some checkouts that can be automatically renewed
7) Run the cron script in automatic_renewals.pl and observe that there are now also entries with a renewal_type of "Automatic"
8) Send a GET request to http://localhost:8081/api/v1/checkouts/1/renewals and observe that the renewal_type is now returned in the response
9) In the Item Details tab for a record, there is the "Current renewals" option which has a button to view renewals. Click on this and observe that the modal now displays the new information.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 7fe9e76af8)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
2023-02-13 09:28:58 +00:00
Matt Blenkinsop 5b69dec4e9 Bug 30642: Record renewal type
A requirement has been requested to record whether a renewal was done manually or automatically. A column has been added to the checkout_renewals table in the database to record this and a check is now in place to determine whether the renewal was manual or automatic. The API has also been updated to reflect this new column and return the data when requested. The renewals modal view has also been updated to show what type the renewal was.

Test plan:
1) In the database shell run "show columns from checkout_renewals;" and observe that there is currently no column for recording the type of renewal
2) Apply patch
3) In the shell run "dbic" and "perl installer/data/mysql/updatedatabase.pl" to update the database schema with the new column.
4) Create some checkouts
5) Renew some checkouts manually and observe in the database that there is now a column called "renewal_type" that will have recorded these as "Manual"
6) Create some checkouts that can be automatically renewed
7) Run the cron script in automatic_renewals.pl and observe that there are now also entries with a renewal_type of "Automatic"
8) Send a GET request to http://localhost:8081/api/v1/checkouts/1/renewals and observe that the renewal_type is now returned in the response
9) In the Item Details tab for a record, there is the "Current renewals" option which has a button to view renewals. Click on this and observe that the modal now displays the new information.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 5045da59f1)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
2023-02-13 09:28:38 +00:00
Tomas Cohen Arazi 20feb51ab6 Bug 28674: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 60c0d42359)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
2023-02-13 09:26:00 +00:00
Tomas Cohen Arazi 127502dc7e Bug 31095: DBIC additions and relation name tweak
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit ebb3eac6a1)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
2023-02-01 15:40:46 +00:00
Tomas Cohen Arazi 689446fda0
Bug 32154: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-16 09:24:09 -03:00
Jonathan Druart e216df769e
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole
Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-11 08:59:06 -03:00
Jonathan Druart 8b4ea0beaa
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement
Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-11 08:58:28 -03:00
Tomas Cohen Arazi 80813bab15
Bug 32162: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-11 08:52:41 -03:00
Tomas Cohen Arazi fe85f9d257
Bug 24606: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-10 14:44:59 -03:00
Kyle Hall 9db0d5d9ab
Bug 24606: (QA follow-up) Fix QA script issues
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-10 14:25:31 -03:00
Kyle Hall 16f0117e55
Bug 24606: Update database, add new schema file
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-10 14:25:06 -03:00
Tomas Cohen Arazi 7899841772
Bug 31378: DBIC schema
Sponsored-by: a ByWater Solutions partner

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-10 10:03:25 -03:00
Tomas Cohen Arazi a2f0d33107
Bug 31378: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-08 14:41:43 -03:00
Agustin Moyano 016105cf8c
Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests
Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-08 14:39:51 -03:00
Agustin Moyano 5a84778724
Bug 31378: Add Koha::Auth::Provider(s) class(es)
Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-08 14:30:22 -03:00
Jonathan Druart 96ea0648cb
Bug 32030: DBIC Specific
Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-08 09:44:50 -03:00
Jonathan Druart d391d1a422
Bug 32030: DBIC
Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-08 09:44:49 -03:00
Tomas Cohen Arazi 5157aaa092
Bug 24860: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-04 19:44:59 -03:00
Tomas Cohen Arazi 5c5f8f9806
Bug 31115: Add support for additional fields for invoices
This patch adds support for additional fields for invoices. A new option
is added to the 'Additional fields' admin page, for the 'aqinvoices'
table.

Adding/editing invoices now supports this additional fields.

To test:
1. Apply this patches
2. Verify the original test plan works
=> SUCCESS: It does!
3. Sign off :-D

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 14:11:06 -03:00
Tomas Cohen Arazi 8726036990
Bug 17170: (QA follow-up) DB changes
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-21 11:15:21 -03:00
Tomas Cohen Arazi d138d573d7
Bug 17170: Minor fixes
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-21 11:15:21 -03:00
Nick Clemens b306b1d4ca
Bug 17170: Update schema for boolean
Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/]

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-21 11:15:14 -03:00
Tomas Cohen Arazi 9f1e167f6f
Bug 17170: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-21 11:15:13 -03:00
Tomas Cohen Arazi 6417a1f259
Bug 31626: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-18 09:50:41 -03:00
Tomas Cohen Arazi a0a821be8a
Bug 31569: (QA follow-up) Add missing entries in schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-17 18:00:41 -03:00
Tomas Cohen Arazi 09a3d968ae
Bug 31569: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-17 08:18:44 -03:00
Tomas Cohen Arazi 89d1149b21
Bug 10950: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-03 15:04:06 -03:00
Tomas Cohen Arazi 96a07e84c4
Bug 30944: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-03 13:48:42 -03:00
Tomas Cohen Arazi a5104a8562
Bug 30571: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-03 08:30:37 -03:00
Tomas Cohen Arazi 652ddd364d
Bug 7021: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-09-22 09:41:31 -03:00
Tomas Cohen Arazi c171a5d45e
Bug 30490: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-09-22 08:31:54 -03:00
Julian Maurice 63f88a5742
Bug 31254: Add additional fields for accountlines
Test plan:
1. Go to Admin » Additional fields
   There are two new categories: "Account lines (credit)" and
   "Account lines (debit)"
2. Create fields for both categories, with and without an authorized
   value category
3. Go to a user's accounting page
4. Create a manual invoice. Verify that all "debit" fields are there,
   put a value in them and save
5. Create a manual credit. Verify that all "credit" fields are there,
   put a value in them and save
6. Make a payment. Verify that all "credit" fields are there, put a
   value in them and save
7. Go to the transactions tab, click on the "Details" button for the
   lines you just created and verify that the additional fields are
   there

Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-09-21 18:58:28 -03:00
Tomas Cohen Arazi 6744a143b8
Bug 30472: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-09-19 15:12:28 -03:00
Tomas Cohen Arazi f9690267bd
Bug 15348: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-09-16 10:56:40 -03:00
Tomas Cohen Arazi 504c4f717b
Bug 29144: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-09-16 10:10:49 -03:00
Tomas Cohen Arazi 2245c5fddf
Bug 30483: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-09-12 08:35:37 -03:00
Tomas Cohen Arazi 8eccff5b53
Bug 31374: DBIC schema
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-09-07 13:40:39 -07:00
Lucas Gass 264a6e5979
Bug 31374: (follow-up) change private note to staff_note and reorder columns
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-09-07 13:32:51 -07:00
Lucas Gass 901fdd8891
Bug 31374: Database/Schema update
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-09-07 13:32:30 -07:00
Martin Renvoize 6ce4d25bd3
Bug 23681: Move to ::Patron::Restriction::Type(s)
This patch moves the new classes under ::Patron::Restriction:: and
enhances the Unit tests for those classes.

NOTE: We should drop keyed_on_code as part of bug 31095
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-08-25 08:50:35 -03:00
Tomas Cohen Arazi cdb0a7160f
Bug 23681: (QA follow-up) New schema files
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-08-25 08:50:33 -03:00
Martin Renvoize 2218b4469b
Bug 23681: (follow-up) Mark fields at booleans
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-08-25 08:41:06 -03:00
Emmi Takkinen 7cc2560d2f
Bug 23681: DBIC Schema
To be able to delete and pass tests we need to declare
koha_object[s]_class to DebarmentType.pm. Otherwise
following error is raised:

"Can't locate object method "_new_from_dbic" via package
"Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?)
at /kohadevbox/koha/Koha/Object.pm line 237"

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-08-25 08:41:05 -03:00
Tomas Cohen Arazi 136fae5091
Bug 31017: DBIC update
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-08-19 16:22:13 -03:00
Tomas Cohen Arazi ba404f2ba9
Bug 30392: DBIC update
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-08-01 14:34:11 -03:00
Tomas Cohen Arazi 83b7f1a74d
Bug 30984: DBIC update
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-08-01 10:00:54 -03:00
Jonathan Druart 6a3262de99
Bug 30612: Rename other occurrences
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-08-01 09:59:05 -03:00
Kyle M Hall 396402aa68
Bug 30612: Update schema files
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-08-01 09:59:05 -03:00
Jonathan Druart bba4bc93eb
Bug 30650: Add missing koha_object[s]_class methods
To fix TestBuilder.t
        #   at t/db_dependent/TestBuilder.t line 453.
        #          got: 'Can't locate Koha/CurbsidePickupPolicys.pm

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-08-01 09:01:25 -03:00