Commit Graph

2585 Commits

Author SHA1 Message Date
Henri-Damien LAURENT 198bae17b1 remove use of 2xx$3 in Building hierarchy 2009-10-17 00:47:47 +02:00
Henri-Damien LAURENT ac4c96f10f followup : auto_truncation 3287252c0
truncated words bore a double * which would create an error
2009-10-14 18:34:46 +02:00
Henri-Damien LAURENT 498821eaee Remove Stopwords bug fixing
in french, les is a stopword

Modèles would match because of the combining and \P{IsAlnum} would not detect that.
2009-10-09 13:31:24 +02:00
Nahuel ANGELINETTI 057fa1ac24 [followup] (bug #3348) last fixes
This patch is the last fix for this ticket.
2009-10-08 17:09:48 +02:00
Nahuel ANGELINETTI 429e5d401f (bug #3348) Budget and funds broken
This patch, fix the way to detect closed baskets or not. The way to calculate budget and funds and the spent detail.
2009-10-08 17:09:34 +02:00
Nahuel ANGELINETTI 65938adb1f (bug #3348) still fixing funds and budget table
This fix the sql request to be the same result as in spent.pl
2009-10-08 17:09:31 +02:00
Nahuel ANGELINETTI d259ef9073 (bug #3348) fix funds and budget table
This fix how the funds and budget table is calculated. Some old values are included when they shouldn't.
Then it disallow the user to receive non-closed baskets.
And fix a the spent/commited budget page, to show (and calculate) only closed baskets.
2009-10-08 17:09:30 +02:00
Henri-Damien LAURENT a55b6ca9d8 [follow up](bug #3584) improve ccl detection
Adding = as an index sign
Followup to 3037ff9e81
2009-10-08 16:08:19 +02:00
Henri-Damien LAURENT ba72e844b5 BugFixing : 3306
Using CalcDateDue With borrower information wherever possible
2009-10-07 16:13:53 +02:00
Henri-Damien LAURENT e9d4ec72d3 Bug Fix : 3689
Disabling Query_AutoTruncate for NoZebra searches
2009-10-07 16:13:53 +02:00
Henri-Damien LAURENT 50a71214d0 Adding systempreference itemcallnumber support
In PrepareItemrecordInput preference system for itemcallnumber was not correctly set.
This is a quick fix for that
2009-10-07 10:14:25 +02:00
Henri-Damien LAURENT 9d2e7a24a4 TransformHTMLToXML bug default_ind_to_space
default_ind_to_space made the assumption that indicator string by default was a string containing 2 characters.
This was not true, causing an Internal server error.
This patch Fixes that.
2009-10-06 17:53:17 +02:00
Henri-Damien LAURENT 6863ca9e92 Adding defaultvalues management in Serials Items management
Previously, defaultvalues from items was not managed
2009-10-06 17:53:16 +02:00
Henri-Damien LAURENT 697f775c08 routing preveiw was broken
using use C4::Members
2009-10-06 13:21:11 +02:00
Henri-Damien LAURENT 032ac3fa54 Improving Research on Bookseller
Can search now on any word
2009-10-06 13:21:10 +02:00
Nahuel ANGELINETTI 0e17926b61 [replaceprevious](bug #3678) Fix circulation
This patch fix major circulation problems with reserves:
A reserved document on "next available", is no more detected when an item of this record is checked-in.
And add a db dependant test to validate this everywhen.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-10-01 10:34:00 +02:00
Nahuel ANGELINETTI ce353e7230 (bug #3674) allow users creation with disabled password 2009-10-01 10:28:40 +02:00
Henri-Damien LAURENT 4a9cb3646a bug Fixing : 3640
This patch filters all non itemrelated fields in the marcrecord before making update

AddItemhad the same problem as ModItem
They would try and take fields which would not be item fields

Conflicts solved C4/Items.pm
2009-09-25 17:30:54 +02:00
Nahuel ANGELINETTI fe2eb7c9fd (bug #3667) fix borrowers cleanup
This add a check of borrower expiry date, and don't delete the borrower if he's still active.
2009-09-25 17:30:54 +02:00
Henri-Damien LAURENT 3287252c0f C4/Search.pm followup auto_truncation
Auto_truncation is used even though exact search selected.
This patch removes this side effect
2009-09-21 23:09:43 +02:00
Henri-Damien LAURENT 185ff3d26a (bug #3592) fix scan of terms
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-21 22:39:49 +02:00
Nahuel ANGELINETTI a2743f4cf0 [followup](bug #3584) fix variable name 2009-09-21 22:36:50 +02:00
Nahuel ANGELINETTI 3037ff9e81 [follow up](bug #3584) improve ccl detection
This improve the detection of ccl queries, and do not duplicate the "ccl=" value.
2009-09-21 22:36:34 +02:00
Nahuel ANGELINETTI cdd3748717 (bug #3584) detect ccl queries
This patch C4::Search::buildQuery to detect ccl queries, and let zebra to parse them.
And set a default index "kw" if not specified.
2009-09-21 22:36:08 +02:00
Henri-Damien LAURENT 6cea265950 AuthoritiesMarc.pm Improvements
Users are now able to list authorities without entering a search term
2009-09-21 22:26:03 +02:00
Henri-Damien LAURENT c5dd5717ec Followup C4::Circulation.pm previous commit
previous commit would generate warnings on compilation
2009-09-21 17:23:38 +02:00
Henri-Damien LAURENT d705a0394f BugFix 2726 Resending
This bugfix was first sent By Michael Hafen but may not have made its way into LDAP Authentication
2009-09-21 17:13:01 +02:00
Henri-Damien LAURENT 4111998c76 Bug fix : click on confirm Bellow on opac-shelves
Click on confirm Bellow was not showing the button up, or button was not really obvious
This adds a button right bellow the message
2009-09-21 16:31:09 +02:00
Henri-Damien LAURENT fed8703359 Wrong update in UpdateHoldingBranch 2009-09-21 15:08:20 +02:00
Henri-Damien LAURENT c3aed6b007 Fixing AddReturn Bad Merge 2009-09-21 14:57:36 +02:00
Galen Charlton af42c93b91 bug 3614 followup
* renamed default_ind_to_space to _default_ind_to_space
  as it is an internal function
* added calls to _default_ind_to_space in other places

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-19 23:47:10 +02:00
Colin Campbell fb3a18f949 bug 3614 Fix incorrect setting of indicator
Pull the code into its own subr so that the dangers of
inaccurate copy & paste are avoided in future

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-19 23:47:10 +02:00
Michael Hafen dbc0161cdc Avoid potentially unnecessary database call in Auth
Auth, after verifying the session/logging in the user, calls to the database
to get the users borrowernumber.  This call is probably unnecessary because
borrowernumber is part of userenv.  Check userenv before going to the database.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-19 23:47:09 +02:00
J. David Bavousett 4328b87841 Handle null-or-empty to Charset::StripNonXmlChars
When rebuild_zebra.pl is run from cron, there is an occasional error
of the form:

Use of uninitialized value $str in substitution (s///) at /home/ebpl/kohaclone/C4/Charset.pm line 304.

This error is occuring when the string that is fed to Charset::StripNonXmlChars
is null or undefined, for some reason.

This fix will handle the null-or-empty condition, and thus suppress the error.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-19 23:47:08 +02:00
Nahuel ANGELINETTI 74b44e4c3a don't die if a bad date is specified 2009-09-19 23:47:07 +02:00
Nahuel ANGELINETTI d20072c7c3 [followup](bug #3370) export function and fix return
this add GetRecordValue in exported functions, and made it to return a ref.
2009-09-19 23:47:06 +02:00
Nahuel ANGELINETTI e63849d137 [followup](bug #3370) fix the "Get" function name
This fix the problem with the Get function in C4::Biblio, the new name is GetRecordValue and located in export_ok.
2009-09-19 23:16:57 +02:00
Nahuel ANGELINETTI b21a5bdadc (bug #3370) add keyword to MARC field mapping
This add the support of keyword => MARC field mapping, ton abstract the relation between human readable fields like subtitle, title, authors, location, ... and MARC fields in each framework.
This will allow to koha developper to be more flexible with each framework and don't care about the MARC flavour, just require some "keywords" to the user.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-19 22:31:34 +02:00
Nahuel ANGELINETTI 2152d95b3c (bug #3550) use GetRecordValue to retrieve subtitle
This patch, is the first use of GetRecordValue, that use the Field mapping.
It retrieve the subtitle in Intranet using it, instead of the use an old function that doesn't work anymore.
This is a way to made koha more generic with each framework.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-19 22:24:41 +02:00
Henri-Damien LAURENT af40164951 followup Amazon.pm bugfix fd4ed72988 2009-09-17 14:52:00 +02:00
Henri-Damien LAURENT fd4ed72988 Bug Fixing Amazon.pm would not compile
missing call of C4::External::Amazon in opac-ISBDdetail.pl
@aws was not defined
2009-09-16 23:22:00 +02:00
Sébastien Hinderer 8702212d16 Get rid of a few warnings in the bulkmarcimport script: C4/Biblio.pm, hunks #1, #2: a warning occurring in NoZebra configurations. C4/Biblio.pm hunk #3: warning occurring in Unimarc MARC flavour. misc/migration_tools/bulkmarcimport.pl hunk #1: warning occurring when no default format is specified on command-line with -m switch.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:47 +02:00
Henri-Damien LAURENT 51adec717f Squashing Merge Fix and followup: renamed _GetCirculationBranch
Merge Fix Followup to 7e2bf9e
2009-09-16 23:19:46 +02:00
Galen Charlton 414f8f91b4 bug 3204: tweaks to AWS request signing
* Add AWSPrivateKey system preference to the
  Enhanced Content tab in the syspref editor
* Now warns to log if attempting to use
  the Amazon API without setting AWSPrivateKey

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-16 23:19:46 +02:00
Galen Charlton 1d6bc692a6 bug 3204: followup to fix AWS request signing
[1] There were some ersataz spaces in the string
    being signed.
[2] AWS expects a trailing '=' in the Base64 signature

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-16 23:19:46 +02:00
Henri-Damien LAURENT 719280216f bug 3204: implement request signing for Amazon Web Services
After 2009-08-15, Amazon Web Services will expect that
all requests to the Product Advertising API, which is what
Koha uses for retrieving reviews and other enhanced content
from Amazon, include signatures.  This patch and
subsequenct patches implement this functionality.

What this means in practice (assuming the user has elected
to use any enhanced content from Amazon) is that

[1] The user must get a Amazon Secret Access Key.  This can
    be done by logging in to the user's AWS account
    at (e.g.) http://aws.amazon.com/, going to the 'Access Identifiers'
    page, and from there retrieving and/or creating a new Secret
    Access Key.

[2] The contents of the Secret Access Key should then be
    entered into the new AWSPrivateKey system preference.

Once that is done, grabbing reviews and table of contents from Amazon
should work as normal.  If the user doesn't do this before 2009-08-15,
reviews and TOCs will no longer be supplied from Amazon, although there
should be no crashes - the content will simply not show up.

Note that the requirement to sign requests does *NOT* appear to apply
to simply displaying book covers from Amazon.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:46 +02:00
Henri-Damien LAURENT ae24ed1109 [replaceprevious](bug #3562) fix returning document in another branch
there is no transfert alert if you make a return in another branch than the homebranch.
2009-09-16 23:19:45 +02:00
Henri-Damien LAURENT 3e11b4a0b4 Bug Fixing 3542 : searching for authority in cataloguing
There was a problem in the query building
and PERL is quite picky with empty data in arrays so setting empty elements to undef

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2009-09-16 23:19:44 +02:00
Chris Cormack 7bbe9d0ae2 Fixing syntax error in C4/Circulation.pm 2009-09-16 23:19:44 +02:00
Joe Atzberger ea510b04bb Cleanup docs, typos, style etc.
Unused variable removed.  Weirdness with empty position in
assignment list also removed.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2009-09-16 23:19:44 +02:00