On bug 37895 we have failed to propose a solution to encapsulate exceptions and rethrow them.
Until this is ready we should not try/catch and so use say_failure from our DB revs.
We want to stop the DB update process when something is wrong. In those
try/catch we are actually continuing even if something bad happens.
As RaiseError is set on the dbh, say_failure statements will never be
reached.
Test plan:
checkout origin/24.05.0
reset_all
checkout main + this patch
updatedatabase
Everything should run fine.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This has no effect as it is not causing problems. But.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
% perl -wc installer/data/mysql/atomicupdate/skeleton.pl
Useless use of anonymous hash ({}) in void context at installer/data/mysql/atomicupdate/skeleton.pl
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Jonathan Druart
Tomas Cohen Arazi
Martin Renvoize
Marcel de Rooy