Commit Graph

2886 Commits

Author SHA1 Message Date
Chris Nighswonger 7b1a3d1ae8 Bugfix: Fixing issues with the patron card pdf rendering code
This patch fixes two bugs:

1. Correcting the text alignment alogrithms for center and right alignment

2. Changes a reference to layout to a copy of the layout to avoid performing
operations on the layout.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 11:25:49 -05:00
Colin Campbell 745ac87c20 Bug 4133 Ensure that orders have a valid quantity received
quantityreceived drives other parts of acq noticeably budget balances
ensure that a number (usually 0) is set in NewOrder
give field a valid default and set as not null
reinterpret exsting nulls in table as zero

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 11:21:48 -05:00
Colin Campbell 55e9ac2ad3 Bug 3697 Return due date (SIP Field AH) in item info
Although the due date of an on loan item was being retrieved
the appropriate field in the Item object was not set
causing the due date not to be returned in the item
information response

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 10:13:43 -05:00
Frédéric Demians ff4d456072 Bug 3920 - Add 2 syspref to activate XSLT use in OPAC/Intranet
- Add two syspref:
  - OPACXSLTResultsDisplay
  - OPACXSLDetailsDispay
- Add them to .pref files and dispatch them beetween OPAC and Search
  tab.
- Upgrade DB version to 3.2 .113
- Fix something wrong in UNIMARCslim2intranetDetail.xsl
- Display OPAC result and detail pages using those syspref.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 08:08:44 -05:00
Chris Cormack a319a402f7 Removing noisy warn in C4/XSLT.pm
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:39:50 -05:00
Colin Campbell c3d1b33a2a Remove cause of some warnings in order display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:39:46 -05:00
Galen Charlton 740814d951 corrected POD for GetMember()
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 08:24:11 -05:00
Galen Charlton 513c76121c fixed remaining calls to GetMember() that used old argument style
New way, correct way to use GetMember is

GetMember(field => fieldvalue[, field2 => field2value ...]);

e.g.,

GetMember(borrowernumber => $borrowernumber);

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 08:24:05 -05:00
Colin Campbell e321fc9184 Bug 4108 Catch cases when GetMember is generating errors
Fixed two calls where new interface was not used
Arguably new syntax allows more options than we require but it was not catching
error cases (when 0 or undef is passed). It also can now be called in ways
which would validly return multiple hits but explicitly does not
(nor does calling code expect this)
This patch should quieten the flood of errors

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 07:57:26 -05:00
Chris Nighswonger 431d917609 Bugfix: Implimentation of JpegBlob and AltJpeg methods
Implimentation of JpegBlob and AltJpeg methods in C4::Creators::PDF

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-04 17:32:54 -05:00
Chris Nighswonger d8d9e7fdb8 Bugfix: Correcting hash dereferencing for barcode data
This patch corrects hash dereferencing syntax.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-04 17:32:48 -05:00
Chris Nighswonger f728c59451 Bugfix: Correcting hash dereferencing for image data
This patch corrects hash dereferencing syntax.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-04 10:28:43 -05:00
Galen Charlton afed49ccc8 fix POD errors reported by xt/author/podcorrectness.t
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-03 15:57:31 -05:00
Colin Campbell ae830774db Fix pod markup errors in C4/Budgets.pm
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-03 15:12:26 -05:00
Galen Charlton 8b4501f7c7 Revert "Populated MARC 952$2 field for serials-edit.pl"
This reverts commit 708b4797e3.

Had introduced following error:

Global symbol "$value" requires explicit package name at C4/Biblio.pm line 2381.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-02 19:26:33 -05:00
Kyle M Hall 844f63f1f8 Rotating Collections Fixes
This patch does the following:
  * Fixes the typos in updatedatabase.pl ( updates colBranchcode to varchar(10)
  * Adds the rotating_collections template files that somehow were not committed
  * Adds a missing sub from RotatingCollections.pm that must been deleted by accident
  * Adds the neccessary hooks in returns.pl to warn that and item needs to be returned
    to the branch that currently holds the collection.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-02 19:22:05 -05:00
Chris Nighswonger 4e65ac5965 Bugfix: Stop C4::Koha from filling the log with pesky warns
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-02 19:16:06 -05:00
Chris Nighswonger eb6b10f8c9 4074 Bugfix: The 'Subject(s)' link(s) are malformed resulting in no search results
This bug was introduced by commit d51332698b
which removed the inability to do a search on anything contianing a colon (:).

This patch expands the regexp to only normalize true limit operators and leave
all other colons (:) intact.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-02 18:48:42 -05:00
Colin Campbell 77b7924a42 Bug 4083 subroutine HasItems needs to be exported
Calls to the unexported subroutine result in system error

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-02 18:46:05 -05:00
Colin Campbell 52c3a85320 Bug 4088 Due Date Not formated in checkout response
due date was not being formatted as a timestamp
but being passed as epoch seconds

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-02 18:46:01 -05:00
David Birmingham 708b4797e3 Populated MARC 952$2 field for serials-edit.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-02 18:37:54 -05:00
Owen Leonard 1f54d10475 Fix for Bug 4073, Add globally template variable for dateformat setting
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-02 18:37:37 -05:00
Frédéric Demians b713484682 Bug 3815: SIP2 Invalid Item Information Response 18
With this patch Koha SIP2 server send back a valid Item Information
Response for issued items: ie with due date in the response.
2010-01-28 15:14:52 +01:00
Frédéric Demians fca7926374 Bug 3814: SIP2 Server logging doesn't work on OpenSolaris
This patch put in SIPconfig.xml SIP2 server logging parameters. This is
way it's possible to modify where SIP2 logs are sent. And fix
OpenSolaris bug.

WARNING: After an upgrade, installation using a custom SIP2 server
config file will need to copy default SIPconfig.xml added section:

<!--
  Set Net::Server::PreFork runtime parameters
  syslog_ident will identify SIP2 Koha server entries in syslog
  For OpenSolaris, add: syslog_logsock=stream
-->
  <server-params
    min_servers='1'
    min_spare_servers='0'
    log_file='Sys::Syslog'
    syslog_ident='koha_sip'
    syslog_facility='local6'
  />
2010-01-28 15:14:52 +01:00
Frédéric Demians 9d1a31c7f6 Bug 3813: SIP2, Bad Patron Information Response to Message 64
This fix returns item's barcodes in AU fields
2010-01-28 15:14:52 +01:00
Paul Poulain d17a72ed5b (MT 2671): Serial management in koha_add_biblio
serial management in koha_add_biblio is only relying on presence of
$biblio->{seriestitle} It is not correct, $biblio->{serial} definition
should prevail over this test
2010-01-28 15:11:56 +01:00
Paul Poulain bc5aa652a6 BuildSummary AuthoritiesMarc Enhancement
Change in BuildSummary for UNIMARC
2010-01-28 15:11:56 +01:00
Henri-Damien LAURENT 7540dda2eb Bug Fixing Search By initials incorrect
Adding a research scope : field_start_with
Using this kind of research if searching by initial
2010-01-28 15:11:55 +01:00
Nahuel ANGELINETTI dc9991d9b4 (MT823) add the possibility to have enrolment end date
this patch add the possibility to have an end date of enrolment, instead of a period. Like for a user category, all this category can have the same expiry date.
The librarian can configure one of both, but not both.
2010-01-28 15:11:55 +01:00
Matthias Meusburger b40d4052b9 MT2116 : Addons to the CSV Export
Add encoding selection
Add authorised values handling
2010-01-28 15:11:55 +01:00
Matthias Meusburger a404384b11 MT2116: Addons to the CSV export
Add user-defined headers
Add CSV, field and subfield separator selection
2010-01-28 15:11:54 +01:00
Henri-Damien LAURENT 2086615a35 SQLHelper : InsertInTable enhancement
InsertInTable can now add values to table where primaryKey requires
user input such as branches table
2010-01-28 15:11:54 +01:00
Henri-Damien LAURENT b5800a41b7 followup (bug #4020) XSLT unimarc display
C4::Search removing unconditionnal warning
2010-01-28 15:11:53 +01:00
Jean-André Santoni c6027e73c5 Fixed a major bug in ModReceiveOrder
Orders were not splited correctly.
2010-01-28 15:11:53 +01:00
Jean-André Santoni 022978d4f4 [MT2593] Added "ordered" column in acqui-home budget display 2010-01-28 15:11:52 +01:00
Nahuel ANGELINETTI 800494a5ef (bug #4004) disallow access for non-logged in users in opac
This doesn't define borrowernumber = 0 if a borrower is NOT logged.
We know borrowernumber 0 is mysqluser... So in virtualshelves, a non logged user have all permissions.
2010-01-28 15:11:52 +01:00
Nahuel ANGELINETTI da2ba2759c [followup](bug #3667) don't delete if member is guarantor
this fix cleanborrowers to don't delete guanrantors.
2010-01-28 15:11:52 +01:00
Nahuel ANGELINETTI 7855f1d8bd [followup](bug #3667) fix dateexpiry filtering
this fix the dateexpiry used to filter users, now we use date specified.
2010-01-28 15:11:52 +01:00
Nahuel ANGELINETTI c2e245e2da [followup](bug #3667) cleaning borrowers fix
This fix GetBorrowersWhoHaveNotBorrowedSince to select only borrowers that have no issues and have no old_issues more recent than a specified date.
2010-01-28 15:11:52 +01:00
Paul Poulain 9d1e7f43e1 (bug #4020) XSLT unimarc display
When using XSLT Display, and UNIMARC,
since marcFlavour is not used in encoding data, when data is true utf8, as_xml
fails on some subfields.

Moreover, because transformMARCXMLForXSLT edits some values in the marc record
and the PERL UTF8 is not handled by MARC::File::USMARC, it endsup in double
encoding the data.
Sending a patch to fix both issues.

This patch adds
    - two functions in  C4/Charset.pm
        NormalizeString (uses Unicode::Normalize)
        SetUTF8Flag (This function in my opinion belongs to MARC::Record, or at least MARC::File::USMARC)
    - edits C4::XSLT in order to cope with the correct marcflavour
    - edits C4::Search searchResults to use setUTF8Flag
2010-01-28 15:11:51 +01:00
Henri-Damien LAURENT a97d12faa7 C4::SQLHelper Changing $$ notation to $ -> 2010-01-28 15:11:51 +01:00
Henri-Damien LAURENT 3b43a79c43 Suggestions.pm :Changing $$ notation to $ -> 2010-01-28 15:11:51 +01:00
Henri-Damien LAURENT 6a3579b2f3 MT 2285 : enhancement for patronSearch 2010-01-28 15:11:51 +01:00
Paul Poulain 01ba63a84f #4003 default value in PrepareItemrecordDisplay
The default value you can define in cataloguing framework was not used for item created from acq or serial recieve
2010-01-28 15:11:50 +01:00
Henri-Damien LAURENT f64de645da Bug :authid empty in Authorities Default summary 2010-01-28 15:11:50 +01:00
Nahuel ANGELINETTI e75d26e794 (bug #3667) fix borrowers cleanup
This add a check of borrower expiry date, and don't delete the borrower if he's still active.
2010-01-28 15:11:49 +01:00
Matthias Meusburger 5f61beed72 MT2408 : UI Changes / CSV Export 2010-01-28 15:11:48 +01:00
Henri-Damien LAURENT 23a1397419 Dates : improvements string recognition
Dates can now have one digit for month and day
2010-01-28 15:11:47 +01:00
Matthias Meusburger 6281ed6b91 MT 1801 : Opac shelves and basket are displayed the same way
This patch also fixes broken location display in both shelves and basket.
2010-01-28 15:11:47 +01:00
Henri-Damien LAURENT f0aee34d3f followup : auto_truncation 3287252c0
truncated words bore a double * which would create an error

Conflicts solved :
	C4/Search.pm
2010-01-28 15:11:46 +01:00