Commit Graph

16750 Commits

Author SHA1 Message Date
Mason James 990e315471 The current searching in labels is a bit minimal, and current only does keyword searching.
there is some old 2.2 code for more complete labels-searching, thats been commented out

ive logged a 'bug' for this - 2777

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2777

this fix...
  - enables the index-searching functionality
  - adds date-ranges
  - uses the numSearchResults syspref, not a hardcoded '20'
  - rewrote old 2.2 page-num code, (didnt work for 3.x)
  - some indent and whitepages tidys.
  - unused 2.2 search-code removed.

Mason

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 11:15:44 -06:00
Nahuel ANGELINETTI 31c6cd032b (bug #2881) preselect default sorting
This patch just set a variable with the name of default sorting, and value 1

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 11:10:31 -06:00
Owen Leonard 96d0ea56df Formatting changes for OPAC xslt and staff client catalog detail pages. Fixes Bug 2704, 440 Display Issues.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:44:02 -06:00
Nahuel ANGELINETTI 92afb0dd56 (bug #2887) Change the "Cart" box from js to tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:33:59 -06:00
Galen Charlton 4dc238f599 remove disused script admin/letter.pl
Was moved to tools/letter.pl in 2006, but old
(and nonfunctional) version was left in place.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:28:33 -06:00
Galen Charlton 7db6178391 removing *.old files
Don't need to do this when modifying a script --
this is what Git is for.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:24:16 -06:00
Joshua Ferraro acd431f55d Adds the ability to reference itemcallnumber within XSLT
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:19:55 -06:00
Galen Charlton 538ce7b2e3 followup to prior patch: remove $toggle from script
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 10:10:34 -06:00
Joe Atzberger 5af1eb2061 Remove "toggle" from template, use loop_context_vars __odd__ instead.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 09:53:26 -06:00
Frederic Demians a777fb43d7 Fixes bug #2875
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 09:47:57 -06:00
Joe Atzberger 26d08662e7 Minor updates to minor cronjob script.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 09:47:54 -06:00
Galen Charlton c7dec5b3df crontab.example - add back some useful comments
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 09:45:00 -06:00
Joe Atzberger 07245470f0 Expand crontab.example
Default overdues to "triggered" mode (-t).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 09:30:05 -06:00
Joe Atzberger 5102da0abc Revert "Updates to the example crontab"
This reverts commit def09f5a21.

As I emailed to the patches list Oct 06, 2008:

I suggest we need to revert Josh' commit def09f5a21.

The effect on the crontab example is to invalidate the lines being executed.  The lines were apparently copied in from a cron source, not crontab, despite the header describing it NOT being an example for cron.  It also runs longoverdue twice, instead of fines.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 09:30:03 -06:00
Frederic Demians 62f3f59d8c Fixes bugs #2875-2879
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 19:59:44 -06:00
Stan Brinkerhoff d0deac6e12 Add 'use warnings' and correct uninitialized value warnings.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 19:52:45 -06:00
Stan Brinkerhoff 7989a831db Removing ':' from table headers.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 19:52:44 -06:00
Stan Brinkerhoff 06c9408ba6 Added 'dbd::sqlite' as appears as an optional module during latest installers.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 19:48:52 -06:00
Galen Charlton a84935b83e bug 2505: further warnings fixes to memberentry.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 19:43:15 -06:00
stan 8042c6ec19 Added 'warnings' support, fixed bug 2870.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 19:20:51 -06:00
Galen Charlton 7b690aee84 bug 2856 followup - display form correctly when modifying patron
Upon further testing, original patch for 2856 had effect
of displaying form with blank values when modifying
an existing patron record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 19:20:16 -06:00
Galen Charlton 53d4e8fa2c bug 2856 followup: remove unconditional warn
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 13:55:22 -06:00
Nahuel ANGELINETTI 61ebf9160f (bug #2856) Activate the duplicate patrons detection and check birthdate only if one is set
This patch activate the check of unique member, it was checked but not shown, and the member was added even if a duplicate was
detected.
It improve the duplicate detection, to check the birthdate only if it was specified in the form.
And fix an url of "Yes" link(if the borrower added IS the duplicate detected).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 13:46:11 -06:00
Allen Reinmeyer 3fca370fba Test suite: C4::Members::GetMemberDetails
Tests for C4::Members::GetMemberDetails.  Validates both calls
using either borrowernumber or cardnumber.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 13:01:06 -06:00
Allen Reinmeyer bcf4246dae Test suite: C4::Members::GetMember
Tests the functionality of C4::Members::GetMember.  Tests exist
for every way that GetMember could be called on to search for an
existing member.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-29 13:01:05 -06:00
John Beppu c15e1206fd bug 2874 [3/3] flagsrequired => { circulate => "circulate_remaining_permissions" }
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-23 17:02:04 -06:00
John Beppu 7b683cf583 bug 2874 [2/3]: added awareness of circulate/override_renewals subpermission
A few minor whitespace cleanups were thrown in as well.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-23 17:02:00 -06:00
John Beppu fe5cc9933f bug 2874 [1/3]: schema changes for overriding blocked renewals
Two new subpermissions of circulate were added:
- circulate_remaining_permissions
- override_renewals

Also, the following schema alterations were made
- permissions.code      : varchar(30) => varchar(64)
- user_permissions.code : varchar(30) => varchar(64)

  (The reason for this was because "circulate_remaining_permissions"
   was greater than 30 characters long and wouldn't fit.)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-23 17:01:58 -06:00
Owen Leonard 7a9658cddc Improvements to offline circ report (linking to title and patron records), and moving English strings from the script into the template to allow translation.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-22 17:24:34 -06:00
Frederic Demians 6345ddf493 A script generating keyword clouds from Zebra Indexes
See embedded perldoc to see how it works.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-22 16:41:53 -06:00
Andrew Moore 69a2b414ae test suite: C4::ImportBatch
Here are some tests for functions in C4::ImportBatch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-22 11:43:07 -06:00
Andrew Moore 1fc155e4b3 Bug 2868: fixing typo in NoZebraIndexes setting in sysprefs
There was a missing ' in the value of the NoZebraIndexes syspref. This
patch fixes it.

It's not necessary to fix the existing settings because
C4::Biblio::GetNoZebraIndexes is liberal enough to be able to parse even
the deformed value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 15:26:38 -06:00
Galen Charlton 0339498196 bug 2799: DB rev 008 for library transfer limits
Also fix automatic merge that put the 008
update in the wrong place.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:49:33 -06:00
Galen Charlton a3136e22bf bug 2799: followup 2
* fix TMPL_IF embedded in HTML tag
* convert a remaining <TMPL_VAR> to a comment

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:49:26 -06:00
Galen Charlton 0f47a7db16 bug 2799: followup
Various fixes to meet coding standards, template
design, and basic functionality:

* (bug 2505) turned on warnings
* use correct loop names when populating
  $template
* put all TMPL_FOO in HTML comments
* assign UseBranchTransferLimits to circulation tab
* change template to use "library" instead of "branch"
* use standard YUI scripting for toolbar buttons
* add new script to admin menu

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:49:16 -06:00
Andrew Moore 3886be26ff Bug 2799: database update to "branch transfer limits"
This patch cleans up kohastructure.sql a bit:
 * moved the table definition to above the ending comments
 * added a "drop table..." statement

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:49:07 -06:00
Kyle Hall 9cf0472903 Added 'Branch Transfer Limits' Feature requested by Geauga County Library System.
Added syspref to updatedatabase.

Updated kohastructure.sql with the limits table.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:49:02 -06:00
Galen Charlton 2cc76d6672 whitespace cleanup - admin/systempreferences.pl
applied xt/perltidyrc to admin/systempreferences.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:48:46 -06:00
Galen Charlton 77e545b0da bug 2860: allow setting of a syspref value to '0'
Fixed invalid test for the existence of CGI parameter; if it
is possible that the value of a parameter can be 0, it is
not sufficient to test like this:

if ($input->param('foo')) { ...

since the test will fail for *any* value that evaluates
to Perl false.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:48:21 -06:00
Galen Charlton 9ae359d89a bug 2505: turn on warnings in admin/systemprefernces.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:48:04 -06:00
Jesse Weaver 775fb409ef bug 2867 [2/2]: db changes for single-screen syspref editing
Database revision 007.

[Includes a correction by Galen Charlton]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:47:26 -06:00
Jesse Weaver 06d2a720ae bug 2867 [1/2]: Move basic editing to main system preferences screen
This allows the user to edit system preferences from the main system
preferences screen, rather than having to dig down into each
preference.

[This patch includes some modifications by Galen Charlton
 to fix XHTML validation errors and a couple errors that
 would crop up under warnings.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:47:00 -06:00
Andrew Moore db8cfa37e3 bug 2824: improving error messages from test suite errors
This patch adds two warning messages to places in the test suite that
may fail. I don't think it changes any functionality, but it sure makes
it easier to figure out what has gone wrong.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 09:12:17 -06:00
Marc Chantreux 01cb36effe fixed "too many opened files" error during translation
The problem was that the TmplTokenizer create global symbols to store file
handlers so the objects aren't destroyed by the garbage collector.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 09:00:09 -06:00
Galen Charlton f74d63a1e5 bug 2864 [2/2]: move rss/* to misc/cronjobs/rss/*
As rss.pl is not a CGI script, moved it to join the
other cronjobs.  Full documentation of the script
is in misc/cronjobs/rss/rss.pl, but to summarize:

[1] rss.pl is run on the command line to produce
    an RSS XML document.  The output should be
    placed in a directory accessible to the OPAC
    (or staff) web interface so that users can download
    the RSS feed.  An example of usage:

    misc/cronjobs/rss.pl lastAcquired.conf

    Normally rss.pl should be run periodically (e.g., daily)
    to keep the feed up-to-date.

[2] The configuration file (e.g., lastAcquired.conf) lists

    * name of the template file to use
    * path of output file
    * SQL query

    rss.pl runs the SQL query, then feeds the output of the
    query through the template to produce the output file.

[3] The template file (e.g., lastAcquired.tmpl) uses
    HTML::Template syntax like any of the HTML
    templates for the web interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 08:02:34 -06:00
Galen Charlton f1b4d629b3 bug 2864 [1/2]: restore rss/rss.pl
Restored basic functionality of rss/rss.pl:

[1] Reverted "Add support for itemtypes. Still need to hardcode 'reservable'"
    Revert commit e7575b00ed, which had
    replace the script with one of its templates.

[2] Minor fixes to update it, including using HTML::Template::Pro instead
    of HTML::Template, perltidy, and turning on warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 08:02:27 -06:00
Galen Charlton d368894545 bug 2859: add index on bibioitems.issn (DB rev 006)
Because of a query on biblioitems.issn in
C4::Breeding::ImportBreeding(), libraries doing a lot
of bib imports were experiencing performance problems,
which adding an index will alleviate.

A possible longer term solution is to index all
reservoir/import batch records in a Zebra database.

[LL bug 232]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-12 10:13:05 -06:00
Galen Charlton ae24c2d16c minor fixes to UNIMARC_sync_date_created_with_marc_biblio.pl
- chmod 0755
- add newline in error message shown if attempting to
  run in MARC21 database

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 10:36:57 -06:00
Henri-Damien LAURENT 431a8d1b20 Update MARC to add 099$c and 099$d fields, with :
This allow the acquisition date sorting in UNIMARC.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 10:33:56 -06:00
Frederic Demians 1774780623 Add default classification sources and filing rules to fr-FR
fr-FR install wasn't populating classication rules tables:

  * class_sort_rules
  * class_sources

This patch add default values for those tables
mandatory during installation process.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 10:19:30 -06:00