Commit Graph

382 Commits

Author SHA1 Message Date
Joe Atzberger 37c25f55b2 Restrict OPAC tags display to approved=>1.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:47 -05:00
Galen Charlton fe202cdc94 kohabug 2078 - settle on application/xml Content-type for feeds
Required by IE6 to at least get a feed to display as XML
in the browser instead of being downloaded.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:55 -05:00
Galen Charlton 8fc6b927df kohabug 2078 - send correct Content-type for search feeds
OPAC search RSS and ATOM feeds now have the correct
Content-type sent - "application/rss+xml" and "application/atom+xml",
respectively.

As part of this patch, added an optional fourth parameter
to C4::Output::output_html_with_http_headers to specify
the content type.  If that parameter is now supplied, or if
the value of the parameter does not contain at least a "/",
the default type of "text/html" is returned.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:54 -05:00
Galen Charlton d177975239 kohabug 2078 - fix feed validation errors
Fix several validation errors in RSS and Atom feeds
generated from the OPAC:

- add missing guid to RSS elements
- add missing feed ID and element ID to Atom elements
- reflect OPACBaseURL changes
- fix atom:link self links
- add HTML escaping to fields comming from bib record
- set default timestamp for Atom updated elements

Issues identified but not solved in this patch:

- setting Atom updated element for each bib (presumably
  from biblio.timestamp)
- possible problems performing paging of Atom feed

Based on successful validation of feeds by feedvalidatory.org,
it is expected that feeds should now work in IE7 and IE6.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:51:10 -05:00
Galen Charlton 5e5ce6b7f9 calculate OPACBaseURL instead of using syspref
Calculate OPACBaseURL from the
CGI environment variables instead of using the
system preference.  As a result of this patch,
it should be possible to change the hostname,
protocol, or port of the OPAC without having to
reset a system preference.

Also added a FIXME to opac/unapi - the URL of
the SRU/W server has no necessary relationship
to the URL of the OPAC.

Once this patch is confirmed, the syspref can
be removed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:51:08 -05:00
Joe Atzberger b7baaaa3ab Bugfix 1979 - display hold numbers. Note that hold priorities are still buggy.
But that is a separate bug from whether they display or not.
Also added basic error handling if biblionumber is not received, or
if biblionumber is bad, since that otherwise crashes the page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:50 -05:00
Joshua Ferraro 60368d1049 From HDL:
I agree that opac-suggestions.tmpl modification is Not required any longer.
But still, the modification in opac-suggestions.pl is really necessary.
If you donot do that, ppl are presented with ALL suggestions and not
their suggestions by default, which is not what My Suggestions suggests.
2008-05-30 13:56:17 -05:00
Paul POULAIN 67ffed7fec Respect BiblioDefaultView when search returns only 1 result & jump directly to the detail
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 11:57:34 -05:00
Joe Atzberger 70829660c2 Bugfix 2026 - Comments handling overhauled. Scrubber and Error feedback added.
Note: we CANNOT rely on window.close in onSubmit or $().submit to close our popups.
On a relatively slow connection with a relatively large POST, commonly the close finishes
*before* the POST completes, as reported with our New Zealand clients.  Despite success in
trivial cases, this should be obvious, since the event is necessarily before the submission.
It also assumes success and prevents any kind of error feedback.  Other popups are likely
to exhibit this same defective behavior.

Some FIXME's outstanding: need to allow users to delete their own comments,
need to enforce and feedback on max comment length.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:51:58 -05:00
Michael Hafen e08e6a01c3 fixed session cookie name in opac-logout.pl
Session Cookie name is CGISESSID in Auth.pm

Signed-off-by: Michael Hafen <mdhafen@washk12.org>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:32:52 -05:00
Joe Atzberger 7ca4d31e82 Tags AJAX and JSON for OPAC side.
Note, all Tags js will live under KOHA.Tags namespace.
See opac-tags.pl perldoc for AJAX/JSON examples.  The capability is already
there to be very web-servicey, even moreso than the current OPAC implementation
will utilize.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:25:17 -05:00
Joe Atzberger 0626e743ec Add error feedback and Scrubber to OPAC tags page. Beginnings of ajax code.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:47 -05:00
Galen Charlton 0f8910e0f6 correct path to 404.pl in opac-details.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 16:07:10 -05:00
Joe Atzberger b11c41249b Bugfix ShelfBrowser using unsanitized ISBNs. Owen reported the
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-16 08:10:56 -05:00
Galen Charlton c1ae207d54 kohabug 1621 - add subtitle to main results and details pages
Including the subtitle in search results and OPAC and staff
details templates.  The subtitle is expected to be in the
MARC subfield that is mapped to the (now nonexistant) column
bibliosubtitle.subtitle.

This is a fairly hackish patch that is meant to be minimally
disruptive while allowing subtitles to be displayed for those
not using the experimental XSLT bib display feature.  It
does *not* cover all cases where you have a MARC
record and want to display its subtitle.

UNIMARC notes: at the moment, none of the fr-FR UNIMARC
frameworks appear to be map any subfields to bibliosubtitle.subtitle.
This could be changed, but caveat programmer: the UNIMARC 200$e
is repeatable (meaning that get_koha_field_from_marc will put in ' | '
between multiple subtitles) and one may want to also include the
200$d (parallel title).  A GetMarcSubtitle routine may be in order
if absolutely necessary.

This points to a long-term need to make display of MARC (and later, hopefully,
non-MARC) bib records more flexible - the XSLT feature is one approach;
there may be others.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-13 17:40:34 -05:00
Paul POULAIN dfcdc73be6 bugfix : ship utf-8 encoding in mail header
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:07:55 -05:00
Owen Leonard 157b5a1eb6 Adding checks for dateformat preference so that tablesorter script can be passed an extra parameter for proper sorting of metric dates (Bug 2089, dates & table ordering with jquery)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:06:32 -05:00
Galen Charlton 8138b6dcac patron attributes - OPAC display
If ExtendedPatronAttributes is ON, any patron attributes
whose type is marked as displayble in the OPAC are now
displayed in the 'my details' page in the OPAC (assuming
that the patron is logged in).  These appear in the
'Library Use' section.

Currently, it is not possible for a patron to suggest
changes to any of their extended attributes using
opac-userupdate.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:03:07 -05:00
Owen Leonard fc03a2510c Finishing adding additional markup for increased flexibility in stylesheet customization. Patch also includes some markup corrections, but shouldn't result in any visual changes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:50:23 -05:00
Joshua Ferraro 09df0de35f Removing obsolete RSS <link> tags and the scripts 2008-05-06 06:24:50 -05:00
Paul POULAIN 4ea4f841ee Adding subfield filter to ISBD
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:45 -05:00
Owen Leonard 85777e4ea1 Adding more details to cart's verbose view. Adding auto-print to cart print view (Addresses Bug 2070)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-01 18:59:19 -05:00
Joshua Ferraro f093a84974 Fixing bug 1629: RSS Feeds of Search Results in OPAC 2008-05-01 18:55:13 -05:00
Andrew Moore 57b3b951c1 Bug 2047: adding images to arbitrary authorized values
I've refactored the subs I added in the previous commit so that they make a little
more sense and are in better places in the code base. I was really hoping to make use
of existing subs, but they all seemed so specific to particular uses.

The icons now show up on the OPAC item details page.

TODO: The icons still don't show up in the OPAC search results page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 20:10:43 -05:00
Joshua Ferraro dfe310868f Adding TagsEnabled to list of known sysprefs, adding 'my tabs'
to the OPAC user portal
2008-04-22 21:00:56 -05:00
Joe Atzberger c0cfbef28b Hack RSS to work. Just a temporary fix before XSL takes over.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 18:06:57 -05:00
Joe Atzberger 5a68c16194 Bugfix #1624 - remove problem w/ EXPR in template, minor cleanup of module.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 18:06:38 -05:00
Joe Atzberger a98c622ab8 Remove extraneous code. Note: this is another example of unchecked input, yet unfixed.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 18:06:35 -05:00
Joe Atzberger fa7ffc8b33 opac-search - CORRECTION: remove diagnostic Dumper lines
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 18:02:51 -05:00
Joe Atzberger 524a5cbb21 Tags - module, script and template support for user tagging in OPAC.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 18:02:44 -05:00
Joe Atzberger 31da55ea2d Baker and Taylor OPAC integration, plus some logic for Tags
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 18:02:36 -05:00
Joe Atzberger 9e81acaa08 opac-tags_subject.pl - touch up: this script is does not require Exporter.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 18:02:30 -05:00
Joe Atzberger 015e5da39f Tagging - add basic template slot in search for tags and script responsiveness to tagging sysprefs
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 18:02:27 -05:00
Joe Atzberger a33e025a61 Fix obvious error in 500.pl script. Please push up immediately.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 08:11:29 -05:00
Chris Nighswonger 9b47b82a77 Porting SimpleSearch return changes to all code calling it.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-17 05:52:45 -05:00
Frederic Demians 7c284da9bd Displays Languages selector on opac-main.pl page
On bottom of each OPAC pages, a languages selector is displayed
(depending of syspref). But this selector wasn't available
on OPAC home page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-12 15:05:12 -05:00
Ryan Higgins 9ff307e881 remove hardcoded ccode & loc authorized values from opac-detail.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 15:54:16 -05:00
Paul POULAIN 854c6f8005 Reintroducing history dates for serial-issue (see previous commit for staff // feature)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:52:54 -05:00
Joe Atzberger c13c16bf99 Allow param "bornum" as in template, not just "borrowernumber". Added FIXMEs.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-08 19:49:06 -05:00
Joshua Ferraro 4d3519dffd Partial fixes to enable unapi for non-zebra and non-public-facing sru
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-08 19:48:55 -05:00
Owen Leonard f9de575250 Adding COinS support to cart pop-up; Hide similar items in opac-details if no similar items are found.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-08 08:37:11 -05:00
Joshua Ferraro faa9a39694 adding famfamfam iconset, improving isbn for amazon content, etc.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-07 21:20:22 -05:00
Ryan Higgins 875fafc5e0 Show enumchron, copynumber in opac detail iff present.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-07 15:59:53 -05:00
Owen Leonard b329ce233b Changes to allow librarian to turn off item-level holds in the OPAC. Requires the addition of OPACItemHolds system pref ("Allow OPAC users to place hold on specific items. If OFF, users can only request next available copy." Type: YesNo). Also modifying redirect to show Holds tab in opac-user.pl.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:44:33 -05:00
Owen Leonard ed35df0eb4 Adding a couple of missing YUI js files; Adding comment preview to comments system (needs review).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:45:50 -05:00
Owen Leonard 68a7738026 Improving comments style and markup, adding highlighting for comments made by logged-in user.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:45:48 -05:00
Andrew Moore 5c51edc653 bug 1890: fixing calls to C4::Search::SimpleSearch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:23 -05:00
Ryan Higgins 76fb49ba37 Send borrower mods to branchemail instead of syspref.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-25 07:20:27 -05:00
Joshua Ferraro 556721e86a Experimental XSLT-based display of results and details pages To enable, create two new YesNo sysprefs: XSLTDetailsDisplay and XSLTResultsDisplay, and set them to ON. Feature to be expanded in a future version, this experimental code is for proof of concept only and doesn't introduce any changes if sysprefs are not created.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:49:04 -05:00
Owen Leonard 0f1825d055 Changes to allow highlighting of current tab on user pages.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:17 -05:00