Commit Graph

34374 Commits

Author SHA1 Message Date
Chris Nighswonger a035678a17 Some coding improvement and misc changes to BIBBAR labels
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:44:38 -05:00
Owen Leonard e88cf181c0 Some markup corrections, breadcrumb improvement, and other minor changes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:44:36 -05:00
Owen Leonard 293d4c20be Correcting table-sorter js for different table structures (Amazon content on or off, item-level-itemtypes on or off)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:44:35 -05:00
Owen Leonard b329ce233b Changes to allow librarian to turn off item-level holds in the OPAC. Requires the addition of OPACItemHolds system pref ("Allow OPAC users to place hold on specific items. If OFF, users can only request next available copy." Type: YesNo). Also modifying redirect to show Holds tab in opac-user.pl.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:44:33 -05:00
MJ Ray 697088968a Add backtrace printing option through SetEnv KOHA_BACKTRACES 1
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:44:31 -05:00
Galen Charlton 20241fd686 more XHTML corrections for new circ reports
Note: I question the use of GROUP_CONCAT(... SEPARATOR '<br/>'),
because that puts knowledge of the output mechanism (currently HTML)
into the SQL query.  However, I am not fixing this right now.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:21 -05:00
Galen Charlton f3258cc311 SQL cleanup in new circ scripts: use placeholders
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:20 -05:00
Galen Charlton ef8a880b25 use C4::Debug instead of checking DEBUG env var directly
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:19 -05:00
Galen Charlton 4a35e3c21f fixed typo in template
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:18 -05:00
Galen Charlton 1a5013441b XHTML fixes for various circ templates
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:17 -05:00
Galen Charlton da5c6a1b3e change references to 'reserves' in billing report template
New billing report has nothing to do with hold requests per se,
so change template variables in order to not confuse customizers.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:15 -05:00
Galen Charlton a2c59f25e2 various date-related cleanups in circ
* use Date::Calc to perform date arithmetic
* use Date::Calc::Today to consistently format the current date
* format date per syspref in overdue report

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:14 -05:00
Galen Charlton b558a13323 disallow division by zero in hold ratio report
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:13 -05:00
Galen Charlton e5d8bf5788 another "Reserves" => "Hold" in template
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:12 -05:00
Galen Charlton 093056b5da minor circ template cleanup
[1] did some "Reserve" => "Hold" to keep language consistent
[2] Moved hold ratios report and billing report on circ
    home page to group with related reports

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:10 -05:00
Darrell Ulm 8cafcef8bf All patches to Koha 3 beta to date. All work with branches.
Billing.pl     -- new, gives bills that occur in a range, works
 pendingreserves.pl  -- fixed, works now, with branches also
 reserveratios.pl  -- indicates distressed reserves
 itemslost.pl  -- Fix to this to make it more useful and fix bugs
 Itmes.pm -- small change to work for itemslost, should not affect
             anything else
 and all tmpl files.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:07 -05:00
Chris Nighswonger e5a6500c7c Adding PATCRD print type
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:41:52 -05:00
Galen Charlton 4c596e4e97 fixed locating OPAC stylesheet in a "standard" install
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:46:09 -05:00
Galen Charlton 6c2c1dad30 fixed MODS biblio export on a "standard" install
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:46:08 -05:00
Galen Charlton a6c85e6002 bug 1986: fix card view in Z39.50 search results
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:46:07 -05:00
Galen Charlton e2c1f11715 fixed memory leak I introduced
Accidentally introducing a circular reference in a
MARC::Record object does not lead to goodness, particularly
if you export lots and lots of them.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:46:05 -05:00
Galen Charlton cfea172544 work around issue in MARC::Charset
Because of a bug in MARC::Charset 0.98, if a string to convert from
MARC-8 to UTF-8 has (a) one or more diacritics that (b) are only in character positions
128 to 255 inclusive, the resulting converted string is not in
UTF-8, but the legacy 8-bit encoding (e.g., ISO-8859-1).  As a result,
when such a record is converted to XML using ->as_xml_record(), the resulting
XML can be truncated at the offending character.  An example of such a record
is one that has a price in Briish pounds in the 260$c but no other diacritics.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:46:04 -05:00
Owen Leonard ed35df0eb4 Adding a couple of missing YUI js files; Adding comment preview to comments system (needs review).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:45:50 -05:00
Owen Leonard 68a7738026 Improving comments style and markup, adding highlighting for comments made by logged-in user.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:45:48 -05:00
Chris Nighswonger b179819d08 Correcting a small case-sensitive bug.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:45:47 -05:00
Galen Charlton 1acc90eb84 for DebugLevel=2; improved reporting of version numbers
Koha software and DB version numbers now reported;
also improved formatting of multi-line error messages.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:27 -05:00
Galen Charlton cfc0e33829 improved formatting of fatal error messages sent to browser
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:25 -05:00
Galen Charlton 7ef6669a7e fixed invocation of CGI::Carp::set_message
The message handler in C4::Context is now correctly
passed CGI::Carp.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:24 -05:00
Andrew Moore 5c51edc653 bug 1890: fixing calls to C4::Search::SimpleSearch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:23 -05:00
Andrew Moore 883e3767fc Bug 1980: adding parameters to C4::Search::SimpleSearch to allow limiting the number of results returned.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:19 -05:00
Chris Nighswonger b626a8bb9a Adding file size limit to picture-upload.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:17 -05:00
Chris Nighswonger b5ce8cae5e Fixes to make all label/patron card templates uniform
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:13 -05:00
Chris Nighswonger 88c9c3fbeb Adding sample label form for Patron Cards
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:12 -05:00
Galen Charlton 1d0b5a092d Catalogue => Search in staff home page
Changed to match similar change in the menu
bar.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:10 -05:00
Galen Charlton 6a0a4e3900 avoid croak on latest CVS version of MARC::Record
The semantics of MARC::Record->delete_field() changed
slightly in the latest CVS version of MARC::Record.
delete_field() will now croak if passed an undef
scalar, while the version of MARC::Record from CPAN
accepts that input.  Since some packages of MARC::Record
in the wild appear to be based on the CVS version, not
the CPAN version, added a check where needed to avoid
the croak.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:07 -05:00
Chris Nighswonger dd80cb4f2a More work on patron card generation feature
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:42:38 -05:00
Chris Nighswonger 028f4f24fb Adding member search to patron card generation feature
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:42:37 -05:00
Chris Nighswonger 4cfbf45e35 Work on adding patron search to patron card generation feature.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:42:33 -05:00
Owen Leonard 766639aa0a Tweaking the interface of OPAC shelves to more closely match the pattern set by the staff client. Simplifies and focuses on specific tasks.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:41:13 -05:00
Owen Leonard 4322942efd Notifying the user when they have selected no items and clicked 'Add to list.'
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:41:13 -05:00
Owen Leonard 8fb4f21fae Visual tweaks for login screen.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:41:12 -05:00
Owen Leonard c51316a594 Correction to prevent js error when table has no data.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:41:11 -05:00
Ryan Higgins 7fe042a008 Change LateOrders to inclusive <=, s/supplier/vendor , s/parcel/shipment.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:37:00 -05:00
Galen Charlton 4f001186b6 still more rebuild_zebra refactoring
Merged duplicate code for indexing bibs and
authorities into a single index_records() function.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-25 07:58:03 -05:00
Galen Charlton a5576b8dfe IMPORTANT: added -z option to rebuild_zebra.pl
The -z option, when used in conjunction with -a and/or -b,
selects the records to reindex from the zebraqueue table.
Both record updates and record deletes are handled.

-z is cannot be used with -s or -r: the updated records
must always be freshly exported, and if zebraqueue
is to be processed, it's assumed that you don't want
to drop the Zebra index first.

This means that rebuild_zebra.pl -b -a -x can be
used as a cronjob to update the indexes periodically; it
is believed that this will offer much better indexing
performance on some setups as compared to zebraqueue_daemon.pl,
which uses Z39.50 extended services to send record updates
to Zebra.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-25 07:58:01 -05:00
Galen Charlton 57d128f727 rebuild_zebra: exit if both -a and -x specified
At moment using both -a (index authorities) and
-x (export records as MARC XML) is not allowed -
if the Zebra authority database is using the DOM
filter, zebraidx will not be able to process the
exported records correctly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-25 07:57:44 -05:00
Galen Charlton f0d5da7448 more rebuild_zebra.pl refactoring
1. Logic to fix up record IDs, UNIMARC 100 field,
   and record leader now in separate functions.
2. Removed (incorrect) logic to save corrected record
   in database.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-25 07:57:43 -05:00
Galen Charlton f98c27a8bc refactor rebuild_zebra: new routine for invoking zebraidx
Created a routine for calling zebraidx, replacing
separate invocations for bibs and authorities.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-25 07:57:42 -05:00
Galen Charlton ae8a76dacc rebuild_zebra.pl: removed disused $limit option
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-25 07:57:41 -05:00
Owen Leonard 52c7a4f697 Markup corrections. Tweaking holds interface.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-25 07:22:40 -05:00