Commit Graph

399 Commits

Author SHA1 Message Date
Joe Atzberger 75c0bef66f Remove bad use of map in void context, exclusively for side effects!
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:43:20 -05:00
Ryan Higgins fc98d228c2 Sort dropdowns for libraries by name instead of branchcode in several staff-side interfaces.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:33 -05:00
paul 7be6d1f12b IMPROVEMENT : serialsadditems at subscription level (bump 071)
The patch update the DB by adding a row in the subscription table (serialsadditems), that is filled with the value of the syspref.
then, the syspref is deleted.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 17:34:33 -05:00
Chris Nighswonger 9b47b82a77 Porting SimpleSearch return changes to all code calling it.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-17 05:52:45 -05:00
Paul POULAIN e30d1d6844 bugfix : independantbranches behaviour
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:55:50 -05:00
Paul POULAIN f5674f953a reintroducing the limit on itemtype when searching a biblio in subscription add
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:52:56 -05:00
Paul POULAIN fa4cead909 reintroducing history manual modification feature
The history start date and enddate is also useful to modify manually for the same reason : your serial collection may be older than your Koha serial management.

This commit reintroduce the feature.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:52:52 -05:00
Galen Charlton 9222f7a6ca created old_issues and old_reserves tables
The new tables have the same structure and constraints
as the tables they archive with the following exceptions:

* borrowernumber and biblionumber in old_reserves can be
  NULL
* the FK constraints (e.g., for itemnumber) on old_reserves
  set the child column to NULL if the parent row is deleted
  instead of deleting the child row.
* there is no FK constraint on old_issues.branchcode, allowing
  a branch to be deleted without changing archived requests.

Some miscellaneous cleanup was done as part of this patch:

* GetMemberIssuesAndFines (C4::Members) now uses bind variables
* fixed POD for GetMemberIssuesAndFines

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:36:31 -05:00
Ryan Higgins dd3c971aaa Date format fix for serials irregularities.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-18 19:30:42 -06:00
Ryan Higgins fd65fcc365 fix record->field call on autobarcode
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-10 15:36:18 -06:00
Ryan Higgins f98e567b57 Populate serialitems table, bugfix
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-10 13:45:19 -06:00
Ryan Higgins d7821250aa Some templating for serials.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 11:11:46 -06:00
Ryan Higgins 3de59aba27 Serials updates to link item record to serial table.
This commit makes db changes to subscription, serials tables:
  allow subscriptions larger than 127 issues
  link serial to item uniquely.
MARC Framework:
  Adding MARC tag 942$s (990$s unimarc) to map biblio.serial
Udate biblio.serial on new-subscription.
Use biblio.serial to check if Items.pm should return
  pubdate and enumeration text string from serials table with items.
Update opac-detail so serial items are sorted most recent first.
Adding link from items table to serial table.

Allows sorting of serials in details pages, and removes
enum data from itemnotes field.
Also fixes  visibility in serials item editor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 11:11:45 -06:00
Ryan Higgins ccadef4372 set of serials fixes to subscriptions
fix zeroes in enddate field and backwards public v nonpublic notes
do not allow modification of free-text subscription history
changing terms from supplier to vendor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 11:11:42 -06:00
Mason James ee5c60cc2d BUG 1580, subscription irregularities and volume type, not passed when editing subscription
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-04 08:06:08 -06:00
Galen Charlton 0c087b87ef replaced incorrect '=>' with '='
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 20:22:19 -06:00
Galen Charlton 8e41022b0d item rework: moved various accessor functions
Moved following functions from C4::Biblio to
C4::Items:

    GetItemStatus
    GetItemLocation
    GetLostItems
    GetItemsForInventory
    GetItemsCount
    GetItemInfosOf
    GetItemsByBiblioitemnumber
    GetItemsInfo
    get_itemnumbers_of

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:25:05 -06:00
Galen Charlton c6c8e80a73 start of BIB change -- introduce C4::Items
Introduced C4::Items module to separate items API
from biblio API.  Details on changes will be
put in later commit messages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:23:12 -06:00
Mason James 2b16d7a083 padding Add_Delta_Days date, again.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 00:32:51 -06:00
Mason James 0e0586c264 BUGFIX padding add_delta_days() date
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 00:32:50 -06:00
Paul POULAIN 6a924eb363 reintroducing lateissues-excel
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 09:09:37 -06:00
Joshua Ferraro a602c6d6eb cleanup for serials and members for Dates 2007-12-04 19:03:35 -06:00
Joe Atzberger a5746c616a serials subdir - Dates.pm integration and warnings fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 18:21:07 -06:00
Henri-Damien LAURENT eec6b41c3f numberingpattern was disimissed when editing a subscription
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-20 16:09:50 -06:00
Mason James a62811200a bug 1566, enddate not showing.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 12:46:48 -06:00
Mason James b3d218b41c bug fixed 'weeklength', not showing in subscription edit screen
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 12:46:47 -06:00
Henri-Damien LAURENT 855d9697de Bug Fixing : itemization would create undesirable items
One item was created for "unexpected" issues if the first issue was received.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-08 17:10:49 -06:00
Henri-Damien LAURENT 6e6f93c933 Bug fixing : irregularities were not saved. Nor were innerloops.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-07 08:21:21 -06:00
Henri-Damien LAURENT 4399daf0bd Managing Independant branches.
librarian can edit only subscriptions on branches of his or subscription with no branch now.
cannotedit is a calculated value in Mysql and transfered for process.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:27:25 -06:00
Henri-Damien LAURENT 59d80a8ce0 Removing Date::Manip
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-04 16:26:48 -06:00
Mason James 58dfd9c18e fix for 1521, boolean test for 'autobarcode' syspref fixed, and test for non-existant $marc->field before barcode subfield add
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 05:58:14 -05:00
Mason James fda72bf787 if() incorrectly eval-ing syspref value 'FALSE' as true, wrapping in boolean.
if (C4::Boolean::true_p(C4::Context->preference("autoBarcode")) != 0 )

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:06:09 -05:00
Paul POULAIN 8b7085a8ab removing useless code
the 3 parameters :
intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"),
intranetstylesheet => C4::Context->preference("intranetstylesheet"),
IntranetNav => C4::Context->preference("IntranetNav"),

are filled by Auth.pm automatically, removing them in templates

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-24 17:03:38 -05:00
Chris Cormack 606ecb532a Patch from Joe Atzberger to remove $Id$ and $Log$ from scripts
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:27:04 -05:00
paul a5bd240321 FIX for Date calculation
Rule :
- always format_date() before sending date to template
- always format_date_in_iso immediatly after reading a date coming from a parameter
- deal internally only with dates in iso

Note that :
- I could not test things related to issues stats due to the my DB -issues.issuedate not filled, see commit about 3.00.00.006
- acquisitions_stats does not work when you filter on date

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 11:51:12 -05:00
Paul POULAIN c6b086c165 1409 empty search term in subscription search biblio
+ removing some useless code

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 19:54:31 -05:00
Paul POULAIN 2fb2db5691 fix for #1430 (subscription add fails)
due to us date format not properly set

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-02 15:45:54 -05:00
Paul POULAIN 09d6d9f583 bug IPT176 :Once more.
Conflicts:

	koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tmpl

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-24 15:29:21 -05:00
Owen Leonard 7c3d2fa61b - Lots of markup corrections, in scripts and templates, for XHTML compliance
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-13 17:18:56 -05:00
Henri-Damien LAURENT 054d2b0d19 Deleting Date::Manip
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-20 15:16:22 -05:00
Paul POULAIN 2716acbb11 loading template 1st to have userenv set + fixing javasccript bug + reindenting
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-18 17:38:28 -05:00
Paul POULAIN 20f2e15e24 ordering supplier list & reindenting a little
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-18 17:37:56 -05:00
Joshua Ferraro cefeb583ad fixing permissions on scripts
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-08-13 12:22:30 -05:00
Joshua Ferraro e9ae8c0686 patches from paul 2007-08-08 07:41:19 -05:00
Chris Cormack 2e4a11773c Merge branch 'master' of /home/jmf/repos/koha-rm-root.git/ 2007-08-08 07:36:43 -05:00
Paul POULAIN 3519c9540a removing statecollection, replaced by serials-collection
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-08 07:25:11 -05:00
Paul POULAIN 8c78ff5aa5 subscription copy is now a parameter of subscription-add.pl Removing the old script
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-08 07:25:11 -05:00
kados 40af15d8e6 changing permissions on templates and scripts 2007-08-07 13:20:51 -05:00
jmf@arwen.metavore.com c0d85e87b4 From 0751ba130288bc69e9e563473e7fc25551edc40e Mon Sep 17 00:00:00 2001
From: kados <jmf@arwen.metavore.com>
Date: Sat, 4 Aug 2007 20:10:51 -0500
Subject: [PATCH] fixing permissions on all scripts

Signed-off-by: Chris Cormack <crc@arwen.metavore.com>
2007-08-04 22:41:41 -05:00
hdl e3791f5966 Bug Fixing
Getting back to serials-collection when edit finished.
subscription-renew is done in a popup.
2007-07-16 15:49:14 +00:00
hdl 866708d29a serials-edit.pl
Changing redirection to serials-home.pl
serials-home.pl
	Adding some parameters to serials-home script to display information passed by serials-edit.pl
	Preparing information for display.
(template to get committed)
2007-06-30 06:23:10 +00:00
hdl d71a9d3d5b Bug Fixing.
subscription-renew lead to internal server error.
2007-06-27 14:55:46 +00:00
tipaul 577a7bf094 some (minor, functionnaly speaking) bugfixes 2007-06-05 08:54:17 +00:00
toins acf832a8f2 re-indenting + redirecting to subscription-detail.pl after a renewal. 2007-06-05 08:46:18 +00:00
hdl 1a1045844e Bug Fix :
If cannot GetExpirationDate (because frequency is unknown...) Then take todays'date as startdate for the renewal.
2007-05-29 16:54:50 +00:00
tipaul 5ff7fcffa4 Bugfixes & improvements (various and minor) :
- updating templates to have tmpl_process3.pl running without any errors
- adding a drupal-like css for prog templates (with 3 small images)
- fixing some bugs in circulation & other scripts
- updating french translation
- fixing some typos in templates
2007-05-22 09:13:54 +00:00
hdl b05cb8df7b Adding redirection to serials-collection.pl if no serials selected for edition. 2007-05-18 12:00:17 +00:00
hdl 827ed50aee Adding bibliotitle information to display 2007-05-18 09:25:06 +00:00
hdl 097fef712a Removing $dbh from GetMarcFromKohaField (dbh is not used in this function.) 2007-04-27 14:00:48 +00:00
hdl fb1e47e435 Deleting GetMembersFromSurname
Using SearchMember instead.
2007-04-25 13:38:00 +00:00
tipaul fb143b71ba BIG COMMIT : cleaning of Reserves.pm. See detail on koha-devel 2007-04-24 16:10:36 +00:00
hdl b642e687d2 Still Code Cleaning.
Abiding by Name Convention.
Using Members wherever it should be used.
Borrower is only used for borrower Categories.
+ GetBorrowersWhoHaveNeverBorrowed
and lists like that.
2007-04-24 15:41:27 +00:00
hdl 100e6a9808 functions that were in C4::Interface::CGI::Output are now in C4::Output.
So this implies quite a change for files.
Sorry about conflicts which will be caused.
directory Interface::CGI should now be dropped.
I noticed that many scripts (reports ones, but also some circ/stats.pl or opac-topissues) still use Date::Manip.
2007-04-24 13:54:28 +00:00
tipaul 3ddec89262 moving Reserves2.pm to Reserves.pm 2007-04-23 14:08:47 +00:00
hdl 0b66bd800d Code Cleaning Members.
- checkaccount and getborraccountno => GetBorrowerAcctRecord

Many changes in names,
some changes in function signature.
Will be detailed in a mail to kohadevel.
2007-04-23 13:10:07 +00:00
tipaul 7bd99ef365 removing all useless %env / $env 2007-04-18 17:00:14 +00:00
tipaul b71839d85c circulation cleaning continued: bufixing 2007-04-17 08:44:49 +00:00
tipaul c596d55374 HUGE COMMIT : code cleaning circulation.
some stuff to do, i'll write a mail on koha-devel NOW !
2007-04-04 16:46:22 +00:00
tipaul a481fad4b7 Code cleaning :
== Biblio.pm cleaning (useless) ==
* some sub declaration dropped
* removed modbiblio sub
* removed moditem sub
* removed newitems. It was used only in finishrecieve. Replaced by a Koha2Marc+AddItem, that is better.
* removed MARCkoha2marcItem
* removed MARCdelsubfield declaration
* removed MARCkoha2marcBiblio

== Biblio.pm cleaning (naming conventions) ==
* MARCgettagslib renamed to GetMarcStructure
* MARCgetitems renamed to GetMarcItem
* MARCfind_frameworkcode renamed to GetFrameworkCode
* MARCmarc2koha renamed to TransformMarcToKoha
* MARChtml2marc renamed to TransformHtmlToMarc
* MARChtml2xml renamed to TranformeHtmlToXml
* zebraop renamed to ModZebra

== MARC=OFF ==
* removing MARC=OFF related scripts (in cataloguing directory)
* removed checkitems (function related to MARC=off feature, that is completly broken in head. If someone want to reintroduce it, hard work coming...)
* removed getitemsbybiblioitem (used only by MARC=OFF scripts, that is removed as well)
2007-03-29 13:30:31 +00:00
tipaul f8e9fb6445 rel_3_0 moved to HEAD (introducing new files) 2007-03-09 15:34:17 +00:00
tipaul 86e9db4e67 rel_3_0 moved to HEAD (removing useless file) 2007-03-09 15:22:00 +00:00
tipaul fc1342f73d rel_3_0 moved to HEAD 2007-03-09 15:12:54 +00:00
bob_lyon a86a347557 Updating claims - commenting out the bits of code that were not implemented in the end
- was planning on having ability to choose style of claim letter but wasn't taken up in the end
2006-12-13 20:07:22 +00:00
tgarip1957 da68b830cb Savannah seems out of synch.Code cleaning removal of Date::Manip 2006-11-15 01:38:26 +00:00
tgarip1957 21a0532176 Add the faceted search facility 2006-09-28 14:12:01 +00:00
tgarip1957 5b41a8e262 New XML API 2006-09-11 17:41:54 +00:00
tgarip1957 7e52a5665c Clean up before final commits 2006-09-06 16:21:03 +00:00
tipaul b1f388bbee fixing some bugs in subscription add.
However, alt_subscription-add.pl seems so nice that I think it could be the official subscription-add... will drop a mail on koha-devel about this
2006-08-11 16:33:53 +00:00
toins 32a0d6bc13 Add Call to Bookfund.pm 2006-07-27 14:00:19 +00:00
toins 6808155c44 Add Call to Bookseller.pm & 1 sub renamed. 2006-07-27 13:58:33 +00:00
toins b48c9ff9ec Add call to Bookfund.pm 2006-07-27 13:57:57 +00:00
toins 7f9e6c1553 some subs have returned values changed. 2006-07-21 09:37:36 +00:00
toins 49ea64a1f0 subs renamed & POD added 2006-07-21 09:36:42 +00:00
toins eb43f5a639 this file has been changed by serials-recieve.pl 2006-07-21 09:20:36 +00:00
toins ed1dafebbd merged with statecollection.pl 2006-07-21 09:19:38 +00:00
bob_lyon b3ed2ba79f merging katipo changes 2006-07-20 06:09:02 +00:00
bob_lyon 0ec33d50e2 altering template path 2006-07-20 04:08:47 +00:00
bob_lyon 536939c51b Merging in katipo changes for serials 2006-07-20 03:22:15 +00:00
bob_lyon f408ead60b Merging in katipo changes for serials 2006-07-20 03:14:49 +00:00
toins 92284686aa Code cleaning : Some subs renamed. 2006-07-19 08:58:38 +00:00
toins 160516e3e6 replace an array to a hash 2006-07-13 08:13:37 +00:00
toins a392b0d109 Pod added, SQL code move on Serials.pm 2006-07-12 16:47:15 +00:00
toins c0cfe25ae7 Pod added, Unused param deleted. 2006-07-12 16:45:20 +00:00
toins f0011c34d0 GPL licence added, POD added, call to Members.pm added 2006-07-12 16:43:17 +00:00
toins abf523e751 POD added. 2006-07-12 16:41:35 +00:00
toins de16696e15 this file has moved from bull to here 2006-07-12 16:40:12 +00:00
toins 31b979aa4e statecollection.pl renamed to serials-recieve.pl 2006-07-12 13:29:27 +00:00
toins 2a7f9b3cdb Sub renamed and/or GPL Licence added according to the coding guideline. 2006-07-07 09:05:23 +00:00
tipaul 247e04d204 templating serials & moving them to a serials directory, more self-explanatory (bull being french) 2006-01-19 12:46:58 +00:00