Commit Graph

377 Commits

Author SHA1 Message Date
Ian Walls cd458a2093 Bug 3319 Followup: Fix compatibility with fix for bug 4945
The fix for 3319 overwrote the @branchloop variable with output from GetBranchesLoop,
which forces a selected branch.  Removing the extra call, and just measuring the size of
@branchloop as it was build, plus some dereferencing, fixes the issue.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-03-04 19:03:32 -05:00
Chris Cormack 51199afbc1 Bug 5751 : Follow up patch, removing unused variable and fixing copyright
(cherry picked from commit f6be5ef20f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-13 21:45:55 -05:00
Paul Poulain 02154a537e Bug 5751 : MT2690 fix members-home
This fix the members-home script to work with new letter search management, and delete not anymore used code/template

(written by Nahuel Angelinetti)

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
(cherry picked from commit 3be7a6d458)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-13 21:45:41 -05:00
Owen Leonard 7f9eec6920 Fix for Bug 3319 - Need error message when adding patron and libraries are defined
- Hiding patron add toolbar when branches or categories are undefined
- Blocking patron entry form if branches or categories are undefined
- Removing nonfunctional template logic for displaying missing category
  error message.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e6a3029470)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-03 08:03:30 -05:00
Colin Campbell 619e788d4f Bug 5673: test guarantorid consistently
Incorrect checking of guarantorid was causing moremember.pl to
try and construct addresses using data from non-existent guarantors
ensure that test is consistently checking that value is defined and not
'', '0' or 0 [ i.e. what perl does for you anyway!!]

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 49b5f77194)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-03 08:02:59 -05:00
Owen Leonard 1dbe1684c6 Fix for Bug 4945 - Patron search is limited by default to the currently logged-in library
I couldn't figure out how (or whether) GetBranchesLoop could be
convinced to return a list of branches without selecting one, so
I swapped GetBranchesLoop with GetBranches. This will preselect
a branch only if a branch has been submitted as part of a query.

This does NOT preselect the correct branch when IndependantBranches
is turned on.

I also added a template variable which is true if a query has
been submitted with a branch or a category so that the extra
form fields can be displayed, reminding the user that they
added limiters to their query.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 98efac4c0a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-11 09:40:47 -05:00
Galen Charlton 11a489c800 bug 5585: fix display of current date on receipts and slips
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 80641597e5)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-06 15:49:22 -05:00
Galen Charlton 7779896064 bug 5497: make all library fields available to circ receipt/slips
This allows the receipt template to be more readily customized
to include the library's address, phone number, email address, etc.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4daef50c7a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-04 15:15:16 -05:00
Owen Leonard 1c3214b6e6 Fix for Bug 5030 - Improve handling of duplicate patrons
- Making duplicate patron warning dialog simpler but more explicit
- Pointing duplicate patron preview window to new brief version
  of moremember.pl to display more patron details than the previous
  version.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9f0495238d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2010-12-01 17:00:28 -05:00
Owen Leonard 777ab9f7d1 Fix for Bug 5029 - Update patron deletion error page
- Styling error message with "dialog alert" class
- Adding sidebar patron details to match other patron pages

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f7b3b0c75b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2010-12-01 16:57:47 -05:00
Owen Leonard 8d5394a214 Fix for Bug 5037 - If patron category is empty it shouldn't show
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bbb0819f0f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2010-11-17 08:05:24 -05:00
Andrew Elwell 78a598f509 Bug 5385: POD Cleanups (part 1)
working through the master branch to eliminate all
podchecker warnings/errors

Actual improvement to the quality of the POD will
come later (hopefully with assistance of others)

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9fa574f609)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2010-11-11 19:48:14 -05:00
Katrin Fischer e9877ebb4c Bug 5112: Organisation does not show links to professionals
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 63fdd8768a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2010-11-11 19:48:13 -05:00
Katrin Fischer 99e8b01e9a Bug 5003: Can not search for organisation by name
Rebased to current HEAD, small error fixed.
Should also apply to 3.2

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 863830f3f9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2010-11-10 17:17:42 -05:00
Colin Campbell 171802b174 Fix compile time warning in member.pl
variable to declared twice

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:58:40 -04:00
Frédéric Demians 03ff10ba02 Bug 5201 Patron surname dropped
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:18:52 -04:00
Owen Leonard f976eaa916 Follow-up fix for Bug 5013, "New patron" menu button broken
Menu was working on members-home.pl but not on members.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-19 10:35:47 -04:00
Owen Leonard 3452d0f267 Fix for Bug 5013 "New patron" menu button broken on patron select screen
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-15 22:05:19 -04:00
Henri-Damien LAURENT 5f5d093c5b (bug #4954) allow date expiry modification only on step 0 and 3
This add a verification, to allow automatic modification of expiry date, only if we are on a page that allow modification of expiry date.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-07 12:10:33 -04:00
Garry Collum d4f6974581 Bug 2725: Fixes uppercasesurnames preference.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-06 08:18:47 -04:00
Galen Charlton d3ece118f1 bug 4808: allow limited-permission circ operators to print receipts
Staff users now only need circulation privileges to print
checkout receipts and slips; the 'borrowers' permission, which
allows editing patron records, is no longer required.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-02 14:57:25 -04:00
Galen Charlton 573ac9488f remove a bunch of unconditional debug warns
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-02 10:57:08 -04:00
Galen Charlton 0700a8b732 bug 4896: granular permissions now always on (DB rev 138)
Per the following koha-devel thread, the use of
staff user subpermissions, AKA granular permissions, is
now the default behavior in Koha.  This patch removes
the GranularPermissions system preference.

[1] http://lists.koha-community.org/pipermail/koha-devel/2010-February/033670.html

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 07:56:03 -04:00
Galen Charlton 340f8f0725 bug 4508: fix crash when editing patron attributes or message prefs
When editing patron attributes or messaging preferences on the
patron editor, Koha would crash with the following error:

Software error:
Can't use an undefined value as an ARRAY reference at
/home/koha/kohaclone/C4/SQLHelper.pm line 186.

This would occur only when editing the specific attribute
or message preferences section, not when editing the entire
patron record.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-26 10:52:44 -04:00
Galen Charlton ef58c445d3 removed needless imports of the YAML module
Removed instances of 'use YAML' that were either completely
unnecessary or which were used only in debug code.  Also
removed a needless import of Data::Dumper.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 23:30:48 -04:00
Matthias Meusburger 6710641eee MT2582: Fix user deletion without permission
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 08:39:19 -04:00
Frédéric Demians 257a179c3e Bug 4470 Patron search result pagination bar
Obviously, Koha global pagination function could be improved. This patch
do something which belongs to this function. A CPAN module like
Data::Page could help or be an inspiration... 3.4?

There is also room for improvement in they way resultset are
constructed. The whole set is retrieved and just a subset is displayed.
It impacts performances for libraries with a great number of patrons.
The right solution would be:

  - to find the resultset size with SELECT COUNT(*)
  - to retrieved the exact subset with LIMIT and OFFSET SQL arguments

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 06:09:36 -04:00
Kyle M Hall 3a5b075c90 Fixed Patron Search Results
By default, the patron search was pulling results in *Descending* order,
then reordering the results on the page using javascript in *Ascending* order.

This was causing screwy results where the entire list of results of multiple
pages was not in complete alphabetical order.

Fixed by changing the SQL to pull in Ascending order.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 08:57:04 -04:00
Colin Campbell cb031bace9 Bug 2889 Remove toggle in boraccount display
Also remove the reverse column if no contents to be displayed
( otherwise looks like a markup error )
Rationalize the main loop now toggle not required

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-03 09:20:50 -04:00
Matthias Meusburger e4a6abbf1a MT3440: Display only borrower's messages in borrower's profile
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-01 09:11:44 -04:00
Kyle M Hall db8bda86ea Search Patrons - Make patron search more forgiving.
Patron search has only been searching fields for names
that either match or begin with the given search terms.

This is too strict a search.
For example, take the name "Billie Jo Robinson", "Billie Jo"
being the firstname, and "Robinson" being the last name. If one
were to search for "Billie Jo", this patron would not appear in
the search results.

 To remedy this, the search
type has been changed from 'begins_with' to 'contain'.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:45:29 -04:00
Colin Campbell e7bdbd0583 Bug 4248 Rework Cities dropdown for members entry
Garry Collum's patch correctly identified the core flaw in operation
looking closer revealed some other flaws (2 "blank" options, some vars
and documentation belonging to a superceded version, etc.
Changed GetCities to return a structure rather than the messy two returns
Let the template do the concatenation and removed the CGI::Popup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:20:36 -04:00
Henri-Damien LAURENT c1f91af476 MT3212 : members modification wipeout dateexpiry
Members modification when not in Library information mode would wipe out dateexpiry information

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:33:51 -04:00
Donovan Jones 0718cc8b6d Bug 2505 - Add commented use warnings where missing in the members/ directory 2010-04-21 20:19:50 +12:00
Galen Charlton d20305cca1 tweak display of issuing library on staff reading history
Following idea in patch submitted by Kyle Hall on 1 April 2010,
use issues.branchcode instead of issues.issuingbranch to set
displayed issuing library.  Also tweaked wording.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 10:57:47 -04:00
Paul Poulain b7ce86240e [MT3191] follow-up, removing warn
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 09:57:11 -04:00
Paul Poulain c6e04e8b40 [MT3191] various perl errors in script (merge conflict)
and SQL error solved

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 09:57:03 -04:00
Jean-André Santoni 732e1f954d [MT2195] Display issuing branch in reading record
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 09:56:54 -04:00
Nahuel ANGELINETTI c5c83ed8d7 (MT #2920) fix reading record scripts
This patch fix some perl ugly code to be more readable and lesser complex.
And it allow in intranet to order by issues.timestamp.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 09:56:33 -04:00
Jean-André Santoni 576e544d02 [MT2358] Display issue date in member reading record
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 09:56:23 -04:00
Lars Wirzenius e8df566734 Fix FSF address in directory members/
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:17:55 -04:00
Chris Nighswonger 7e3e572436 Enhancement: This patch adds a 'cardnumber' parameter and checks
to see if it is present when the script is called. If it is, the patron
information is retrieved and borrowernumber set from that. Otherwise,
the patron information is retrieved by borrowernumber.

The changes in this patch do not require porting to any other Koha code.

Sponsored by www.digital-loom.com

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-02 18:47:21 -05:00
Henri-Damien LAURENT e154413382 Revert "MT2232 : members/notices.pl and members/messaging.pl are doing the same thing"
This reverts commit 653de3c295b5b21ddfe11f0597b4ba7092f1effc.
Should remove members/notices.pl instead
2010-01-28 15:11:57 +01:00
Henri-Damien LAURENT 1e1c87a1af (followup MT2690) search on first letter
followup commit 5a669826fa8e6cfbf2c53aa40271e0a2f8465a6c
letters were not introduced in first page
2010-01-28 15:11:57 +01:00
Nahuel ANGELINETTI d639b9b79d (MT2690) fix search by letter
This patch fix searching by name that "begins" by one letter, using now the quicksearch arg.
And improve a bit the template, now it won't list all the alphabet...
2010-01-28 15:11:55 +01:00
Nahuel ANGELINETTI ed9d4873d4 Fix ordering in member search
This fix the default ordering when the librarian browser by "last name". It must be ordered by "family name".
2010-01-28 15:11:55 +01:00
Henri-Damien LAURENT 7540dda2eb Bug Fixing Search By initials incorrect
Adding a research scope : field_start_with
Using this kind of research if searching by initial
2010-01-28 15:11:55 +01:00
Henri-Damien LAURENT 6a3579b2f3 MT 2285 : enhancement for patronSearch 2010-01-28 15:11:51 +01:00
Nahuel ANGELINETTI 05b61e4f3a (bug #3745) fix deletion of borrowers rights detection
This patch fix the rights checking for borrower deletion.
2010-01-28 15:11:49 +01:00
Matthias Meusburger 20df800fae MT2232 : members/notices.pl and members/messaging.pl are doing the same thing 2010-01-28 15:11:45 +01:00