Commit Graph

3631 Commits

Author SHA1 Message Date
Owen Leonard 89d34a7c48 A better fix for Bug 2229, I think. Text inside basket.js can be translated fine, this instance simply lacked the call to the dummy function for gettext. It's important /not/ to have the "Cart" text in masthead.inc because there should be no Cart link for users with javascript turned off.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 11:41:47 -05:00
Owen Leonard d900b2a63d Adding required jquery files for update Cart notification popup.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 11:19:58 -05:00
Owen Leonard be1ab41d2f Position of cart details popup needs to be specified numerically since jquery can't seem to accurately calculate the dimensions of the cart button.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 10:58:40 -05:00
Owen Leonard 4128725f69 Continuing work on Cart popup
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 10:58:40 -05:00
Owen Leonard a0dfa0e5a6 Testing change to cart popup display system. Attempting to fix display flakiness associated with YUI method.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 10:58:39 -05:00
Owen Leonard d8c60f6bdf Fix for Bug 2240, "opac-search.pl masthead does not include 'cart' and 'list' buttons, " and other minor markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 10:36:04 -05:00
Owen Leonard 9821a11537 Fix for Bug 2097, "Extra bar after subject headings in OPAC."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 10:36:01 -05:00
Owen Leonard 374a07a5d2 Adding missing menu item for Stop Words. Fixes Bug 1995, "Link Missing from Admin Menu."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 15:53:20 -05:00
Owen Leonard 64d65d838a Restructuring guarantor display to address Bug 2220 ("Guarantor needs two fields to be labeled"). This change probably means an updated screenshot is necessary.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 15:52:52 -05:00
Owen Leonard 39576cd44c Whitespace was causing table sorting problem. Fixes Bug 2215, "In page JavaScript sort not working for title on holds tab for my summary."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 15:52:22 -05:00
Owen Leonard 37e4866b5b Correction to allow pop-up window to scroll. fixes Bug 2209, "Editing records in the inventory."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 15:51:49 -05:00
Owen Leonard ac7c215be3 Markup corrections. You can't embed a <!-- TMPL_IF --> inside an HTML tag because it causes problems for the translation script.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 14:05:53 -05:00
Owen Leonard 904a148509 Markup correction. You can't embed a <!-- TMPL_IF --> inside an HTML tag because it causes problems for the translation script.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 14:05:50 -05:00
Owen Leonard 6c9eeabc71 Corrrecting layout for opacuserlogin = 0. Fixes Bug 2228, "Wrong page design on opac-main.pl when no login section."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 08:32:37 -05:00
Owen Leonard 5697bef959 Removing redundant column. Fixes Bug 2202, "No need for View Column on Authority Search"
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 08:31:58 -05:00
Owen Leonard 6729244bb5 Terminology correction (fixes Bug 2200, "Mislabeled Column on Overdues Report")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 08:31:37 -05:00
Owen Leonard 691bcc631c Markup corrections to cataloging pages; Fixes for Bugs 2166 (" Book Jackets Not Showing on My Summary"), 2194 ("No results for Authority Search Shows blank record"), and 2196 ("Extra comma being added to record display")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 08:31:09 -05:00
Daniel Kahn Gillmor 04a8fb567d fix coins/openurl breakage when search terms include author names. (thanks, chris on #koha@irc.katipo.nz!)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 06:26:41 -05:00
Frederic Demians 7cf8284078 In OPAC, verticaly align on top biblio records and book cover image
Without this patch, on OPAC result page, depending whether book cover
image is available or not, biblio records and book cover are badly
verticaly aligned. The information is in the middle of the cell.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-16 11:31:51 -05:00
Ryan Higgins 6b6dd30170 Spelling correction in template.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-16 10:24:25 -05:00
Galen Charlton ee49d6d372 kohabug 2207 - improve indicator input in MARC editor
Instead of having one input field for both indicators
of a variable field, the bib and authority MARC editor
now has an input field for each indicator.  This has
two main advantages:

* it is easier to tell what the indicator values are,
  even when the first indicator is a space
* it is easier to set the first indicator to blank
  and the second indicator to non-blank.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-12 11:17:35 -05:00
Ryan Higgins 0f2eb979cb Fix column misalignment in opac-reserve .
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-10 12:59:45 -05:00
Frederic Demians 6716f31333 Fixes bug #2229
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-10 08:25:35 -05:00
Frederic Demians 51fbaf8f5b Fixes bug #2231
In OPAC, when cart is sent by email, the email contains an attachement:
an ISO2709 file with cart biblio records. Most users don't have a clue
what to do with this file.

This patch modifies opac-sendbasket.tmpl to clarify what the attachment is.
It also fix a bug in opac-sendbasket.pl which wasn't reading the template
section containing information about the basket:

  Here is your cart, sent from the Koha Online Catalog... foo

It may be necessary to verify that template text is in 'valid' English...

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-10 08:22:22 -05:00
Joe Atzberger fc24df29d2 Bugfix: show (cleaned) comment back on detail page.
Also added minor debug feedback to review page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-10 08:22:19 -05:00
Frederic Demians 4013d37634 Add | separator between authors repetitions in OPAC detail page
Without this patch authors display on OPAC is weird.
You get for example:
  Author: Freud--Sigmund Lacan--Jacques
And you finish to read an author 'Simund Lacan'

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-09 06:47:13 -05:00
Joe Atzberger 0694499c94 Display only approved tags, change simple form to GET, supply "strata" for eventual cloud building.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-09 06:38:04 -05:00
Galen Charlton d351753d4e kohabug 1993 - task scheduler improvements
[1] Removed hardcoded path to original developer's
    Koha configuration file; now checks KOHA_CONF.
[2] Now attempts to figure out if a task was successfully
    added to the task queue; if it wasn't, the failure
    is now reported in the  task scheduler page.
[3] When traveling to the task scheduler page from a
    saved report, the report in question is now
    selected by default.
[4] Removed the button to edit a queued task; this is
    not supported.

This patch is essentially a bandage; I've added a BUGS
section and some FIXMEs to the POD for C4::Scheduler
detailing some issues - a refactoring of the task
scheduler is in order at some point.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-09 06:38:03 -05:00
Chris Nighswonger 105b70e502 Correcting "Open" to read "Free" on shelves.pl in order to match pull-down selections
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-09 06:37:58 -05:00
Galen Charlton f08401d7ad kohabug 2205 - fix 404 when traversing pagination link in OPAC authorities search
Currently, the heading sort order is a required parameter, but was
not supplied to the template or used in the search results.  As
a result of this patch, clicking a link to view another page
of the authority search results will now work.

Outstanding issue not addressed by this patch: when searching
authorities in both the staff interface and the OPAC, choosing
sort order "none" results in a crash.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:47:37 -05:00
Ryan Higgins 5dd5b0be33 Remove vestigial checkbox for label-batch creation on MARC import
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:47:35 -05:00
Ryan Higgins d4dd393e20 Update issues_stats to use authorised_values instead of distinct(sortn); add col/row headers as Descriptions instead of codes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:47:34 -05:00
Ryan Higgins 0e31981100 Update issues_stats to show auth_vals as row & column headers
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:47:33 -05:00
Ryan Higgins 98bc024609 Add Collection code limit to issues_stats report.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:47:30 -05:00
Ryan Higgins fc99bfcbb1 Update issues_stats: add shelving location limit, replace cgi::scrolling_list, update terminology.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:47:29 -05:00
Galen Charlton 68d89cf3e1 bugfix - HTML escape syspref explanation
This applies to the list of system preferences in
the syspref editor - the OPACUserCSS syspref had
angle brackets in its description.

Used template change to accomplish this.  Note that
syspref value is escaped by the script, note the template.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:46:15 -05:00
Paul POULAIN 20c4430952 fix to display itemcallnumber on opac brief display
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:46:14 -05:00
Joe Atzberger 1bb1d04f3f Convert to using loop_context_vars for rows instead of highlight/toggle/whatever.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:43:21 -05:00
Joe Atzberger 0855e8ef29 Show copy/volume info on STAFF detail page.
This change helps the staff side catch up w/ the OPAC display and be
more useful to librarians dealing with serials.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:43:17 -05:00
Joe Atzberger 797c1d5502 Bugfix is_approved() to handle the 3-state nature of approval.
That is, a term is either approved, or rejected, or neither.
Without an external dictionary, most terms will fall into the
latter category.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:41:40 -05:00
Paul POULAIN 40c67eef33 re fixing opac-suggestion < misplaced
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:21 -05:00
Paul POULAIN 11a61ee6df html fix (detected by translator)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:20 -05:00
Paul POULAIN f3458d9577 fix to have the branch search on OPAC being really a branch search, not kw
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:15 -05:00
Paul POULAIN 6fc3c7cd9d display itemnote on check-out (added, was not here) & check-in (red-ed, was already here)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:14 -05:00
Ryan Higgins 938f053cbb Add MARC preview to cataloguing search, and add a link to add holdings. Once the edititems permission patch is accepted, this page should be updated to require edititems instead of editcatalogue.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:51 -05:00
Joe Atzberger 1d6078adea Correction to: Comment out confirmation popups (on successful events).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:46 -05:00
Joe Atzberger 47fa74d68f Comment out confirmation popups (on successful events).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:45 -05:00
Galen Charlton 1a41d12a96 kohabug 2078 - removed ersatz ESCAPE="html" added in prior patch
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:50 -05:00
Galen Charlton 765c645536 kohabug 2078 - fixed channel links in Atom and RSS
query_cgi already includes the "q=" bit.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:48 -05:00
Galen Charlton d177975239 kohabug 2078 - fix feed validation errors
Fix several validation errors in RSS and Atom feeds
generated from the OPAC:

- add missing guid to RSS elements
- add missing feed ID and element ID to Atom elements
- reflect OPACBaseURL changes
- fix atom:link self links
- add HTML escaping to fields comming from bib record
- set default timestamp for Atom updated elements

Issues identified but not solved in this patch:

- setting Atom updated element for each bib (presumably
  from biblio.timestamp)
- possible problems performing paging of Atom feed

Based on successful validation of feeds by feedvalidatory.org,
it is expected that feeds should now work in IE7 and IE6.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:51:10 -05:00