Commit Graph

6432 Commits

Author SHA1 Message Date
Martin Renvoize 31789383aa
Bug 38087: (follow-up) Add missing div to template
We lost a closing div somewhere during the life of this patchset

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-21 17:50:28 +01:00
Martin Renvoize ede4088d7a
Bug 38087: Add print template for WELCOME notice at install time
This patch adds a default print template for the welcome notice. It will
be installed at install time but will not be added at upgrade time.

It will also be available as the default under the notice templates
tool.

Test plan
1) Apply the patch
2) Under 'Tools > Notices and Slips' select the 'WELCOME' notice to edit
3) Click 'View default' under the 'Print' message transport type
4) Note the new default template is shown
5) Use 'Copy to template' to apply it to the notice
6) Use a user (Henry perhaps under sandboxes) without an email address
   to test the template by
6a) Under 'more' click 'Send welcome notice'
7) Preview the pending print notice under the patrons notices tab by
   clicking the notice title.
8) Confirm the notice looks reasonable and sign off

Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-21 17:50:28 +01:00
Katrin Fischer a629a518f5
Bug 38494: DBRev 24.12.00.020
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-20 17:23:08 +01:00
Janusz Kaczmarek ebba76f1b7
Bug 38494: (follow-up) Text amendments clarifying that it is about MARC21 records
Refers to ConsiderHeadingUse and ShowHeadingUse systempreferences.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-20 17:23:07 +01:00
Janusz Kaczmarek 70138465cd
Bug 38494: Add 'ConsiderHeadingUse' system preference
Add new system preference 'ConsiderHeadingUse' to be able to consider
the intended use of authority records (008/14-16) during cataloging
and linking.

Sponsored-by: Ignatianum University in Cracow
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-20 17:23:05 +01:00
Martin Renvoize 84c5e81b07
Bug 38663: (follow-up) Make database update idempotent
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-19 11:55:30 +01:00
Katrin Fischer 5590baaf01
Bug 38615: DBRev 24.12.00.019
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-17 08:21:27 +01:00
Lucas Gass 8c8c480db0
Bug 38615: Add ability to set hold cancellation request via SIP
To test:
1. APPLY PATCH, updatedatabase, restart_all
2. Search for the new system preference HoldCancellationRequestSIP, it should be set to 'Don't'. Leave it as is.
3. Make some holds, either in the staff client of via SIP.
    -/kohadevbox/koha/misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m hold --patron 23529000035676 --item 39999000001310 --hold-mode +

4. Mark the hold as waiting.
5. Cancel it via SIP:
    -/kohadevbox/koha/misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m hold --patron 23529000035676 --item 39999000001310 --hold-mode -

6. The hold is cancelled like normal, the screen msg should be "Hold Cancelled."
7. Change HoldCancellationRequestSIP to 'Do'.
8. Do steps 3-5 again.
9. Now the screen message is 'Hold Cancellation Requested.'
10. Now check Holds awaiting pickup. In the "Holds with cancellation requests" tab you should now see the hold from step 8.

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-17 08:21:26 +01:00
Lucas Gass abc532b90f
Bug 38615: Atomic update
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-17 08:21:25 +01:00
Jonathan Druart 0fb5bc3e04
Bug 35635: Add missing NOT NULL clause in db rev
Jenkins job testing the update DB was failing:

18:11:48 koha_1       | +++ b/Koha/Schema/Result/BorrowerAttributeType.pm
18:11:48 koha_1       | @@ -141,7 +141,7 @@ defines if this field is copied to anonymized_borrower_attributes (1 for yes, 0
18:11:48 koha_1       |
18:11:48 koha_1       |    data_type: 'tinyint'
18:11:48 koha_1       |    default_value: 0
18:11:48 koha_1       | -  is_nullable: 0
18:11:48 koha_1       | +  is_nullable: 1
18:11:48 koha_1       |
18:11:48 koha_1       |  defines if the attribute is mandatory or not in the staff interface
18:11:48 koha_1       |
18:11:48 koha_1       | @@ -149,7 +149,7 @@ defines if the attribute is mandatory or not in the staff interface
18:11:48 koha_1       |
18:11:48 koha_1       |    data_type: 'tinyint'
18:11:48 koha_1       |    default_value: 0
18:11:48 koha_1       | -  is_nullable: 0
18:11:48 koha_1       | +  is_nullable: 1
18:11:48 koha_1       |
18:11:48 koha_1       |  defines if the attribute is mandatory or not in the OPAC
18:11:48 koha_1       |
18:11:48 koha_1       | @@ -185,9 +185,9 @@ __PACKAGE__->add_columns(
18:11:48 koha_1       |    "keep_for_pseudonymization",
18:11:48 koha_1       |    { data_type => "tinyint", default_value => 0, is_nullable => 0 },
18:11:48 koha_1       |    "mandatory",
18:11:48 koha_1       | -  { data_type => "tinyint", default_value => 0, is_nullable => 0 },
18:11:48 koha_1       | +  { data_type => "tinyint", default_value => 0, is_nullable => 1 },
18:11:48 koha_1       |    "opac_mandatory",
18:11:48 koha_1       | -  { data_type => "tinyint", default_value => 0, is_nullable => 0 },
18:11:49 koha_1       | +  { data_type => "tinyint", default_value => 0, is_nullable => 1 },
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-11 14:42:03 +01:00
Katrin Fischer 046c93d682
Bug 38663: DBRev 24.12.00.018
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-10 11:42:30 +01:00
Pedro Amorim 93c65bec84
Bug 38663: Preparation: Change record_id to varchar: database
record_if in the additional_field_values is an int(11)
This works for most cases, but in the branches case, the id column is
actually a varchar (branchcode).
This patch updates the column to accomodate for this.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-10 11:42:26 +01:00
Katrin Fischer e228cd9985
Bug 32630: DBRev 24.12.00.017
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-07 18:03:02 +01:00
Pedro Amorim a0db55fe56
Bug 32630: atomicupdate
Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-07 18:03:00 +01:00
Pedro Amorim a69f98a45d
Bug 32630: database changes
Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-07 18:02:59 +01:00
Katrin Fischer 26f8caee20
Bug 36833: DBRev 24.12.00.016
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-07 18:02:54 +01:00
Nicolas Hunstein 0c00fd565f
Bug 36833: Added German translations for new languages
To test:
-Apply patch
-Run database update
-Install German language
-Activate German translations in system preferences
-Go to advance search
-Check language pull down shows translations for languages included in this patch

Signed-off-by: William Lavoie <william.lavoie@inLibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-07 18:02:54 +01:00
Caroline Cyr La Rose 82213a4857
Bug 38891: MARC21 Addition to relator terms in technical notice 2024-10-17
This patch adds a relator term that was added to the MARC code list for
relators in the Oct. 17, 2024 technical notice. The new term is tad -
Technical advisor.

To test:
1. Apply patch and reset_all
2. Go to Administration > Authorized values
3. Search for the RELTERMS list and click on it
4. Search for tad
   --> There should be an entry for tad - Technical advisor

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-03-07 18:02:53 +01:00
Katrin Fischer 4278abd185
Bug 39075: DBRev 24.12.00.015
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-27 17:32:37 +01:00
Marcel de Rooy 0334dd9093
Bug 39075: (QA follow-up) Use new bug number. refer to old
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-27 17:32:36 +01:00
Matt Blenkinsop 50ef9576d2
Bug 39075: Fix DB inconsistencies
This patch fixes DB inconsistencies introduced in bug 34587

Test plan:
1) Run 'updatedatabase'
2) There should be no errors
3) Check the database and observe the correct assignment of the following columns
- erm_counter_logs.importdate
- erm_counter_files.date_uploaded

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] chmod 755 on new dbrev
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-27 17:32:36 +01:00
Marcel de Rooy 56fd9a7c7d
Bug 30888: (QA follow-up) Correct dbrev 24.12.00.012
Also adds empty string as default value for deletedauth_header.marcxml
in TestBuilder.

Test plan:
Run dbrev.
Run t/db_dependent/TestBuilder.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-27 17:32:31 +01:00
Katrin Fischer 94fdb27695
Bug 39200: (follow-up) Move intranet_includes in sysprefs.sql
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:30 +01:00
Emily Lamancusa 00fb10aaea
Bug 39200: Fix syspref order
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:30 +01:00
Katrin Fischer 6b756e25cd
Bug 39200: DBRev 24.12.00.014
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:27 +01:00
Emily Lamancusa 606cd8d63e
Bug 38108: (QA follow-up) Use say_success in dbrev
Use say_success instead of say when outputting a line that the
system preference was added successfully

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:27 +01:00
Lucas Gass 9a55785c8b
Bug 38108: Add system preference AlwaysShowHoldingsTableFilters
Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:26 +01:00
Caroline Cyr La Rose 49c881c54a
Bug 36109: Typo corrections
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 18:30:17 +01:00
Martin Renvoize e1931dc168
Bug 36109: Convert sample ODUE notice to TT
This is an initial submission to convert the existing <<>> sample notice
to TT.

We could do more here, like including the due date and making the fines
display more clearly optional.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 18:30:16 +01:00
Caroline Cyr La Rose 0d5c533e6f
Bug 38873: Update MARC21 default framework to Update 39 (December 2024)
This patch updates the MARC21 default bibliographic framework to include
changes brought by Update 39 to the MARC21 format.

See https://www.loc.gov/marc/bibliographic/bdapndxg.html for the list of
changes.

Changes to field 506
- Added subfield $0 Authority record control number or standard number (R)
- Added subfield $1 Real World Object URI (R)

Changes to field 508
- Added subfield $3 Materials specified (NR)

Changes to field 511
- Added subfield $3 Materials specified (NR)

Changes to field 540
- Added subfield $0 Authority record control number or standard number (R)
- Added subfield $1 Real World Object URI (R)
- Renamed subfield $f to Standardized terminology for use and reproduction rights

To test:
1. Apply patch and reset_all
2. Go to Administration > MARC bibliographic framework > Default
   framework
3. Check that the additions/modifications are correct as per the list
   above
4. Optionally, run the MARC bibliographic framework test, and make sure
   there are no errors

NOTE: This change only applies to NEW installations. For existing
installations, you must make the changes yourself in Administration >
MARC bibliographic framework. This is to avoid overwriting
customizations libraries might have made to their cataloging frameworks.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-21 16:41:27 +01:00
Katrin Fischer a0a69a234e
Bug 38689: DBRev 24.12.00.013
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-21 16:41:23 +01:00
Martin Renvoize fc2cbb2724
Bug 38689: Add edifact_errors table
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-21 16:41:18 +01:00
Katrin Fischer ba7808845d
Bug 30888: DBRev 24.12.00.012
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-21 10:41:47 +01:00
Victor Grousset/tuxayo 2261e06b82
Bug 30888: add `heading` column after bug 30047 added it to auth_header
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-21 10:41:45 +01:00
Marcel de Rooy a8929c7921
Bug 30888: Db rev for new table deletedauth_header
In line with the other deleted tables. (See also bug 20271.)

Note: Removed the auto_increment for this deleted table. There is
no need for it and it could only mess up the table. Additionally,
removed the index on origin.

Test plan:
Run updatedatabase.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

[EDIT] Removed column 'marc' (BZ 26684)

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-21 10:41:45 +01:00
Katrin Fischer f7a43db1a0
Bug 26684: DBRev 24.12.00.011
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-21 10:41:44 +01:00
David Cook c020edb17a
Bug 26684: Fix atomic update
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-21 10:41:42 +01:00
David Cook 73395bc1f9
Bug 26684: Remove marc column from existing databases
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-21 10:41:41 +01:00
David Cook 8d0f1b3a18
Bug 26684: Remove marc from auth_header for new installs
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-21 10:41:41 +01:00
Katrin Fischer 6eb4c9c2d5
Bug 35635: DBRev 24.12.00.010
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-20 17:34:58 +01:00
Jonathan Druart b25e691fd9
Bug 35635: Adjust atomic update
So that we don't do anything if the new column exists already.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-20 17:34:57 +01:00
Victor Grousset/tuxayo d0ad8a0727
Bug 35635: (QA follow-up): fix terminology
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-20 17:34:55 +01:00
Lucas Gass 189fde2304
Bug 35635: (follow-up) Fix DBRev
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-20 17:34:54 +01:00
Lucas Gass 3ec2419152
Bug 35635: DB Updates
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-20 17:34:53 +01:00
Emily Lamancusa 2a5880d86b
Bug 36112: Port default CHECKOUT_NOTE notice to TT
Port the default notice text to Template Toolkit. Also, add access to
item information in order to give more useful information about the
checked-out item that the note refers to (in this case, the item barcode
instead of the biblionumber)

To test:
1. Apply patch and reset all
2. Enable the system preference AllowCheckoutNotes
3. Go to Administration > Libraries and edit the current logged-in
   library to ensure that there is a value in the Email field
4. Check out an item to a patron
5. Ensure the patron has values in the first name and surname fields
6. Log into the OPAC as that patron
7. Click to display the patron's current checkouts
8. Click the + button to the right of a checkout
9. Click the "Add Note" button beneath the table
10. Add some text and submit the note
11. Return to the staff interface and go to the Notices tab for the patron
--> Confirm that there is a notice called "Checkout note" with all the
correct information

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-19 17:05:35 +01:00
Andrew Fuerste Henry d734a119c2
Bug 32211: Update DUEDGST and PREDUEDGST default notices to use TT
To test:
1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Enable SMS Notices
    a) Find the system preference SMSSendDriver
    b) Enter "Email" as the value for SMSSendDriver and save
4. Go to a patron account, and set the following messaging preferences:
    Item due:
        - Check SMS
        - Check Email
        - Check Digests only for both
    Advance notice
        - Select 1 day in advance
        - Check SMS
        - Check Email
        - Check Digest only for both
5. Go to the checkout tab for that patron
6. Set a custom due date for today and check out 2+ items
7. Set a custom due date for tomorrow and check out 2+ more items
8. Run the cron job to generate notices:
   misc/cronjobs/advance_notices.pl -v -c
9. Open the Notices tab on that patron's account
--> The patron should have four notices:
    Item due reminder (one for SMS and one for email)
    Advance notice of item due (one for SMS and one for email)
10. Open each notice and confirm that all information is correct

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-18 10:55:29 +01:00
Katrin Fischer 34e71af165
Bug 36954: DBRev 24.12.00.009
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-18 10:55:28 +01:00
Marcel de Rooy 754fef4bac
Bug 36954: (QA follow-up) Add a dbrev print message about sip.log
With reference to BZ comment9 and comment10.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-18 10:55:28 +01:00
Jonathan Druart 60c71484ba
Bug 38664: Fix updatedatabase.pl
This patch fixes the following error:
sort (...) interpreted as function at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 25950.

sort @words and sort { $a cmp $b } @words are functionally identical because
Perl's default sort behavior is string-wise ascending order (which is exactly
what { $a cmp $b } specifies).
2025-02-12 06:39:59 +01:00
Koha Development Team d659526b5a
Bug 38664: Tidy the whole codebase
This commit is generated using:
  % perl misc/devel/tidy.pl
*within* ktd, to get the same version of perltidy than what will be used
by our CI (currently v20230309).

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-11 14:58:24 +01:00