Commit Graph

98 Commits

Author SHA1 Message Date
tipaul e4564349f2 fixing a big bug in circulation rules : the number of issued books was calculated poorly. Seems the bug had not been found before because there most books are of the same itemtype. Of borrowers don't try to issue more than what they can ;-)
(thanks to sylvain from doXulting, that pointed the problem & suggested the fix)
2005-09-23 09:31:15 +00:00
tipaul 8e981cced0 managing ReturnBeforeExpiry flag.
If set in preferences, the return date can't be after the borrower expiry date.
2005-08-01 15:17:35 +00:00
genjimoto bcf36dbf3f Bug 969: If you try to issue an item which has been made waiting for someone, and you
override the reserve, but don't indicate that the reserve should be cancelled,
the reserve is cancelled anyway. Fixed!
2005-05-31 16:01:14 +00:00
joshferraro a26d8f0fb9 Fix to Bug 844: renewstatus subroutine should check for reserves -- now it does.
Note that I'm assuming that all libraries don't want items reserved for others
+to be renewalable.
2005-05-20 19:06:02 +00:00
joshferraro e6deffa60a Fix to Bug 844: renewstatus subroutine should check for reserves -- now it does.
Note that I'm assuming that all libraries don't want items reserved for others to be renewalable.
2005-05-20 18:55:08 +00:00
tipaul aca8736106 bugfix : checking issuing rules under certain circumstances was buggy. 2005-05-20 14:32:47 +00:00
tipaul 3b99d1cc9d * better management of joining & expiry dates :
- dates can be manually typed when adding a borrower.
	- Empty fields are automatically calculated (joining = today & expiry date calculated from borrower category)
	- Expiry date can be modified
* checking expiry date when trying to issue a book & forbidding issuing when expiry date reached. ** IMPORTANT ** This check was not done before. Thus, you may be unable to issue books where you could before. You can update your database borrower by borrower or with the following SQL command on the server : "update borrowers set expiry='2005-31-12'". You can limit the update to a borrower category with "update borrowers set expiry='2005-31-12' where categorycode='A'" (all SQL commands must be typed without any ")
2005-05-19 22:12:00 +00:00
joshferraro cbb45a5fe2 Fixes problems renewing items from issues screen. 2005-05-03 19:27:19 +00:00
tipaul 98224bf7a0 fix for #965 2005-04-07 10:02:24 +00:00
tipaul 1adf5e5f63 *** empty log message *** 2005-02-28 17:00:41 +00:00
joshferraro 5dbb6708d9 Fix for bug 937. 2005-02-22 22:41:24 +00:00
tipaul 52a123a1a4 fix for :
http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=858

* added a button to cancel issue
* adding checkbox to cancel reserve on the book (checked by default)
* the cancelation reserve is done on reserves done for a given item or for any item

Nelsonville, pls test & confirm it's OK
2004-12-15 10:47:09 +00:00
oleonard 98357d148a Fix to get returns to update "datelastseen" value with today's date 2004-11-29 17:29:37 +00:00
tipaul 1424addcc2 fix for bug 858 (no warning when issuing a reserved book) 2004-11-18 10:32:39 +00:00
tipaul 8986960a12 removing useless warn & renaming a sub that can probably be removed 2004-11-08 19:49:45 +00:00
tipaul f927e8eb36 bugfix for manually fixed duedate on issue. 2004-09-15 16:27:18 +00:00
tipaul e2a219b290 fixing bugs in issue renewal 2004-09-15 16:09:57 +00:00
tipaul 3ffcc8657d fix for circulation rules test : the default branch is "", not "*" (* is for "any borrowertype" and "any itemtype") 2004-09-14 12:37:04 +00:00
tipaul ab39e57393 fixes in circulation module 2004-08-18 15:52:14 +00:00
doxulting fd8ae64752 Debugged issuing rules n01 2004-06-29 13:02:34 +00:00
tipaul cc5e837309 bugfixes in circulation 2004-06-17 08:17:39 +00:00
doxulting d849d360a7 This time we only check books that borrowers still have 2004-05-24 14:20:15 +00:00
doxulting 8268330561 Premier commit JB34. Verification du nombre maximum de livre a emprunter. 2004-05-24 12:14:38 +00:00
tipaul a4157fd8d2 continuing code cleaning & reordering 2004-05-04 16:15:56 +00:00
tipaul 6cc534a686 POD documenting & some improvements 2004-05-03 16:36:31 +00:00
tipaul 040bcdf92b CIRCULATION : the big rewrite...
This 1st commit reorders deeply the circulation module.
The goal is to :
* have something 100% templated/translatable.
* have something easy to read & modify, to say to customers/users : you can define your circulation rules as you want if you accept to look in C4/Circ/Circ2.pm

The circulation now works :
1=> ask for the borrower barcode (as previously)
2=> ask for the item barcode.
3=> check "canbookbeissued". This new sub returns 2 arrays :
- IMPOSSIBLE : if something is here, then the issue is not possible and is not done.
- TOBECONFIRMED : if something is here, then the issue can be donc if the user confirms it.
4=> if TOBECONFIRMED is set : ask for confirmation, loop. if neither  are set or confirmation flag is set (2nd pass of the loop), then issue.

The IMPOSSIBLE & TOBECONFIRMED hashs contains :
* the reason of the line. always in capitals, with words separated by _ : BARCODE_UNKNOWN, DEBTS ... as key of the hash
* more information, as value of the hash ( TOBECONFIRMED{ALREADY_ISSUED} = "previous_borrower_name", for example)

This commit :
* compiles
* works on certain situations, not on other
* does NOT issue (the line is # )
* does not check issuing rules depending of # of books allowed / already issued

The next step is :
- check issuing rule.
- extend issuing rule to have a 3D array : for each branch / itemtype / borrowertype = issuing number and issuing length.
2004-05-03 09:10:51 +00:00
tipaul 21a379acda CIRCULATION : the big rewrite...
This 1st commit reorders deeply the circulation module.
The goal is to :
* have something 100% templated/translatable.
* have something easy to read & modify, to say to customers/users : you can define your circulation rules as you want if you accept to look in C4/Circ/Circ2.pm

The circulation now works :
1=> ask for the borrower barcode (as previously)
2=> ask for the item barcode.
3=> check "canbookbeissued". This new sub returns 2 arrays :
- IMPOSSIBLE : if something is here, then the issue is not possible and is not done.
- TOBECONFIRMED : if something is here, then the issue can be donc if the user confirms it.
4=> if TOBECONFIRMED is set : ask for confirmation, loop. if neither  are set or confirmation flag is set (2nd pass of the loop), then issue.

The IMPOSSIBLE & TOBECONFIRMED hashs contains :
* the reason of the line. always in capitals, with words separated by _ : BARCODE_UNKNOWN, DEBTS ... as key of the hash
* more information, as value of the hash ( TOBECONFIRMED{ALREADY_ISSUED} = "previous_borrower_name", for example)

This commit :
* compiles
* works on certain situations, not on other
* does NOT issue (the line is # )
* does not check issuing rules depending of # of books allowed / already issued

The next step is :
- check issuing rule.
- extend issuing rule to have a 3D array : for each branch / itemtype / borrowertype = issuing number and issuing length.
2004-05-03 09:02:12 +00:00
tipaul 207cfeb5b3 renaming items.bulk field to items.itemcallnumber.
Will be used to store call number for libraries that don't use dewey classification.
Note it's related to ITEMS, not biblio.
2004-04-02 14:55:47 +00:00
joshferraro e85cf7756f Fixes Bug 763 (Location will not change) replaced:
$dbh->do("UPDATE items holdingbranch = $tbr WHERE   items.itemnumbe$
        &itemseen($itm);
	with:
$dbh->do("UPDATE items set holdingbranch = $tbr WHERE   items.itemnumbe$
        &itemseen($itm);
2004-03-24 21:06:48 +00:00
rangi 795a46d49f Got rid of the last error message -1 bug 2004-03-06 21:26:44 +00:00
tipaul 58951e551f new feature : stocktaking/inventory.
Look in reports menu
(no DB changes)
2004-02-12 09:16:18 +00:00
tipaul 3635a596cf synch'ing 2.0.0 branch and head 2004-02-11 08:35:31 +00:00
tipaul 864f90efd4 fix for #318 2003-12-19 14:44:46 +00:00
tipaul 571906a1a4 fixing compilation bugs 2003-12-11 12:56:34 +00:00
slef c3491a735e DBI call fixes for bug 662 2003-12-08 14:08:49 +00:00
rangi 9c998cda51 Fix for bug 535, and adding the classification column to the variables
available to the template
2003-11-04 19:48:50 +00:00
rangi d7bf28d524 Fix for bug 562 2003-09-03 19:41:22 +00:00
rangi e6a4f80040 Another attempted fix for issuing bug, can NPL test this please.
It seems to be working ok for me
2003-08-04 01:53:55 +00:00
rangi e0e3784e8b Fix for bug 293 2003-07-24 09:17:42 +00:00
plugz 878b64dadd FIX: Incorrect parameters given to function Stats::UpdateStats in
issuebook and returnbook functions
2003-06-20 12:48:09 +00:00
tipaul a72d9621ae removing searchborrower from circ2.pm.
Already exists in Search.pm
this fixes bug #439 and improve consistency.
2003-06-05 17:03:31 +00:00
wolfpac444 00fef22485 Added "noissuescharge" parameter 2003-05-08 12:48:23 +00:00
tipaul 1a218daf74 fix : when a book is taken and marked "not returned yet", it's now marked returned and issue done. 2003-05-05 14:14:28 +00:00
tipaul fa5d7968a2 missing " 2003-05-05 10:11:34 +00:00
tipaul 3c4012d4de fix for 191, code reindenting & some query improvment 2003-05-05 09:41:03 +00:00
tipaul 22567447ce *** empty log message *** 2003-04-29 16:51:15 +00:00
tipaul 7d34ac8ec4 *** empty log message *** 2003-04-11 08:41:06 +00:00
tipaul b9fbe0083f *** empty log message *** 2003-03-10 15:19:33 +00:00
acli 88dcb0a314 Changed the 3 "this does nothing" lines to set the flag. Is this right? 2003-02-05 07:55:42 +00:00
acli f475af255f Implemented fixes for bug 170
1. Circ2::returnbook will throw an exception if $branch is undef
2. branch/printer-getting code is modularized into getbranch and getprinter
   with correct logic from circulation.pl (temporarily put into Circ2.pm)
3. circulation.pl and returns.pl modified to use above functions

Noted correct tab sizes for the files; returns.pl partially reformatted to
conform to the dominant correct tab size

Handle non-latin1 charsets for returns.pl
2003-02-05 06:28:56 +00:00