Commit Graph

47735 Commits

Author SHA1 Message Date
Ryan Higgins 92e89f48f4 disable actions in moremember based on staff_access permission
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:17:56 -06:00
Ryan Higgins 1a91801b06 Add Staff member type. Add permissions checks for bug# 1269
and related permissions on memberentry and mods.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:17:50 -06:00
Ryan Higgins 444d01c0a5 adding userflag to allow modification of staff borrowers.
will add Staff category type in subsequent commit

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:17:45 -06:00
Ryan Higgins 06d1995848 Slight mod to getuserflags and haspermission in prep for perms bugfix
Also adding some pod

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:17:38 -06:00
Ryan Higgins 85d8c91976 adding Staff Borrower to handle Bug 1269
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:17:14 -06:00
Galen Charlton ad4e02f91d warn on attempts to add duplicate item barcodes during batch import
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:06:24 -06:00
Galen Charlton 6bb4eb130d bug 1615: AddItem() now sets issues, renewals, and reserves
When an item was created,  the renewals, issues, and reserves columns
were not set from the MARC data.  This was noticed particularly
in the context of batch loads, where a user might supply
data for those fields.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:06:23 -06:00
Galen Charlton 45d570e378 bumped up MARC Perl module requirements
MARC::File::XML => 0.88 as part of fixing bug 1504
in turn MARC::Charset => 0.98 and MARC::Record => 2.00.

Previous required version of MARC::Record was 1.38, but
since that is three years old, assuming that most Koha
3.0 dev and testing has been done with version 2.0.0.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:06:21 -06:00
Galen Charlton 1077ff6b08 bug 1570: return to same tab if cancelling preference edit
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:06:20 -06:00
Paul POULAIN af4c92e113 Shouldn't opac-advsearch use masthead as other templates ?
Anyway, masthead-basic is badly broken atm

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:00:36 -06:00
Owen Leonard 320ccfdbfb Fixing layout of guarantor display/search and correcting javascript handling of those form fields.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:00:00 -06:00
Owen Leonard 22e2ffc573 A few corrections, reformatting display slightly
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:59:52 -06:00
Paul POULAIN 37d712fad2 Some changes to unimarc record.abs
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:59:26 -06:00
Henri-Damien LAURENT 8afd53e333 Bug fixing : infinite loop when repeated operator + distinguishing operators
limits would provide with unnecessary repeated "and"
Thus causing wild loop
So removing them.
aud was transformed into author when it qualified audience.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:58:43 -06:00
Henri-Damien LAURENT c5e961af53 small fix in README.txt
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:58:12 -06:00
root 3ddff0ce41 Bug Fixing : NZsearch
parenthesis introduce a priority.
yr:XXXX-YYYY is now processed correctly.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:57:54 -06:00
Ryan Higgins 105adc6ccd changing haspermission() to require that user has ALL requiredflags, not ANYOF requiredflags
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:57:12 -06:00
Paul POULAIN e0246785e3 UNIMARC specific : itemtype is now known as itype
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:56:51 -06:00
Paul POULAIN c28aaec2d5 it appears that hidelostitems can be true here and not set to 1 in syspref
in syspref it appears as "OFF", but in opac-search it's considered as true.
Changing the test to be sure syspref & opac-search consider the same thing

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:56:31 -06:00
Paul POULAIN a502aa1c76 HTML::Template => HTML::Template::Pro
HTML::Template is no more used, some were remaining,
fixing the "use ...;" to H::T::Pro only

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:55:55 -06:00
Joshua Ferraro a222bcc8c3 merging in changes to staff css 2007-12-02 14:51:10 -06:00
Paul POULAIN 0834d2654e adding yellow style for search term
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:49:36 -06:00
Paul POULAIN f5cddc0807 when the result has an author as search term, the link contained the <span style="term"> in it
this fix add a author_nospan, that contains the author in it's native form

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:49:01 -06:00
Paul POULAIN 419d9b8f17 material type is mc, not mt, synch'ing opac with staff
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:20:21 -06:00
Chris Cormack 432fbaed04 Fix for bug 1613 making sure the zebraqueue is updated when an item is
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:12:38 -06:00
Galen Charlton 74e51161d8 removed extraneous warns
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-28 21:44:27 -06:00
Galen Charlton 5d023531a1 bugfix: do not store item tags when saving old copy of bib
If a MARC batch was imported, then reverted, the 952s
from the saved copied of the bib were added back
when the bib was replaced, leading to duplication

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-28 21:44:23 -06:00
Owen Leonard 6810d3c982 Change from kados to XISBN.pm ("handle no response from ThingISBN"), and change to similar items markup in detail.tmpl
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-28 21:26:43 -06:00
Owen Leonard 26304d78df Trying new format for OPAC resident search bar and menus. Also making correction to opac-detail similar items markup, although it's probably still not working yet.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-28 21:25:24 -06:00
Owen Leonard d0379ed325 If LibraryName was not specified, the opac layout was broken. Adding a default ("Koha Online Catalog") to the template in case LibraryName is empty.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-28 21:25:16 -06:00
Owen Leonard ec4b899d0c Minor style tweaks here and there.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-28 21:25:11 -06:00
Owen Leonard 9a247340e7 More work on returns messages.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-28 21:25:10 -06:00
Owen Leonard 0a06f1b004 Focusing Check-In tab on returns.pl
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-28 21:25:09 -06:00
Joshua Ferraro f66d9131bf fixing problem with adv search on staff client
Issue was that language limit was being set with a
relation (=) but no operand

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-28 12:47:17 -06:00
Galen Charlton 1854ad60a3 bug 1614: revise GetMarcItem so that info dervies from items table
This should help make the items table more authoritative, and ensures
that the items editor does not blank circulation fields such as
issues.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 17:05:56 -06:00
Owen Leonard 73da5f99db Continuing reformatting of returns.tmpl; Correcting javascript error in request.tmpl.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:58:10 -06:00
Owen Leonard c5e80b7b86 Attempting to pretty up confirmations and messages in returns; Adding some variables to the template output; Fixing layout in circulation.tmpl for patrons without messages; Minor correction to OPAC css.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:58:06 -06:00
Owen Leonard fba8375c5a Tweaking display of MARC records in the OPAC
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:57:54 -06:00
Owen Leonard e77b50381d Correcting breadcrumbs
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:57:51 -06:00
Owen Leonard e8ae093b5a Adding auto-fill links for variable types
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:57:49 -06:00
Owen Leonard f9e49a6ab2 Minor changes to systempreferences markup, including re-adding edit link on system pref variable, very helpful if the display runs off the right side of the screen.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:57:38 -06:00
Owen Leonard 8d5c262682 Moving holdings, description, editions, and related into tabs, enabling AmazonSimilarItems global preference for the staff client (but not working?)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:57:27 -06:00
Owen Leonard d9821c5855 Incremental changes to reviews, similar items
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:55:36 -06:00
Galen Charlton 71b0a243a8 improved terminology for WITHDRAWN authorized value
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:52:55 -06:00
Galen Charlton fe9106af0b bugfix: handle subfield $0 in MARC for an item
Note: C4::Biblio::GetMarcFromKohaField returns (0, 0) if
the kohafield is not defined in the MARC framework, but
in may places the return value is not checked correctly
and does not recognize a subfield $0 (zero).  It
would be better if GetMarcFromKohaField returned (undef, undef)
in that circumstance, but because of the number of places
where that function is used, the changed is deferred for
post 3.0.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:52:41 -06:00
Galen Charlton 8df88ef060 bug 1616: handle NULL in damaged, wthdrawn, or itemlost columns
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:52:04 -06:00
Galen Charlton 583baef555 MARC21 framework: changed 'items.withdrawn' to 'items.wthdrawn'
The correct field is 'items.wthdrawn', not 'items.withdrawn'.
Spelling may be corrected in post-3.0 version.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:51:55 -06:00
Galen Charlton eb52fe26c3 bug 1616: update bib MARC and zebraqueue on item update
Fixed so that when using updateitem.pl to change an
item's lost, damaged, or withdrawn status, the
bib's MARC XML is updated and an entry is added
to zebraqueue.

As part of the fix, C4::Biblio::ModItemInMarconefield
now works correctly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:51:47 -06:00
Joshua Ferraro 4bf5c1b132 adding template code for AmazonSimilarItems et al
Test this by having the following ISBNs in your system:

0152018484
0152053530

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-26 21:27:25 -06:00
Joshua Ferraro 58df5cdae6 fixing langauge limit indexes were removed
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-26 21:27:13 -06:00