2ba8763bb4
Fines repair. Make fines2.pl work, give feedback, improve comments and perldoc.
...
Remove $dbh->disconnect statements as counterproductive.
Prevent description field from begining with whitespace.
Added robust debug elements. Test script behavior with:
perl misc/cronjobs/fines2.pl -v
and:
mysql> select * from accountlines;
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 07:04:42 -05:00
e0c1b0031b
Adding basic get_filters to Tags, centralizing "counts" code for Terms Summary.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 07:04:41 -05:00
366affe120
Remove string processing (redundant to new pagination_bar)
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 07:04:39 -05:00
a99164a3a1
Single FIXME comment inserted.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 07:04:39 -05:00
f36b8fd59a
Commented out fixaccounts (not used anywhere). Also improved getnextacctno.
...
You can test getnextacctno like:
perl -e 'use C4::Accounts; print getnextacctno(33), "\n";'
where 33 is a borrowernumber out of the accountlines table. Get that number like:
mysql> select borrowernumber,accountno from accountlines LIMIT 100;
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 07:04:37 -05:00
dca0e73aed
Correct number of args to getnextacctno.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 07:04:35 -05:00
4227f63313
Corrected wrong number of arguments to getnextacctno.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 07:04:33 -05:00
70829660c2
Bugfix 2026 - Comments handling overhauled. Scrubber and Error feedback added.
...
Note: we CANNOT rely on window.close in onSubmit or $().submit to close our popups.
On a relatively slow connection with a relatively large POST, commonly the close finishes
*before* the POST completes, as reported with our New Zealand clients. Despite success in
trivial cases, this should be obvious, since the event is necessarily before the submission.
It also assumes success and prevents any kind of error feedback. Other popups are likely
to exhibit this same defective behavior.
Some FIXME's outstanding: need to allow users to delete their own comments,
need to enforce and feedback on max comment length.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:51:58 -05:00
74d3dc35ee
Bugfix 1978 - if invalid duedate specified, return error, do not issue.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:40:06 -05:00
e08e6a01c3
fixed session cookie name in opac-logout.pl
...
Session Cookie name is CGISESSID in Auth.pm
Signed-off-by: Michael Hafen <mdhafen@washk12.org>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:32:52 -05:00
1ebc373d18
Unescape Comment, now that we trust Scrubber to block bad markup.
...
Obviously if we are going to allow good markup, we can't then escape it.
Documentation reference: allowed tags for comments are:
br b i em big small strong
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:30:51 -05:00
7ca4d31e82
Tags AJAX and JSON for OPAC side.
...
Note, all Tags js will live under KOHA.Tags namespace.
See opac-tags.pl perldoc for AJAX/JSON examples. The capability is already
there to be very web-servicey, even moreso than the current OPAC implementation
will utilize.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:25:17 -05:00
1e50ed05cb
Single slash added in test text string.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:50 -05:00
0626e743ec
Add error feedback and Scrubber to OPAC tags page. Beginnings of ajax code.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:47 -05:00
bbb3f00955
Initial commit for Tags back-end moderation. Requires AJAX functions from Output.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:44 -05:00
cbabfaaa5f
New subs for moderation, fixed bug to allow multiple sort fields, added POD.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:43 -05:00
ec5c3d0ee2
Add AJAX output sub, EXPORT_TAGS and enable loop_context_vars for HTML::Template::Pro.
...
The loop_context_vars will be very useful in display. They are:
__first__, __last__, __inner__, __odd__, __counter__.
Note: apparently __even__ does not exist, so instead use something like:
<!-- TMPL_UNLESS NAME="__odd__" -->
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:41 -05:00
c64f8f8bac
Add cn_source to authorised values dropdown in marc structure editor.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:17:55 -05:00
62fe8fde13
small update to french translation
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:37:22 -05:00
895153cfd8
fixing the css property for tablesorter js
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:37:21 -05:00
c07939757f
BUGFIXING authority link in detail.pl
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:37:20 -05:00
94a3a247f1
small fix for UNIMARC 600$a that is also subject
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:37:19 -05:00
778f3f3a24
Adding Image::Magick version info
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:37:18 -05:00
dc7a542deb
Update Catalog Stats report: / Remove lccn/loc filter, which seems to conflate marc21 010 and 050. / Update labels to reflect 3.0 terminology.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:32 -05:00
302da68ce5
Fill statistics table properly for renewals; and issue->checkout, return->checkin
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:30 -05:00
561e9437eb
Add ANSCR to default cn_source list.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:23 -05:00
1aa00400c4
Fix pagination error on subfield structure editor
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:22 -05:00
f924ff5fe7
add URLLinkText syspref to opac detail, and add some extra handling for MARC 21 urls.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:21 -05:00
d82ff15814
Show 856$3 (materials specified) by default in MARC21 .
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:17 -05:00
5f98f2371e
Update MARC21 simple frameworks with biblio.serial and items.enumchron
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:16 -05:00
21255a2416
Translatable facets in librarian interface
...
Pushes modified facets display from OPAC to librarian interface.
Corrects also OPAC version which were omitting Titles facet.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:26:33 -05:00
1bf93a36db
Facets (current) translatable via template
...
This patch allows to translate facets label with standart
templates / PO files. Facets are still hard coded in Koha.pm.
Template wait those hard coded facets: Topics, Places, Titles,
Autors and Libraries.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:26:31 -05:00
5838b70b06
removing warnings from C4::Members::GetMember
...
C4::Members::GetMember emitted a few unnecessary warnings when no $type was passed in. This patch prevents that.
No functional or documentation changes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:52:17 -05:00
e8fdac8d84
Bug 2047: some tests for C4::Biblio::get_biblio_authorised_values
...
I had these tests laying around for a while. I just forgot to commit them.
No functional or documentation changes needed.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:52:13 -05:00
b853e6bd10
Adding bookfund search to aqbudget.tmpl
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:51:30 -05:00
5d980853b0
Adding routing list link to table of information about each subscription (Bug 2059, "Link to Serial Collection routing list missing on menu")
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:51:24 -05:00
dcd12da0e0
Fix for bug 2130, "Patron Image Missing on Permissions Screen"; Correction to allow proper tab highlighting when viewing patron log.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:51:23 -05:00
922e8fc061
Fix for Bug 2120, "
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:56 -05:00
eb09aac059
Authorities detail page was missing toolbar, breadcrumbs.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:53 -05:00
795d9d5605
Markup error caused layout problems.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:52 -05:00
dec7a7115d
Structural changes to staff client main page to better handle layout changes with addition/subtraction of news and intranetmainuserblock markup.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:47 -05:00
bcca5c9584
Terminology correction: cancelled -> withdrawn. Also adding dateformat variable to new holds queue script to allow correct table sorting with metric dates.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:46 -05:00
5675b8d5e4
Adding breadcrumbs to advanced search screen to get us a Home link.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:45 -05:00
97becad914
Adding table sorter to holds queue report
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:42 -05:00
bcc56e6827
Tweak to OPAC search bar to help prevent wrapping.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:10 -05:00
db2f86c61f
Minor change to improve layout at lower resolutions.
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 14:41:48 -05:00
bfcdfb7f45
Interface improvements to Holds Queue report and changes to the script provided by jmf
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 14:41:44 -05:00
ff96846978
Fix for Bug 2147, "Search Results aligned top on staff side."
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 14:41:43 -05:00
62391ab1d7
Fix an encoding issue on circulation autocompletion
...
ysearch.pl returns a list of borrower details for circulation
autocomplete widget. Accented characters wasn't displayed
correctly.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:55:08 -05:00
b9ecd65610
fix for #1788 : Locations do not sort alphabetically by name in list on "Set" location
...
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:55:07 -05:00
Joe Atzberger
Michael Hafen
Ryan Higgins
Paul POULAIN
Frederic Demians
Andrew Moore
Owen Leonard