Commit Graph

59291 Commits

Author SHA1 Message Date
Matt Blenkinsop e18cd933f2
Bug 38201: Remove ARM dependency from package.json
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:18 -06:00
Matt Blenkinsop 40c08f81df
Bug 38201: Add framework tests for ResourceFormSave
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:17 -06:00
Matt Blenkinsop 0edc8702aa
Bug 38201: Add component tests for ShowElement
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:17 -06:00
Matt Blenkinsop 083a000d37
Bug 38201: Address radio type issues in ShowElemeent
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:16 -06:00
Matt Blenkinsop 109804e163
Bug 38201: Add VueFramework cypress tests
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:16 -06:00
Matt Blenkinsop 3dbd768efd
Bug 38201: DRY out cypress object deletion
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:15 -06:00
Matt Blenkinsop f3699af0f0
Bug 38201: Add cypress tests for breadcrumbs
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:15 -06:00
Matt Blenkinsop 66b372b9a4
Bug 38201: Add radio column definition to getTableColumns
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:14 -06:00
Matt Blenkinsop 11a861bf9a
Bug 38201: Rebase for changes in bug 40483 (vendor alias searching)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:14 -06:00
Matt Blenkinsop bd4659e825
Bug 38201: Add breadcrumb data where required
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:13 -06:00
Matt Blenkinsop 36311b38e3
Bug 38201: Rename table variable filters due to conflict with DT properties
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:13 -06:00
Matt Blenkinsop bfd4fb7067
Bug 38201: Element fields are already grouped in an elements directory
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:12 -06:00
Matt Blenkinsop 24e12c1723
Bug 38201: Group table related config options together
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:12 -06:00
Matt Blenkinsop 9e1fa0ac77
Bug 38201: Fix cypress tests
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:11 -06:00
Matt Blenkinsop cf8e64020d
Bug 38201: Group components in the resourceConfig
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:11 -06:00
Matt Blenkinsop 21a6746f6f
Bug 38201: Rename resourceToAddOrEdit to resourceToSave for consistency
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:10 -06:00
Matt Blenkinsop 0ec137c094
Bug 38201: Rename instancedResource to resourceConfig in base-resource.js
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:10 -06:00
Matt Blenkinsop 1d84734c7e
Bug 38201: Add further context to embed docs
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:09 -06:00
Matt Blenkinsop 8ae5c6d8b9
Bug 38201: Add an example SkeletonResource.vue
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:09 -06:00
Matt Blenkinsop 7ae8fe46b1
Bug 38201: Fix refresh regression in agreements list filters
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:08 -06:00
Matt Blenkinsop c9c3426fd1
Bug 38201: Breadcrumb tidy up
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:08 -06:00
Matt Blenkinsop b4428f303b
Bug 38201: Allow edit form breadcrumb to be dynamic
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:07 -06:00
Matt Blenkinsop 78c264408f
Bug 38201: Rename onSubmit to onFormSave
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:07 -06:00
Matt Blenkinsop 0d1c3af9b5
Bug 38201: Tidy up missed variable in base-resource
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:06 -06:00
Matt Blenkinsop f9fbe6968d
Bug 38201: Add JSDoc for the instancedResource passed to base-resource
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:06 -06:00
Matt Blenkinsop 08ca469992
Bug 38201: Group methods in base-resource.js
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:05 -06:00
Jonathan Druart 7e4199c113
Bug 38201: Fix display of packages on 'show title' - EBSCO
[Vue warn]: Property "table_id" was accessed during render but is not defined on instance.

(cherry picked from commit 99fffe9820cf752ef584450b2a58fcedec0d7359)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:05 -06:00
Jonathan Druart 83f991cf8c
Bug 38201: Restore access to the preservation module when not configured
(cherry picked from commit b076ae88fe502a51f30b078ede6cb7e952dea670)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:04 -06:00
Jonathan Druart 01cdc32694
Bug 38201: Do not freeze the app if ERMModule is turned off
(cherry picked from commit 75ed8ac404797514dc5ed615c3b1e21b6abf58ae)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:04 -06:00
Matt Blenkinsop da4dc4a66d
Bug 38201: Restore dropdown buttons to vendor show
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:03 -06:00
Matt Blenkinsop 5677734c09
Bug 38201: Fix cypress tests
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:02 -06:00
Matt Blenkinsop 6e1baf4276
Bug 38201: Fix broken action buttons on vendor list
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:02 -06:00
Matt Blenkinsop 0d9996b581
Bug 38201: Fix duplicate IDs on vendor form
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:01 -06:00
Matt Blenkinsop 31efb146d7
Bug 38201: Fix EBSCO pages
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:01 -06:00
Matt Blenkinsop ba1cbd3158
Bug 38201: Fix UI issue in titles show
Scoped styling cannot flow to child components in Vue 3 if the components have more than one root node. The added div in this patch is intended to convert BaseResource into a single root node component to allow this.

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:00 -06:00
Matt Blenkinsop bccc934c16
Bug 38201: Fix console warnings for user roles
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:40:00 -06:00
Matt Blenkinsop c24c5a8be9
Bug 38201: Prevent 'no resources' message showing in relationshipWidget if resources do exist
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:59 -06:00
Matt Blenkinsop 7d5bd4b9ae
Bug 38201: Rename the '@k' alias to koha-vue
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:59 -06:00
Jonathan Druart d80916696f
Bug 38201: Do not export $__ from the base resource
We had this following warning in the console:
[Vue warn]: setup() return property "$__" should not start with "$" or "_" which are reserved prefixes for Vue internals.

Trying to fix this and realized we could do better in our handling of
the i18n functions.

This patch suggests to:
1. Have "@k" available as the Koha Vue root path so that we can easily
   import without relative paths
   TODO - Should be applied to all other imports
2. Import the i18n functions from the components when we need it
3. Do not have them available in the i18n object exported by the
   base resource
4. Remove direct use of __() from scripts and always use $__()

(cherry picked from commit 247675939ef28a90d21be863c6a57382cf3de966)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:58 -06:00
Matt Blenkinsop 79a3bf56f5
Bug 38201: Fix missing select labels when adding items to a train
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:58 -06:00
Jonathan Druart a2f1a232be
Bug 38201: DT - Remove 'autoWidth: false'
The default is "true" and is what we use in datatables.js.

This patch also moves the CSS rules to BaseResource to avoid
duplication.

The style of DT was modified in the item list of a train, because it inherited from fieldset.rows ol table (staff-global).

(cherry picked from commit 713d2598a05e501a46d1d1b8557e7d6bf8863f0b)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:57 -06:00
Jonathan Druart adfde0959f
Bug 38201: Remove JS warning
[Vue warn]: Invalid prop: type check failed for prop "modelValue". Expected Boolean, got String with value "received".

(cherry picked from commit 24e90a6c4d3680ccf9eb24291ba747e5026dd303)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:57 -06:00
Jonathan Druart b807f95c5d
Bug 38201: Avoid redundant regex test when replacing breadcrumb placeholders
(cherry picked from commit c826ae5b36e1472b3122b6e0ff4cc49c65a9c817)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:56 -06:00
Matt Blenkinsop ee2a4f89e5
Bug 38201: Fix composition API migration omissions
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:56 -06:00
Matt Blenkinsop 0b80976cb3
Bug 38201: Allow the breadcrumb to be dynamic in the show component
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:55 -06:00
Matt Blenkinsop f34565f958
Bug 38201: Remove console warning for readonly computed value
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:55 -06:00
Matt Blenkinsop 07c9d989e2
Bug 38201: Move 'created' call into base-resource
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:54 -06:00
Matt Blenkinsop c954d0b590
Bug 38201: Add missing JSDocs to base-resource and base-element
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:54 -06:00
Matt Blenkinsop c41fc9ab1f
Bug 38201: Add missing 'created' calls to preservation resources
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:53 -06:00
Matt Blenkinsop 3903ad2f5d
Bug 38201: Restore ERM provider filtering to the left menu
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:53 -06:00