Commit Graph

4719 Commits

Author SHA1 Message Date
Andrew Fuerste-Henry b921066a4b Correct syntax error in updatedatabase
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-03-20 14:05:16 +00:00
Andrew Fuerste-Henry 94ceb792d2 Merge 21.05.12 security branch into 21.05.x
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-03-15 13:13:25 +00:00
Andrew Fuerste-Henry 1c713925bf Increment version for 21.05.12 release
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-03-10 20:01:21 +00:00
Andrew Fuerste-Henry 05f4b532bf Bug 29596: correct DBRev
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-03-07 14:39:33 +00:00
Andrew Fuerste-Henry e6faadbc86 Bug 29596: DBRev 21.05.11.001
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-03-04 15:30:39 +00:00
Tomas Cohen Arazi c014c4bc53 Bug 29596: Add Yiddish language
This patch adds the Yiddish language to Koha. The language codes were
taken from https://www.loc.gov/standards/iso639-2/php/code_list.php

Sponsored-by: Universidad Nacional de San Martín

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 808fb2679b)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-03-04 15:05:53 +00:00
Andrew Fuerste-Henry f891350ff2 Increment version for 21.05.11 release
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-21 17:37:51 +00:00
Andrew Fuerste-Henry 30642b2121 Bug 29943: DBRev 21.05.10.003
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-21 16:07:06 +00:00
Marcel de Rooy 4406fa359b Bug 29943: Db rev: replace typo in existing notices
Test plan:
Run updatedatabase.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit b5a8b89258)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-21 15:59:44 +00:00
Marcel de Rooy 1976279a08 Bug 29943: Fix NOTIFY_MANAGER notice in sample notices
Test plan:
Look good at this change, or do a new install :)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 13b3ea4b9a)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-21 15:58:43 +00:00
Fridolin Somers 7b8a548a8b Bug 29722: (QA follow-up) Replace unusual single quote
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit a4c5a16691)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-21 14:54:38 +00:00
Aleisha Amohia 63670a5251 Bug 29722: Add more sample quotes
This patch adds sample quotes from women, women of colour, trans women,
Black and Indigenous women, and people who weren't US Presidents!

To test:
1. Install a fresh Koha and import sample quotes
2. Go to Tools -> Quote editor
3. Confirm the quotes show

Sponsored-by: Catalyst IT

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 97692b4bba)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-21 14:54:27 +00:00
Andrew Fuerste-Henry 7e1e62d69b Bug 29495: DBRev 21.05.10.002
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-17 19:58:32 +00:00
Martin Renvoize f8125ecc18 Bug 29495: Drop issue_id constraint from return_claims
This patch removes the issue_id constraint from return_claims.

Due to the nature of our dual table approach to checkouts/old_checkouts
we can't safely hae this constraint and not lose data.  Prior to this
commit, when an item is checked in we move the checkout from checkouts
to old_checkouts.. this therefore triggers the delete of the issue_id
from the return_claims table as described by the foreign key constraint.

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-17 19:47:01 +00:00
Andrew Fuerste-Henry c5ebd85755 Bug 29336: DBRev 21.05.10.001
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-16 16:53:39 +00:00
Marcel de Rooy 6ab2598b2c Bug 29336: Database revision
Resizes the six fields identified earlier:

additional_fields.authorised_value_category 16=>32
auth_subfield_structure.authorised_value 10=>32
auth_tag_structure.authorised_value 10=>32
club_template_enrollment_fields.authorised_value_category 16=>32
club_template_fields.authorised_value_category 16=>32
marc_tag_structure.authorised_value 10=>32

Test plan:
Run dbrev, check database.
Bonus: Connect an AV category with a long name to a authority subfield.
Check if you see its values in the authority editor.
(This was the way I found the problem.)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 2652f29998)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-16 16:24:22 +00:00
Jonathan Druart f11ee1b673 Bug 29336: Remove TODOs
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit c3fcce1bcd)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-16 16:24:04 +00:00
Marcel de Rooy d1f366f2cb Bug 29336: Identify the fields with wrong length (or name) first
This report will fix the bad lengths first.
And mark the 'bad' names with a TODO for follow-up.
Bad name means: refers to value, should be category.
Scanning kohastructure.sql.

Note: Bug 29347 has been opened to fix the names.

Test plan:
Search for another AV category field with length<>32.
Bonus: Reinstall and check database.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit e9f0123b6d)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-16 16:23:54 +00:00
Andrew Fuerste-Henry 031b7d2eaf Increment version number for 21.05.10 release
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-09 17:51:28 +00:00
Andrew Fuerste-Henry 2a73446f78 Bug 30065: Correct errors in updatedatabase
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-02-09 17:38:38 +00:00
Andrew Fuerste-Henry 8a339dfcaf Increment version for 21.05.09 release
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-01-31 17:22:30 +00:00
Andrew Fuerste-Henry 62b64180dd DBRev 21.05.08.002
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-01-25 17:06:48 +00:00
Katrin Fischer 0823964a98 Bug 29557: (QA follow-up) Add note for translated notices to update statement
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit a150d652ce)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-01-25 16:48:11 +00:00
Jonathan Druart 238578dc46 Bug 29557: Add auto_account_expired to AUTO_RENEWALS
It was missing and the notice sent was not providing the reason of the
failure.

Test plan:
Check an item out with a date in the past, mark it as auto renew
Modify the expired date of the patron and set it in the past
Run the automatic_renewals.pl cronjob script, confirm that the notice
now contains the reason of the failure.

QA note: The template will be updated only for English installations.
Should we add an alert for others?

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 0f1f307ff8)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-01-25 16:47:56 +00:00
Andrew Fuerste-Henry 7a87c3ddb3 DBRev 21.05.08.001
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-01-10 14:57:51 +00:00
Martin Renvoize a28dd48b5e Bug 29457: Generic warning at upgrade
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Amended: Adding exec flag and two dots.
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 1dec6d9468)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-01-10 14:30:03 +00:00
Andrew Fuerste-Henry 416ab639fe Increment version for 21.05.08 release
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2021-12-23 15:39:31 +00:00
Kyle M Hall c856f04f74 Increment version for 21.05.07 release
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-11-30 11:31:34 -05:00
Kyle M Hall 2f93d46946 Increment version for 21.05.06 release 2021-11-26 06:48:56 -05:00
Kyle Hall c2430c6ee0 Bug 29341: DBRev 21.05.05.005
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-11-19 11:52:54 -05:00
Jonathan Druart f4c61260f5 Bug 29341: Remove foreign keys on pseudonymized_transactions
Behave like the statistics table and don't remove the code even if the
branch or patron's category is removed.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-11-19 11:49:44 -05:00
Marcel de Rooy 614eb80c9c Bug 29460: Fix typo 'pendin g approval'
Test plan:
Apply and git grep for it.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-11-19 11:30:49 -05:00
Kyle Hall 78e28dc804 DBRev 21.05.05.004
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-11-11 07:16:34 -05:00
Jonathan Druart d79599b7ec Bug 29386: Extend background_jobs.data to LONGTEXT
TEXT is too small, we must extend it to allow bigger jobs.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-11-11 07:11:46 -05:00
Nick Clemens eca21d35a3 Bug 29152: Change default value for SearchLimitLibrary to 'homebranch'
Behvaiour before this option was added was 'homebranch'
We should preserve this rather than introduce a change

No atomic update added as liobraries may have already set/changed the value,
but safer to default to previous behvaiour

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-11-05 08:55:08 -04:00
Mason James 1b39d0717a DBRev 21.05.05.003
https://bugs.koha-community.org/show_bug.cgi?id=29378
2021-11-01 08:46:09 -04:00
Nick Clemens 61b005822b Bug 26374: update from bug 19974 is not idempotent
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-10-29 11:46:33 -04:00
Kyle Hall 3987d23cbc Bug 29137: DBRev 21.05.04.003
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-10-08 09:47:57 -04:00
Jonathan Druart 4aaf9847c9 Bug 29137: Add new syspref to disable AV creation within the cataloguing module
"I don't like this patch at all!"
"We will see a cataloger revolt if we do not find a way to make this
optional for catalogers."

I imagined a hord of catalogers running behind me and I got scared.

This patch will allow to turn the new feature added by bug 25728 off.

Test plan:
Confirm that the new CreateAVFromCataloguing will permit to turn the
feature off.

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-10-08 09:45:41 -04:00
Kyle Hall 7d13ba8bfb Bug 28826: DBRev 21.05.04.002
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-10-08 09:32:21 -04:00
Nick Clemens ef40ba17ae Bug 28826: Add FacetOrder system preference
This bug adds a system preference to control ordering of facets and
adds the control to both Zebra and Elasticsearch

To test:
1 - Have a koha that can use both Zebra and ES
2 - Set 'displayFacetCount' to true
3 - Search in ES and Zebra
4 - Note facets in Zebra sorted alphabetically, ES by usage
5 - Apply patch, updatedatabase
6 - Search in ES and Zebra, facets are alphabetically sorted in both
7 - Find new syspref FacetOrder and set to 'by usage'
8 - Search in both engines, facets sorted by usage

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-10-08 09:30:31 -04:00
Kyle Hall a73395f7fa Bug 28373: DBRev 21.05.03.003 2021-10-08 06:45:42 -04:00
Kyle M Hall 82b2a0d91d Bug 29073: DBRev 21.05.05.001
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-10-01 14:40:44 -04:00
Nick Clemens 881c687fea Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate
DefaultHldexpirationDate is set in the pref screen to 'yes/no'

The code checks if the preference is 'true', 'no' is true

We should instead use 1/0

To test:
0 - Have a fresh devbox
1 - With syspref disabled, place a hold
2 - Note no expiration date set
3 - Enable the preference
4 - Place a hold and note the expiration date is set, good
5 - Disable the pref
6 - Place a hold and note the expiration date is set, bad
7 - Apply patch
8 - Update database
9 - Repeat 1-8, date not set when pref disabled

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-10-01 14:37:10 -04:00
Kyle Hall b17cf65633 Increment version for 21.05.04 release
Signed-off-by: Kyle Hall <kyle@bywatersolutions.com>
2021-09-23 09:47:01 -04:00
Victor Grousset/tuxayo bded25d262 Bug 28772: DBRev 20.11.09.002 2021-09-21 07:45:06 -04:00
Marcel de Rooy cedc953c46 Bug 28772: (QA follow-up) Apply change to other dbrev too [STABLE]
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-09-15 10:47:12 -04:00
Tomas Cohen Arazi b4c444a5d1 Bug 28772: Update existing keys [STABLE]
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-09-15 10:47:12 -04:00
Tomas Cohen Arazi 6c3951d414 Bug 28772: Do not hash secrets twice
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-09-15 10:47:11 -04:00
Tomas Cohen Arazi 2acf4ff1b0 Bug 28772: Update existing keys
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-09-15 10:47:11 -04:00