Commit Graph

5081 Commits

Author SHA1 Message Date
Galen Charlton 011ff56bd6 Merge branch 'Bug3482' of git://github.com/ptfs/Koha-PTFS into to-push
* 'Bug3482' of git://github.com/ptfs/Koha-PTFS:
  Bug 3482: Updated DB version
  Bug 3482 changed name of notices file
  Bug 3482 Allow hold notices to be sent in print form
  Add expiration date, today to hold notices
  Modified to use dirspec only
  Bug 3482 Print Notices via HTML
2010-03-16 20:02:31 -04:00
Galen Charlton e65fcb998b sync staff version of MARC21slimUtils.xsl with OPAC version
Fixes following error when displaying records with 880 fields:

runtime error: file .../MARC21slim2intranetDetail.xsl line 63 element call-template The called template 'm880Select' was not found.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-01 11:25:08 -05:00
Wolfgang Heymans fe35d0f704 Bug 3567: Consider ISO language codes as well
Consider ISO language codes like 'Hebr' as well as 2-letter MARC codes like '2(' when checking trailing '/r' in linkage field.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-01 11:19:35 -05:00
Jesse Weaver 63e871dd40 Bug 3482 Allow hold notices to be sent in print form
This is done by saving the notices in the message_queue table with
type 'print'. The notices are generated from a notice named
HOLD_PRINT. At the end of the day, they are dumped to an HTML file and
marked as sent by a new cronjob.

This setup is intended to be temporary; modules/batch/ shouldn't be around
forever.

Mandatory SQL:
INSERT INTO message_transport_types (message_transport_type) values ('print');
2010-02-22 10:52:04 -05:00
Garry Collum a37545eb14 Bug 2655: Fixes availabilty counts if items are on hold shelf. Patch (2/2)
This fixes the opac results - non xsl transformed - and the intranet result lists.

Also fixes opac-detail which was showing all items 'on hold' if there was a bib level request, whether items were on the hold shelf or not.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-21 20:12:16 -05:00
Garry Collum 9fa69bff82 Bug 2655: Partial fix for Items on hold shelf showing as available.
Fixes the opac results (opac-search.pl), if using xsl to transform data.  I have no way to test UNIMARC results, if someone could test it for me.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-21 20:12:12 -05:00
Owen Leonard d38a716fc1 Removing bogus style declaration
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-20 17:51:01 -05:00
Nicole Engard b86c58d5c6 move ReservesMaxPickUpDelay to Holds Policy on Circ Prefs
This preference didn't make sense in Interface - it's a holds
policy related preference and so I've moved it to that area.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-19 09:59:07 -05:00
Galen Charlton 752d1c712f bug 4182: add emailLibrarianWhenHoldIsPlaced to preferences editor
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-19 05:51:47 -05:00
Galen Charlton ab54b07ad6 bug 2970: extend new hold priority change permission
Now covers the new hold request priority buttons.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-19 05:23:42 -05:00
Owen Leonard e31b7bd9a5 Fix for Bug 2970, Create a permission for modifying holds priority
Adding two new granular permissions under 'reserveforothers,' place_holds
and modify_holds_priority. If a user does not have modify_holds_priority
permission, the option to change the priority of a hold is hidden.
Revised patch includes changes to mandatory data files including
properly translated fr-FR version.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-19 05:12:58 -05:00
Chris Cormack a98e3da534 Whoops missed Magnus Enger
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-19 05:06:27 -05:00
Galen Charlton 57869cb439 bug 1532: fix XHTML validation errors
Also changed some titles to use "hold" instead of "reserve"
for display purposes.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 22:49:48 -05:00
Kyle M Hall 3502810346 (bug 1532) Reserves Updates Ported From Dev_Week
This is a much improved re-implementation of the reserves updates from dev_week.
Less new code has been added, and more existing functions are used instead of adding new ones.

The 'Lock Hold' function has been removed due to it not working as intended.

[RM note for documentation: this adds the following features:

* ability to specify an expiration date for a hold request
  when placing it via the staff interface or OPAC
* daily batch job to cancel expired holds
* nice interface to change the priority of hold
  requests for a bib in the staff interface]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 22:49:47 -05:00
Chris Cormack 8fbc3532e5 Updating credits and history document
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 21:17:39 -05:00
Galen Charlton 5e83c889a7 bug 3825 followup: fix errors in template
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 16:35:32 -05:00
Nahuel ANGELINETTI 631a875de1 (bug #3825) improve waiting holds
[cherry-pick from 3.0.x]

This patch :
 * fix indentation
 * Separate waiting holds from holds over with tabs
 * Select only holds for librarian library

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 16:14:21 -05:00
Owen Leonard 9074faee25 Fix for Bug 4219, strange artifacts showing on lists in the staff client
Recent change to C4/VirtualShelves/Page.pm caused display of subtitles
to break in the staff client display of lists

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 15:21:47 -05:00
Galen Charlton 964206af2e Revert "bug 3765: move road type after address"
Reverted at patch submitter's request - see bug 3765
for details.

This reverts commit 3b8542bbfe.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 14:03:22 -05:00
Galen Charlton b4ce64bff4 Revert "Add basic restrictive robots.txt file to opac"
Per discussion on 12/9/2009, reverting.  I agree with Nicole Engard
that a restrictive robots.txt for the OPAC should *not* be the
default.  A patch for a README on how to do it would be nice, though.

This reverts commit 6822d69d95.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 13:23:49 -05:00
Nahuel ANGELINETTI 96e7c92583 (bug #3651) sending baskets and shelves
this patch restrict the send of baskets and shelves to authenticated users only, and show their surname/firstname in the e-mail, so the receiver will know who sent the list.
(cherry picked from commit f87b755228)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:58:08 -05:00
Owen Leonard e0b3d2e235 Some new and altered itemtype images for the NPL set
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:42:57 -05:00
Frédéric Demians 8f965b95e4 Bug 4047 - Add a link to branch URL if available on holdings in OPAC
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:29:15 -05:00
Will Stokes f27c5ae5a1 Display amount of credit patron has, not just that they have credit.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:18:03 -05:00
Galen Charlton b83474516b bug 4155 followup: fix indication of when checkbox syspref is modified
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 10:27:12 -05:00
Frédéric Demians b5d8fd8ecb Bug 4155 Can't change the language of the staff client in prefs
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 09:57:19 -05:00
Frédéric Demians 821cfebad6 OAI server fixes
- Add preference OAI-PMH:ConfFile. I just add it in web-services.pref
  and not in DB. It's enough. It's not an end-user preference. Without
  this pref, OAI server operates as previously. And preferences editor
  allow to add a new value to the DB if necessary.
- Fix response to ListMetadataFormats which was empty in extended mode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 09:45:26 -05:00
Galen Charlton effad33113 bug 1080: finish work for soundon syspref (DBrev 120)
Tweaked wording of the soundon syspref, added it to the non-English
SQL scripts, and created a DBrev.  Thanks to Nahuel and Eric
for the French translation.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 09:25:25 -05:00
Galen Charlton 0bdba46f91 bug 1080: XHTML-ify audio tags
This doesn't actually do much, since the <audio> tag is still
not defined in XHTML1, but it makes it consistent with the rest of the
markup.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 09:25:16 -05:00
root b4c887f2c4 Bugzilla 1080 to add enhancement for sound. Only changed circulation.tmpl/pl and returns.tmpl/pl and added a single syspref (set to off) along with very compressed OGG files for sound which are on the open source "artistic" licence.
Works for HTML5 because it loads smoothly and no plugins required but *at
  this time* this update will only work with staff clients which are Firefox
  version >=3.5 (std for Koha) but other browsers will soon be adding support.

  Additional sounds are included for people to modify and play with, but this
  is such a simple upgrade I doubt at this time Koha needs another complex
  selector so users can add their own sounds. It could be a nice enhancement
  later, of course.

  Suggest we stick with HTML5 <audio tag because it is a standard and no
  plug-ins.

  This simple update has been running live for SMFPL.org for almost 2 weeks

  -Darrell Ulm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 08:12:25 -05:00
Matthias Meusburger 64b79bf620 MT2116 : CSV Exports : add 'new line' as separator
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 08:00:53 -05:00
Paul Poulain 452c0ab719 MT2716: fixing finishreceive.pl Software Error
finishreceive.pl was buggy when AcqCreateItem was set to recieve (wrong API)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 07:49:08 -05:00
Paul Poulain d26687338d MT1203: don't display menus if the user don't has the permission
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 07:46:31 -05:00
Paul Poulain c26b6957b5 MT 2348 : acqui-home minor improvements
- moving some links to the left part of koha (currencies and suggestions)
- removed currency table
- changing supplier display

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 07:18:44 -05:00
Galen Charlton 1e09f54a97 bug 3973: make auto-fill button work on budget planning form
Also fixed a variety of XHTML validation errors.

Programming note: it is invalid XHTML and can break Javascript
to use element IDs and class names that start with digits.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 06:20:02 -05:00
Henri-Damien LAURENT 9d6df13554 (bug #4135) fix aqplan form
This fix the form to have always the submit button, and fix security issue in aqplan.pl(authnotrequired set to 1)

Conflicts solved:

	koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 05:10:11 -05:00
Garry Collum fad17c9da3 Bug 3652: Fixes XSS vulnerabilities and XTHML errors in opac-search-history.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:42:44 -05:00
Garry Collum 3cdbce6919 Bug 3090: Adds the report ID field to the saved reports page in the guided reports.
Adds an ID field to the save reports table in guided reports to make running runreport.pl easier for users.

Also adds zebra striping to the data table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:12:41 -05:00
Galen Charlton 12370281e6 tweak description of OpacBrowser syspref
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:08:25 -05:00
Frédéric Demians 9b99f3f660 Add OpacBrowser preference to opac.pref
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:05:58 -05:00
Galen Charlton 2b125a6f93 bug 2885: attempting to add library with existing code now gives error message
If one attempts to add a new library with a code already in use,
an error message is shown.  The main library data input by the user
is preserved, allowing the user to try a new code.

This also corrects a glitch in the previous patch concerning
adding a branch category whose code is already in use.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 21:13:50 -05:00
Chris Cormack c097736084 Fix for bug 2885, now an error message is thrown instead of a silent fail
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 20:29:44 -05:00
Will Stokes 7fc8025978 Bug #2162: Step 2, add pagination. Splits results into blocks of 250 results and adds Previous and Next buttons. Achieved using forms, hidden search variables and submit buttons.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 19:26:31 -05:00
Will Stokes 7de9a2128a Bug #2162: Step 1, prevent running of report upon entry to page. Add name run_report to submit button and checks in template.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 19:26:15 -05:00
Garry Collum 679548c302 Bug 4181: Fixes XHTML in viewlog.tmpl.
Also adds zebra striping to the data table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 19:11:52 -05:00
Galen Charlton 8a116ac314 fixed errors in previous patch
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 19:07:45 -05:00
Chris Cormack 20997939b7 Fixing some small XSS vulnerabilities
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 19:03:03 -05:00
Chris Cormack 8f902d3248 Bug 1542, followup patch to tidy up some messy dropdown behaviour
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 18:14:19 -05:00
Galen Charlton e476adcb9c remove extra /TMPL_IF
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 18:09:26 -05:00
Owen Leonard 625021ada7 Changes to further work on Bug 3550, Use GetRecordValue to get the subtitle
- Adding subtitle display to OPAC Cart, lists, and reading record
- Minor tweaks to some displays

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 14:39:42 -05:00