Commit Graph

2069 Commits

Author SHA1 Message Date
Mark Tompsett 9c91b66ff6 Bug 14422: Typo in updatedatabase.pl
TEST PLAN
---------
 1) backup db
 2) git checkout -b my_3.6.x origin/3.6.x
 3) drop db and create blank one
 4) git reset --hard origin/3.6.x
 5) run web installer
 6) set HomeorHoldingBranchReturn system preference to 'holdingbranch'.
 7) create a Default checkout, hold rule
    home -> koha administration -> Circulation and fines rules
    -- I put 10 checkouts total and clicked 'Save'
    -- there currently is not 'returnbranch' in default_circ_rules.
 8) git reset --hard origin/3.20.x
    -- or whatever version you apply this to
       (3.8.x, 3.10.x, 3.14.x, 3.16.x, 3.18.x, or 3.20.x
        -- 3.21.00.008 deletes the systempreference involved)
 9) ./installer/data/mysql/updatedatabase.pl
10) check HomeorHoldingBranchReturn systempreference
    -- Currently says 'holdingbranch', but
       the value of 'returnbranch' in default_circ_rules is
       'homebranch'.
11) repeat steps 3-8
12) apply this patch
13) repeat steps 9-10
    -- Currently says 'holdingbranch', and
       the value of 'returnbranch' in default_circ_rules is
       'holdingbranch'.
14) run koha qa test tools

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested using 3.6.x install, updated to 3.8.x
Value is preserved
No errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Note: I haven't followed the test plan, but the fix is trivial.
Maybe it could worth to upate 3.21.00.008 and check the value of
HomeOrHoldingBranchReturn before deleting it.
We could raise a warning if HomeOrHoldingBranchReturn ==
'holdingbranch'.
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>

(cherry picked from commit 8c91ca7903)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
2015-07-16 09:36:15 +00:00
Katrin Fischer 2db93a5a02 Bug 4925: Remove Smithsonian as a delivered z39.50 target
Removes the Smithsonian as a target installed with the
sample data during installation.

Also adds the newer LOC authority targets to files where
they were missing.

To test:
- Verify the Smithsonian has been removed from all
  translated installers
- Verify the files are still valid SQL and install
  correctly

NOTE: There was tiny scope creep which included ensuring
      there were two Authority z39.50 servers as well.
      Text files properly reflect the removal.
      SQL 'source' of SQL files worked properly.
      Was able to Z39.50 search for all of the 'en'.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
(cherry picked from commit 0ca21c1e48)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
2015-07-16 09:36:10 +00:00
Liz Rea 00787111f6 Update release number in updatedatabase
Typo.
2015-06-24 09:28:32 +12:00
Liz Rea 814f22e794 Increment version for 3.18.8 release
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
2015-06-23 13:41:01 +12:00
Katrin Fischer 8ba165b069 Bug 14350: Missing statement in kohastructure.sql - DROP TABLE IF EXISTS borrower_sync
Reported by Jonathan on bug 11401:

DROP TABLE IF EXISTS borrower_sync;
is missing in installer/data/mysql/kohastructure.sql

To test:
- Run the web installer and confirm all tables are
  created correctly

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 2fe241cc0f)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
2015-06-19 15:11:42 +12:00
Liz Rea 7824fde152 Updating database to version 3.18.07.001 2015-06-15 11:04:44 +12:00
Bernardo Gonzalez Kriegel 0e7d728400 Bug 14285: Bengali locale needs to be re-defined
This patch renames translation files for Bengali
language, from ben-* to bn-IN-*.
Also adds India as region

To test:
1) Apply the patch
2) Run updatedatabase
3) Install Bengali language
cd misc/translator
perl translate install bn-IN
enable

Check correct description

4) Create and install a fake Bengali variant
cd misc/translator
perl translate create bn-XX
perl translate install bn-XX
enable both variants

Check correct rendering of region

Results comply with expected test plan outcome. Signed off for bn-IN
Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit e365e6e535)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Conflicts:
	misc/translator/po/bn-IN-marc-MARC21.po
	misc/translator/po/bn-IN-marc-NORMARC.po
	misc/translator/po/bn-IN-marc-UNIMARC.po
	misc/translator/po/bn-IN-staff-prog.po
2015-06-08 16:02:58 +12:00
Chris Cormack f89ec8c210 Bumping DB version for 3.18.7 2015-05-26 12:21:50 +12:00
Tomas Cohen Arazi 259b2b1468 Bug 13984: DBRev 3.19.00.034
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit a94d5297ab)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Conflicts:
	installer/data/mysql/updatedatabase.pl
	kohaversion.pl

Rejigged to apply for 3.18.x
2015-05-17 16:32:34 +12:00
Fridolin Somers 14860e9165 Bug 13984: CardnumberLength missing in sysprefs.sql
Test plan :
- create a fresh database with installer
- check the presence of the syspref : select value from systempreferences where variable like 'CardnumberLength'

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 40183ce7af)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2015-05-17 16:29:27 +12:00
Chris Cormack a50dd63ec9 Bumping version number for release 2015-04-23 09:26:29 +12:00
Jonathan Druart 02bcbadc95 Bug 9978: Replace license header with the correct license (GPLv3+)
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

http://bugs.koha-community.org/show_bug.cgi?id=9987

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit a6c9bd0eb5)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2015-04-22 11:28:36 +12:00
Mirko Tietgen 43191a61e7 Bug 13855 - Fastadd framework has 2x 100$c, missing 100$a
The fastadd framework ist missing a 100$a subfield, it has two 100$c instead.
This patch corrects English, German, Italian and Spanish .sql files.
Italian and Spanish need translations for the field name.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested running all sql files manually.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 27962ff411)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2015-03-31 18:27:32 +13:00
Galen Charlton bf07d828d0 Increment DB revision for 3.18.5.1 release
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2015-03-23 23:06:32 +00:00
Jonathan Druart 6182dc3b48 Bug 13380: 3.18.x Fix previous DB entry
The DB entry from bug 13379 should have been executed before bug 13380.

The AV category now contain truncated values.

This patch restores the correct category values.
The DB entry from bug 13379 should have been pushed before.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2015-03-24 08:08:22 +13:00
Jonathan Druart 38d15bb20e Bug 13379: Extends authorised_values.category to varchar(32)
This patch does 2 things:
1/ It fixes a bug caused by the different data fields used for
authorised_values.category and
borrower_attribute_types.authorised_value_category (varchar(16) vs
varchar(10)).
To reproduce:
- Create a AV category with a length > 10
- Try to link a patron attribute type with this AV, it won't work.

2/ Extends this field to varchar(32): sometime 16 is not enough to
describe something

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No koha-qa errors. Error reproduced, fixed by patch.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2015-03-24 08:06:38 +13:00
Chris Cormack f851a35af6 Bumping db version for 3.18.5 release 2015-03-22 18:41:24 +13:00
Nicole 655004d921 Bug 10703: Add more serial table DB documentation
This patch adds a bit more documentation to the serial related tables
in Koha.

To test, apply the patch and review the kohastructure for comments

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 17a886aed2)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2015-03-22 11:12:41 +13:00
Nicole d6fc541b3b Bug 10703: Update Patron DB Documentation
Update patron categories and patron restrictions DB docs.

To test:

* Review database documentation for categories
* Review database documentation for patron_debarments

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 5263a9e0e9)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2015-03-22 11:12:19 +13:00
Nicole d633259ff9 Bug 10703: Update stats table documentation
This patch updates the DB documentation for the statistics
table.

To test review the file and cofirm that documentation is there

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 7404b4f177)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2015-03-22 11:11:50 +13:00
Nicole b43d8392b7 Bug 10703: Update course reserves DB documentation
To test review database documentation to see that course tables are
all documented.

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 657d4b497a)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2015-03-22 11:11:31 +13:00
Jonathan Druart 46b13460f9 Bug 13380: Wording changes
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit cd5752f372)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2015-03-17 21:00:34 +13:00
Jonathan Druart 9e82e5acce Bug 13380: Add ORDER_CANCELLATION_REASON AV to all language files
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 7c224d1cb0)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2015-03-17 21:00:12 +13:00
Jonathan Druart 8ecb0ef544 Bug 13380: Fill order cancellation reasons from AV
Since bug 7162, it's possible to give a cancellation reason on deleting
an order.
This would be better to fill an authorised values category with the
different possible values.
Like that we will avoid to have duplicate or similar reasons.

Also, it will be easier to filter or create reports.

Test plan:
0/ Don't apply the patch
1/ Cancel some orders and give a cancelletion reason
2/ Apply the patch and execute the updatedb entry
3/ Cancel an order and verify the you have a list with the reason you
previously filled + 3 new ones ('No reason', 'Sold out' and
'Restocking');
4/ Choose one and verify the value is correctly displayed on the basket
page
5/ You can also try to add other values from the admin module.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit b475728a50)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Conflicts:
	installer/data/mysql/updatedatabase.pl
	koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
2015-03-17 20:31:35 +13:00
Jonathan Druart 7a17ca5833 Bug 13380: Add the AV in the install files
(This will completely done when the patch will be QAed)

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 2c7457a0d4)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2015-03-17 20:27:05 +13:00
Chris Cormack 7c03615010 Fixing db version 2015-03-11 08:11:34 +13:00
Tomas Cohen Arazi 5e818eae48 Bug 13523: DBRev 3.19.00.012
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 06608a2440)

Conflicts:
	kohaversion.pl
2015-03-11 08:10:29 +13:00
Benjamin Rokseth ae215ebecc Bug 13523 - AddBiblio fails on mysql with STRICT_TRANS_TABLES
This patch removes the NOT NULL restriction on biblioitems.marcxml and
deletedbiblioitems.marcxml due to STRICT_TRANS_TABLES default in
Mysql 5.6.22 and onwards.

Test:

1. check mysql global settings:
   mysql > SELECT @@GLOBAL.sql_mode;
   verify that STRICT_TRANS_TABLES is not set
2. set STRICT_TRANS_TABLES (or upgrade mysql to > 5.6.21)
   mysql > SET @@GLOBAL.sql_mode = 'STRICT_TRANS_TABLES';
3. try to add biblio in Cataloguing module
   verify that it fails with a "software error"
4. apply patch
5. repeat 3 and verify that there is no "software error" any more

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I confirm with the problem with mariadb and STRICT_TRANS_TABLES enabled.
On adding a biblio (C4::Biblio::AddBiblio), biblioitems is populate in
_koha_add_biblioitem but marxcml is not generated yet. It's in
ModBiblioMarc, few lines later.
The NOT NULL condition is not valid here.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 4b59bc4e2b)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2015-03-11 08:08:02 +13:00
Chris Cormack 5584b2d968 Bumping version number for release 2015-02-23 12:21:17 +13:00
Chris Cormack 49cb53a07d Bumping db version to 3.18.03.002 2015-02-14 20:11:00 +13:00
Katrin Fischer 1da7588025 Bug - 5511 [Followup]: QA Fixes
- Move database update entry to correct spot
- Fix version number in database update
- Fix capitalization in sys pref description
- Fix sequence in sysprefs.sql

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 57d411dcd6)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2015-02-14 20:08:50 +13:00
Martin Renvoize 004e095d4c Bug - 5511 [Followup]: Switched defults
Agree with Chris that the defualt should maintain the higher security
and not reduce it.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 129fb1fbe2)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2015-02-14 20:07:48 +13:00
Amit Gupta 74f230a255 Bug - 5511: Added new system preference: SessionRestrictionByIP
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 2d4d65d526)

Conflicts:
	installer/data/mysql/updatedatabase.pl
2015-02-14 20:07:19 +13:00
Mark Tompsett fe29603318 Bug 11954 - Clean up currency default files
It makes no sense to have TRUNCATE or foreign key checks.

TEST PLAN
---------
1) Back up your database
2) in an mysql client:
     use kohadata;
     SET FOREIGN_KEY_CHECKS=0;
     TRUNCATE currency;
     source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql
     SET FOREIGN_KEY_CHECKS=0;
     TRUNCATE currency;
     source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql
     SET FOREIGN_KEY_CHECKS=0;
     TRUNCATE currency;
     source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql
     SET FOREIGN_KEY_CHECKS=1;
     QUIT
   -- These should all work without problem.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 3cf7194335)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2015-02-14 19:57:02 +13:00
Chris Cormack 7ac6d73301 Bumping version number to 3.18.03.001 2015-02-11 11:15:02 +13:00
Jonathan Druart 70282cf9a4 Bug 12905: funds with children could not be deleted
The interface should prevent to delete funds with children.
Otherwise the relationship is broken and problems occur:
1/ You don't see the orphan fund in the fund list
2/ You cannot edit the orphan fund amount ('Fund amount exceeds parent
allocation').

This patch:
- adds a JS check, template side
- adds a check in the perl script (should never be true)
- adds an updatedatabase check, in order to alert users with inconsistent data.

Test plan:
Verify you are not allow to delete a fund with children.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 522e9c5861)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2015-02-11 10:48:30 +13:00
Rafal Kopaczka f530908806 Bug 13373 - [QA Followup] - Update Polish web installer sample data files
Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 72ca839518)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2015-02-04 20:34:59 +13:00
Rafal Kopaczka c0de72a92e Bug 13373 [2/2] - Update Polish web installer sample data files.
Part 2/2 - optional files.

Changes:
- Deleted unnecessary files
- Translated description files and some values in sql files

To test:
- Aplly patch
- Run webinstaller on empty database (drop database and create new if necessary)
- Verify everything works, especially verify you have permission
to all modules, eg. Tools, Catalouging etc.
- Check spelling and grammar if you can :)

Signed-off-by: Chris <chris@bigballofwax.co.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit af148f92b4)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2015-02-04 20:34:42 +13:00
Rafal Kopaczka 70eced916d Bug 13373 [1/2] - Update Polish web installer sample data files.
Part 1/2 - mandatory files.

Changes:
- Translated user permission and user flags.
- Changed untranslated different files from en version
- Deleted unnecessary files

To test:
- Aplly patch
- Run webinstaller on empty database (drop database if necessary)
- Verify everything works, especially verify you have permission to all
modules, eg. Tools, Catalouging etc.
- Check spelling and grammar if you can :)

Signed-off-by: Chris <chris@bigballofwax.co.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit de08845edc)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2015-02-04 20:34:22 +13:00
Chris Cormack d6e5102cd7 Bumping version number for 3.18.3 release 2015-01-22 20:07:08 +13:00
Marc Véron c1cf3270fc Bug 13566 - Change translation for 'Rotating collection' in German web installer
This page changes 'Wanderned Sammlungen verwalten' to 'Rotationsbestände verwalten'

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 76f4723ba6)
2015-01-18 15:00:17 +13:00
Colin Campbell e356c60214 Bug 13285 Do the right thing if opacthemes is not set
If opacthemes is not defined updatedatabase reports the
subsequent warnings as an error. Take account of the case where
it is not set and default that to bootstrap.

This is probably a rare occurence, but should be handled

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 90c32e8856)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2014-12-31 08:14:37 +13:00
Chris Cormack ec9766e8a6 Bumping database version to 3.18.02.003 2014-12-30 10:19:49 +13:00
Kyle M Hall 903a08a4f8 Bug 1861 [QA Followup] - Don't modify userids, warn if we can't modify the index automatically
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 179ef0f28f)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2014-12-30 08:20:37 +13:00
Kyle M Hall 5e707555f8 Bug 1861 - Unique patrons logins not (totally) enforced
The Koha 3.0 patron admin page will prevent you from creating a user who
has an identical OPAC login as someone else (though I would change the
error message from "Login/password already exists." to "Login
already exists.", since it's not the password that's the
problem).

However, there's nothing enforced in the MySQL database to prevent
patrons from being imported or manually inserted with duplicate logins.
Would it be better to change the MySQL spec from this:
KEY `userid` (`userid`)
to this:
UNIQUE KEY `userid` (`userid`)

Test plan:
1) Enter mysql console
2) Attempt to create two borrowers with identical user id's
3) Note you are able to do so
4) Delete these bororwers
5) Apply this patch
6) Run updatedatabase.pl
7) Repeat step 2
8) Note you are now unable to do so

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described, no koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Leaves deletedborrowers as it is, deleting patrons still works ok.
Works according to test plan.
Database update will only be successful, when no duplicate entries
exist in the database.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit df4297621d)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2014-12-30 08:19:45 +13:00
Chris Cormack 71f1c5ef82 Database version 3.18.02.002 2014-12-26 08:06:38 +13:00
Jonathan Druart 190ee0ac2e Bug 10753: Any library is represented by an empty string
And not with "__ANY__"

Test plan:
0/ Don't apply this patch
1/ Create a suggestion for "any library"
2/ Verify suggestions.branchcode contain "__ANY__"
3/ Apply this patch and execute the updatedb entry
4/ Create a suggestion for "any library"
5/ Verify suggestions.branchcode contain "" (for both suggestions).

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 67c3217238)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2014-12-26 08:04:26 +13:00
Tomas Cohen Arazi ef22b8bf23 Bug 13436: (RM followup) university -> academic DB update
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 281b3225fc)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Conflicts:
	installer/data/mysql/updatedatabase.pl
2014-12-26 07:58:13 +13:00
Chris Cormack fffdd5f7f9 Gah, typo 2014-12-23 08:09:22 +13:00
Chris Cormack ab1db92e83 Bumping for 3.18.2 release 2014-12-22 10:09:01 +13:00