Commit Graph

583 Commits

Author SHA1 Message Date
Galen Charlton 868b8cdbaa Merge commit 'origin/master' into bl-sopac 2009-09-29 20:22:11 -04:00
Nahuel ANGELINETTI 17c831399f Delete unused function
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-29 19:53:04 -04:00
Kyle M Hall 318fd2d57d Implementation of OPAC Message formatting
This patch implements the suggestions about the new and old message system made by Owen Leonard.

Includes type fix pointed out by Owen.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-29 19:20:48 -04:00
Katrin Fischer edff257753 BUG 3380 Show serial enumeration on opac holds screen
Shows column Vol Info if serial enumeration is used for one of the items.
Replaces first patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-29 18:49:07 -04:00
Galen Charlton 2e73ac94e4 bug 3436: tweak cache settings for patron images
Per suggestion by Joe Atzberger.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-16 07:45:31 -04:00
Galen Charlton 069864d3a2 bug 3436: improve error messages in self-check
Improved the error messages displayed to users
by web-based self-checkout when a problem with
a loan occurs.

This changed was sponsored by the Plano Independent
School District.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-16 07:36:37 -04:00
Galen Charlton 7c7e1dc41d bug 3436: enhance sorting of loans (self-check)
[1] Change the default sort order of checked out
    items to have the most recent loans displayed
    first.

[2] Add the ability (via jQuery tablesorter) for
    the user to sort the list of loans.

Also fixed the formatting of the due date.

This change was sponsored by the Plano Independent School
District.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-16 07:36:35 -04:00
Galen Charlton 121a4ca0d1 bug 3436: add patron images to web self-check
Adds a new system preference, ShowPatronImageInWebBasedSelfCheck;
if this preference is ON, a patron's image is displayed
if available when using web-based self-check.

Note: a patch for updatedatabase.pl will be made when this
change is ready to push.

This change is sponsored by the Plano Independent School
District.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-16 07:36:31 -04:00
Colin Campbell 6fb8ef0d79 New Messaging System.
This system is indended to replace the old opacnotes
  and borrowernotes fields in the borrowers table.
  This system allows an unlimited number of Libraran and OPAC notes to be
  attached to a borrower. Each note has a message, a message type,
  the data it was created, and which library created it.
  Each message can only be deleted by the library that created it unless the syspref
  AllowAllMessageDeletion has been set.

  This system may be used simultaneously with the old notes system and does not affect it in any way.

  A new database table (messages) was added for this feature.

  The System also allows for pre-defined notes for Borrower records

  To use these, just create authorised values with the category BOR_NOTES
  where the Authorized Value is the short description shown in the pulldown,
  and the description is the text that should be in the note.

  Original Author: PTFS Contractor <dbavousett@ptfs.com>

  This work co-sponsered by Middletown Township Public Library, Middletown, NJ, USA
     and East Brunswick Public Library, East Brunswick, NJ, USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2009-09-15 22:11:38 -04:00
Garry Collum 311a4b7967 Bug 3602: Fixes a log error for opac-search.pl if expanded_options is not defined.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-14 21:00:14 -04:00
Nicole Engard 448ad31007 Bugs: 1172 3579 3596 fixes to patron detail in opac
This patch makes it so that the patron can see their
details even if the OPACPatronDetails sys pref is OFF.

It also removed the messaging options from the patron
details and leaves them on the messaging tab.

Finally it adds in address fields that were missing
previously on the update patron form.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-12 08:56:58 -04:00
Galen Charlton 2f99d99991 Merge commit 'origin/master' into sopac 2009-09-08 17:16:22 -04:00
Nicole Engard 8678154392 Bug 1934: Changed variables per request in bug report
System preference now looking for brackets around variables.
ex. {TITLE} instead of TITLE

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:47:33 -04:00
Galen Charlton f7f783226a ran ILS-DI code through perltidy
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:41:26 -04:00
Galen Charlton ccdc20496f bug 2505: enable strict and warnings in ILS-DI code
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:41:25 -04:00
Jean-André Santoni ed92b52b26 Added comments to ILS-DI code
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 13:41:25 -04:00
Nicole Engard b9f4fa6260 Bug 1003 Added lists to bib details pages
This patch adds links to all public lists that a bib
record belongs to to the detail page in the OPAC and
the Inranet. If the item is not in any lists nothing
shows on the detail page.  The same goes if virtualshelves
is turned OFF.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 12:58:36 -04:00
Nicole Engard 8f2d9cd6ce Bug 1934: Add system preference to handle editing of 'More searches'
This preference allows librarians to control which links appear
in the 'More Searches' box on the opac detail page. If the
preference is left blank the 'More Searches' menu will not apear
on the opac detail page at all.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 19:55:31 -04:00
Galen Charlton b159ba8e5a fix how patron_flagged gets set for opac-user.tmpl
Remove unneeded variable and get value from $borr->{'flagged'}
directly, avoiding glitch where $borr->{'flagged'} could be
set after old $patron_flagged variable was set.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 11:35:26 -04:00
Jesse Weaver f8a43317b1 Prevent OPAC renewals if fines are over limit
This introduces a new system preference, OPACFineNoRenewals, that sets a
limit on the total fines a patron can have before they can no longer
renew their own books. opac-user.pl has been updated to obey this limit.

This work sponsered by East Brunswick Public Library, East Brunswick, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 10:13:26 -04:00
Galen Charlton 201fab5c09 fixed glitch in display of current time filter in OPAC top issues
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:47:07 -04:00
Garry Collum e60b571d6d Bug 2505: Enabled warnings in opac-topissues.pl
Fixed resulting warnings and fixed a small bug with the timeLimit drop-down box.  It would not retain its value on subsequent pages if 'no Limit' was selected as an option.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:39:02 -04:00
Garry Collum 11a1c687fd Bug 2505: Enabled warnings in opac-export.pl and opac-sendbasket.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:28:27 -04:00
Garry Collum 2bd29c4af4 Bug 2505: Enable warnings in opac-passwd.pl an opac-renew.pl.
Fixed resulting warnings in opac-renew.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:28:24 -04:00
Garry Collum 90d1248a1b Bug 2505: Enabled warnings in opac-userupdate.pl
Enabled warnings.  Corrected all resulting warnings by initializing variables.

Some fixes and enhancements possibly related to Bug: 1153 - Existing B_address now shows in the resulting email. Birthdate now appears in the email using the System's default format. If the patron changes data in the form data took place the FIELD name now appears as uppercase in the resulting email.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 20:45:57 -04:00
Michael Hafen 74a4f29236 Allow the reserve date to be set on holds
This adds to the interface and code the ability to set the reserve date when
requesting a hold.

Resubmit.  Sorry, I formatted it from the wrong branch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 18:02:26 -04:00
Michael Hafen bf723f8480 bugfix opac-user stomps mylibraryfirst value in quick search label
the system preference mylibraryfirst is exported by Auth containing the logged
in users branchcode.  It is also exported as the value of the syspref by
opac-user.pl.  The effect is that when mylibraryfirst is on and the user
logged in the text label for the OPAC quick search instead of displaying
'Search (in [branchcode] only)' shows 'Search (in 1 only)'.  Other user pages
are uneffected.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-10 20:34:46 -04:00
Garry Collum 508bd2baf1 Bug 2505: Enabled warnings in opac-addbybiblionumber.pl and opac-alert-subscribe.pl
Enabled warnings and fixed unintialized variables in opac-alert-subscribe.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 22:18:26 -04:00
Garry Collum 1ab0497f7e Bug 2505: Enabled warnings in opac-serial-issues.pl and opac-showmarc.pl
Enabled warnings and also fixed resulting 'unintialized value' warning in opac-showmarc.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 15:15:10 -04:00
Garry Collum 881f977cb9 Bug 3450: RSS feed link for a tag search incorrect.
Adds the tag parameter to the RSS feed link if the results of a query are retrieved from a tag in opac.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 13:08:41 -04:00
Garry Collum 1922efff85 Bug 2505: Enabled warnings in opac_ISBDdetail.pl, opac-modrequest.pl, and opac-tags_subject.pl.
Enabling warnings in these files did not generate any warnings in the logs when tested.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 13:08:38 -04:00
Garry Collum 67085930ca Bug 2553: Alphabetizes branches and item-type drop-down lists in opac-topissues.pl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:11:08 -04:00
Garry Collum b904347142 Bug 3452: Additional patch that expands the branch name and category code in Suggestions Management.
Displays the Branch name and Category description along with their codes in Suggestion Management.

Also since I joined to the branches table the 'map' function in opac-suggestions.pl to retrieve the branchname was no longer necessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 22:05:22 -04:00
Kyle M Hall 207fb1c02a Bugfix 2339 - Place hold button display with AllowOnShelfHolds OFF (Part 2)
Added code to opac-ISBDdetail.pl to match the changes made to the template file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 11:37:04 -04:00
Garry Collum 3a058fcc9d Bug 1607: Fixes the delete checkboxes in purchase suggestions.
If a user views suggestions of another user, syspref (OPACViewOthersSuggestions), a selection check box for deletion appeared next to all of the suggested titles whether the logged-in user owned them or not. - fixed

Also fixes the "Clear all" and "Select all" links which appeared for anonymouse users, if AnonSuggestions is turned on.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 22:34:26 -04:00
Kyle M Hall 38b356da8b Bugfix 2339 - Place hold button display with AllowOnShelfHolds OFF
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 21:15:13 -04:00
Garry Collum 700f039384 Bug 3322: Fixes expandedSearchOption in opac. Makes "fewer options" possible.
Copies the logic of catalogue/search.pl to fix the expanded search option in opac. When expanded search is the default, it was impossible to go to the "fewer" options.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 22:15:30 -04:00
Garry Collum 54dad0143c Bug 3428: Alphabetizes the collection codes in the Advanced Search.
If the advancedSearchTypes = CCODE, the code descriptions are not alphabetized, as opposed to itemtypes, which are alphabetized.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 21:24:54 -04:00
Garry Collum a1f827a611 Bug 3317: Adds author and added-author to email sent from basket (Cart).
Adds the author and added author fields to the email that is sent from the shopping cart.  This makes the data sent via email consistent with the data that is viewed in the basket.

There is still a problem with author authority records other than 100 tags appearing correctly in the shopping cart.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 22:54:04 -04:00
Joe Atzberger af1fb6f0b4 Bug 2539. Remove unintegrated "spsuggest" code from search scripts.
The intent of kohaspsuggest is very confused.  It wanted to simultaneously
log every search query, and get spelling suggestions from a totally different
database_host:db_user:db_password:database.  The implementation seems
never have really made it into 3.0, however, since the only trace of the
tables it wants to query are in misc/migration_tools/22_to_30/phrase_log.sql

The job misc/spellcheck_suggest/make_spellcheck_suggest.pl does not even
target the same remote DB as the syspref tells the search code to do.  Instead, it hits the
local DB and, not finding the tables that have no way of existing in a 3.0
install, it CREATES its own tables spontaneously, using MyISAM storage, no less.
This script should be drastically overhauled, or more likely just removed.

Other fixes:
Commented out unconditional warn!
Also reduced bizarre whitespace amounts in catalogue/search.pl and
fixed warning as recommended by perl -wc:
    Scalar value @newresults[0] better written as $newresults[0]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 21:20:25 -04:00
Joe Atzberger f6e1214cd6 Cleanup opac-search.pl
Use GetBranchesLoop.  Use elsif.  Use $format w/ a fallback "" value.

More to come.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 21:01:46 -04:00
Nahuel ANGELINETTI 79fc6d81f7 (bug #3267) show items.uri in opac and intranet
This add a column in normal view, with a link to items.uri URL if it exists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 08:26:33 -04:00
Owen Leonard 5aeb6f76f1 Correction to enable sending of update emails.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:52:18 -04:00
Owen Leonard 04d2b672f6 Moving the text of an error message from the script to the template where it can be translated. Partial fix for bug 1153.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:52:11 -04:00
Nahuel ANGELINETTI ba6c8f1dd5 (bug #3363) do not reload parent if you add a biblio in shelf
this patch make the script not reloading the parent if the user add a biblio in a already existing shelf(useless).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 14:19:08 -05:00
Garry Collum 9c984ccade Bug 2889: Cleaned up toggle variable in opac-readingrecord.tmpl. Disregard previous patch.
Cleaned up toggle variable in opac-readingrecord.pl and tmpl.  Used __odd__ variable instead.

Missed </TMPL_UNLESS> in previous patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:06:56 -05:00
Jane Wagner 437188f444 Revision to my earlier patch for displaying the user name on checked-out items
My earlier patch (using the new syspref OPACShowCheckoutName mistakenly
displayed the Koha borrower number instead of the patron barcode number
in the OPAC display; this revises the script/template to use barcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-17 11:48:04 -05:00
Garry Collum ee167345d7 Bug 3317: Author displaying inconsistently or not at all. Revision to previous patch.
Revision to previous patch for bug 3317.  Removes the EXPR command from opac-basket.tmpl, which was polluting the apache logs.

NTS: Don't use EXPR.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-17 11:42:43 -05:00
Matthias Meusburger 0a2a13ca13 bug 3292: in opac branchcode should be replaced with name
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 11:03:46 -05:00
savitra.sirohi 6ae7b60962 Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages.
This is available only on the masthead search box in the OPAC.

User has to enter a word in english and press space or return to transliterate the word. The destination language can be selected from a drop down list. User can temporarily turn on/off the feature by using "ctrl +g".

A system preference - GoogleIndicTransliteration can be used to turn on this feature.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-05 18:05:47 -05:00