Commit Graph

3501 Commits

Author SHA1 Message Date
Henri-Damien LAURENT 9fb4a72122 Bug Fixing 1782 patch
Adding a new routine GetBorrowercategoryList in C4/Member
Displaying categoryname when listing categories in memberentrygen.pl
using categorytype returned with GetMember wherever it is possible.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:42:25 -05:00
Ryan Higgins 977f4bd795 show correct effective checkin date in dropbox mode.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:29:11 -05:00
Paul POULAIN bc11a3bce2 BUGFIX (bloquing) moredetail & item edition
this patch introduce the same behaviour as for additem.pl, ie : edit only own homebranch items, except for superlibrarians

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:24:48 -05:00
Galen Charlton 5cafd551be patron attributes - batch import
When ExtendedPatronAttributes is ON, the batch
patron import tool's behavior changes as follows:

[1] A new (required) column is added to the input CSV
    format.  This column should contain a list of
    attributes to set for the record, each value
    preceded by its type code.  For example, if
    the superlibrarian has defined two types,
    a unique identifier INSTID and a repeatable
    BASEBALL, this field could contain:

    "INSTID:12345,BASEBALL:Cubs"

    This field must be wrapped in quotes if multiple
    values are defined.  Since values can contain
    spaces, additional doubled-quotes may be required:

    "INSTID:12345,BASEBALL:Cubs,""BASEBALL:White Sox"""

    When replacing a patron record, any attributes specified
    in the input file replace all of the attribute values
    of any type that were previously assigned to the patron
    record.

[2] It is possible to specify a field other than the
    cardnumber to use for looking for matching patrons.
    Specifically, any attribute marked as a unique ID
    can be used.  The operator is asked to specify
    which ID type to use; if an input record has an
    attribute value of that type, and exactly one patron
    record in the database has that value, then the
    record will be overlaid or ignored according to the
    overlay setting.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:03:10 -05:00
Galen Charlton 944063b247 patron attributes - staff search and display
If ExtendedPatronAttributes is ON, patron attributes
can be displayed and edited by staff members.

The patron attributes are displayed and edited
in a new section (step 4) of the patron details page.  Each
attribute is identified by its type (including type code
and type description) and value (included value description
if the attribute is controlled by an authorised value category).

Note: if, for a repeatable attribute type, the staff member
enters multiple copies of that type with the same value, duplicates
are removed when the patron record is saved.  Also, if the type
is repeatable, a JavaScript link allows the staff member to
create new attributes of that type.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:03:09 -05:00
Galen Charlton 477bbe4d15 template changes for OPAC display of patron attributes
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:03:08 -05:00
Galen Charlton e30c9d00dd new editor for patron attribute types
Added new script under the Administration menu
to create, update, and delete patron attribute types.

Some things to note:

- once an attribute is created, its code cannot be changed
- the repeatibility and unique_id settings of an
  attribute type cannot be changed after creation -
  this is to avoid having to deal with changing
  constraints if an attribute type is already in use
  by patron records
- an attribute type cannot be deleted if it is
  used by any patron records
- this administration page is always displayed regardless
  of the value of the ExtendedPatronAttributes syspref.  If
  the syspref is off, the page will prompt the superlibrarian
  to turn it on if desired.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:03:03 -05:00
Owen Leonard fc03a2510c Finishing adding additional markup for increased flexibility in stylesheet customization. Patch also includes some markup corrections, but shouldn't result in any visual changes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:50:23 -05:00
Owen Leonard 34da7fce23 Changes to enable more flexibility in template customization. Container divs allow for graphical deliniation of logical screen areas.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:50:12 -05:00
Andrew Moore c006950355 Bug 2094: implementing ability to select particular lost status in the lost items report
This patch adds a drop-down to the lost items report to let the user select a
particular lost status to display. Only items with that particluar lost status
will be dispolayed.

The documentation for the lost items report on the staff client will need to be slightly adjusted.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:48:45 -05:00
Owen Leonard df0fccdcbf Tweaking display of "action" links in search results
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:45:20 -05:00
Owen Leonard 6b889334fb Fixing a couple of bugs, including Bug 2080, OPAC Lists : No way to remove biblios from list.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:45:15 -05:00
Owen Leonard 886fdce625 Fix for Bug 2086, Filter Button Misleading. This moves the filter form into the left-hand sidebar.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:45:11 -05:00
Owen Leonard 1942e430b2 Adding RSS icon to search results (Fix for Bug 2078, RSS Icon on OPAC)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:45:10 -05:00
Owen Leonard 460477ae1b Removing table sorting pending change to this page to allow paged display
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:45:08 -05:00
Galen Charlton 4c8a9e14a8 guided reports: make it possible to delete saved reports
Fixed JavaScript error that prevented user from deleting
a saved SQL.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:43:36 -05:00
Henri-Damien LAURENT d08d9e3fb7 Addressing bug 1782
Adding New Systempreference AddPatronLists
This systempreference allow administrator to choose if patrons are created on categorycode lists or category_type ones.

Overloading GetBorrowerCategory so that if no parameter provided, it returns the list of category records
Changing memberentry.pl in order to use the categorycode when provided.
Bug Fixing Circulation.pl so that doesnot come up with Error 500
with no category selected for GetBorrowerCategory

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 05:49:27 -05:00
NCE b369a84ec4 Fixing RSS <link>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-06 06:31:10 -05:00
Joshua Ferraro 09df0de35f Removing obsolete RSS <link> tags and the scripts 2008-05-06 06:24:50 -05:00
Owen Leonard 06a58cdcfd Tab fix
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:51 -05:00
Paul POULAIN 40e6ec2f08 synch'ing opac display with staff for scanIndexes
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:49 -05:00
Henri-Damien LAURENT 366432e18f Bug fixing : loading page macles would not load existing values for macles
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:47 -05:00
Henri-Damien LAURENT 472787bf17 Debugging Macles
say you want to edit 6 fields 630:
Provided you have those in your catalogue frameworks, you just selet 6 values and it puts values into that.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:43 -05:00
Paul POULAIN 25b7f1b56d reserve at itemlevel was displayed only if item-level_itype
This patch just moves the checkbox out of the <tmpl_if item-level_itypes>

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:38 -05:00
Paul POULAIN 182bd0f1b3 bugfix : html mistake
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:29 -05:00
Darrell Ulm e840742685 Intranet callnumber search link simple fix
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:39:15 -05:00
Darrell Ulm f125e16400 Link to Intranet Similar Items Fixed (simple), pointed to OPAC
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:39:14 -05:00
Owen Leonard c27139156b Some minor markup changes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-01 18:59:21 -05:00
Owen Leonard 85777e4ea1 Adding more details to cart's verbose view. Adding auto-print to cart print view (Addresses Bug 2070)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-01 18:59:19 -05:00
Joshua Ferraro f093a84974 Fixing bug 1629: RSS Feeds of Search Results in OPAC 2008-05-01 18:55:13 -05:00
Joshua Ferraro 9e97a44417 Changing label from Overlay? to Match? since overlay is no longer
the only operation
2008-04-30 22:04:27 -05:00
Galen Charlton 60983cfeee kohabug 2026 - HTML-escape comments
This is a partial, perhaps temporary fix.  "<", ">",
and "&" characters in patron comments (AKA reviews)
are converted to "&lt;", "&gt;", and "&amp;" to avoid
certain attacks, e.g., a user entering a <script> tag
in a comment.

A more permanent fix should scrub all (or perhaps just
unsafe) tags from submitted comments entirely.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 21:59:01 -05:00
Galen Charlton 438ed23337 staging import - enhance record overlay behavior
Enhanced the ability of catalogers to specify how
bib and item records should be added, replaced, or
ignored during a staging import.

When an import batch of bib records is staged and commit,
the user can now explicitly specify what should occur
when an incoming bib record has, or does not have, a match
with a record already in the database.  The options are:

if match found (overlay_action):
  create_new (just add the incoming record)
  replace (replace the matched record with the incoming one)
  use_template (option not implemented)
  ignore (do nothing with the incoming bib; however, the
          items attached to it may still be processed
           based on the item action)

if no match is found (nomatch_action):
  create_new (just add the incoming record)
  ignore (do nothing with the incoming bib; in this
          case, any items attached to it will be
          ignored since there will be nothing to
          attach them to)

The following options for handling items embedded in the
bib record are now available:

  always_add (add the items to the new or replaced bib)
  add_only_if_match (add the items only if the incoming bib
                     matches an existing bib)
  add_only_if_add (add the items only if the incoming bib
                   does *not* match an existing bib)
  ignore (ignore the items entirely)

With these changes, it is now possible to support the following use cases:

[1] A library joining an existing Koha database wishes to add their
    items to existing bib records if they match, but does not want
    to overlay the bib records themselves.
[2] A library wants to load a file of records, but only handle
    the new ones, not ones that are already in the database.
[3] A library wants to load a file of records, but only
    handle the ones that match existing records (e.g., if
    the records are coming back from an authority control vendor).

Documentation changes:

* See description above; also, screenshots of the 'stage MARC records
for import' and 'manage staged MARC records' should be updated.

Test cases:

* Added test cases to exercise staging and committing import batches.

UI changes:

* The pages for staging and managing import batches now have
  controls for setting the overlay action, action if no match,
  and item action separately.
* in the manage import batch tool, user is notified when they
  change overlay action, no-match action, and item action
* HTML for manage import batch tool now uses fieldsets

Database changes (DB rev 076):

* added import_batches.item_action
* added import_batches.nomatch_action
* added 'ignore' as a valid value for import_batches.overlay_action
* added 'ignored' as a valid value for import_records.status
* added 'status' as a valid value for import_items.status

API changes:

* new accessor routines for C4::ImportBatch

    GetImportBatchNoMatchAction
    SetImportBatchNoMatchAction
    GetImportBatchItemAction
    SetImportBatchItemAction

* new internal functions for C4::ImportBatch to
  determine how a given bib and item are to be
  processed, based on overlay_action, nomatch_action,
  and item_action:

    _get_commit_action
    _get_revert_action

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 21:58:46 -05:00
Joshua Ferraro d83a055504 Adding authorised value icons display in the search results
pages.
2008-04-30 21:07:29 -05:00
Andrew Moore 57b3b951c1 Bug 2047: adding images to arbitrary authorized values
I've refactored the subs I added in the previous commit so that they make a little
more sense and are in better places in the code base. I was really hoping to make use
of existing subs, but they all seemed so specific to particular uses.

The icons now show up on the OPAC item details page.

TODO: The icons still don't show up in the OPAC search results page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 20:10:43 -05:00
Andrew Moore 5b5596a69d bug 2047: adding icons to authorized values
This patch adds the ability to associate icon images with authorized values.
They're not displayed anywhere yet, though. There's also a database update
in here. I took version "3.00.00.075", but I can change that later if it gets
taken before I commit these patches.

DOCUMENTATION CHANGES: When you add or edit authorized values, you can now
associate image icons with them. These icons come from the same icon sets
that you can have with your itemtypes, such as media type. They don't show
up anywhere yet, but that's coming. Keep an eye on
http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2047
for more updates.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 20:10:31 -05:00
Andrew Moore aef807a937 bug 2047: refactoring icon manipulation logic
I'm extracting some of the icon manipulation logic so that I can get to it from the authorized values pages.

There should be no functionality or documentation changes with this commit.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 20:10:09 -05:00
Owen Leonard ecd05d3da1 Re-structuring shelf browser markup for improved robustness; Including GoogleJackets js only if pref is turned on.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:10:06 -05:00
Owen Leonard 0b399239e2 Fixes for Bug 2067 (terminology consistency)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:09:26 -05:00
Owen Leonard 5e8671477f Making label toolbars more consistent
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:09:24 -05:00
Joe Atzberger e5cd4004b5 BUGFIX labels - Adding labels was failing because of faulty "type" selection.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:09:05 -05:00
Owen Leonard a7b8359a45 Fixes for interface bugs 2064, 2065, 2066
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:09:03 -05:00
Frederic Demians e1e50db557 Add a new Debian package and GoogleJacket on OPAC detail page
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:08:46 -05:00
Marc Chantreux ca7dec79f5 fixed langauge typo
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:08:39 -05:00
Marc Chantreux 9daa5ffe84 fixed langauge typo
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:06:40 -05:00
Owen Leonard a126170a27 Minor change to improve compatibility with IE7
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-28 05:56:02 -05:00
Owen Leonard 346d8d3679 Some fixes for bug Bug 2056, No Claim Letter Note Should Stand Out, and other markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-28 05:56:00 -05:00
Owen Leonard 05600380fd Changes to improve compatibility with Internet Explorer 6 and 7
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-28 05:56:00 -05:00
Owen Leonard c0a0e885b9 Removing duplicate NPL itemtype image icons from the staff client
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-28 05:55:59 -05:00
Owen Leonard 2d921804f1 Another OPAC popup page requiring ID
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-28 05:55:58 -05:00