Commit Graph

197 Commits

Author SHA1 Message Date
Owen Leonard 72a73e0ddd Enabling listing of category codes when "new patron" button is displayed.
circulation.pl lacked the code to check whether category codes existed, meaning it would only display category types.
2009-03-04 12:47:40 +01:00
Henri-Damien LAURENT 1c51a2e8cf Updated circulation page in order to make things appear the right way 2009-02-17 15:51:55 +01:00
Henri-Damien LAURENT 568fd7b90c Adding System Preference AllowNotForLoanOverride
this system preference was created but not added to system preferences
2009-02-02 16:14:37 +01:00
Nahuel ANGELINETTI ada7677996 (bug #2893) Allow loan forcing if a syspref is set
If the syspref 'AllowNotForLoanForcing'(YESNO) is set to YES, the librarian is able to force a loan on an item set as "not for
loan".
If the item is not for loan and the syspref is set to YES, koha will ask to the librarian if he really want to check-out it,
else do nothing.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
2009-01-27 12:19:46 +01:00
Joe Atzberger 267fe06f0a Bug 2900: fix GetPendingIssues.
GetPendingIssues did several bad things:
~ select * on a 4 table join,
~ including multiple namespace collisions,
~ including large fields marc and marcxml from biblioitems,
~ return ($count, \@array_being_counted).

Not everything is fixed here (see FIXMEs), but the situation is
improved considerably, with bug 2900 resolved.  The "timestamp"
namespace collision in query should be resolved by separate patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-27 12:19:45 +01:00
Michael Hafen 9276e1cdd2 javascript redirect when selecting a patron on circulation.pl Patron Selection Screen
This adds a little javascript to the Patron Selection form input after searching for a patron to check out to.
On click it redirects to checking out to the clicked patron.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-27 12:19:44 +01:00
Joe Atzberger 16b25aee86 Trivial cleanup
2 FIXME's added.
Vestigial "8-character tabs" comment removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-12-10 14:26:59 +01:00
Henri-Damien LAURENT 620ead4445 Allow renewal limits to be overridden
Originally by Jesse Weaver <jesse.weaver@liblime.com>

This patch creates a new system preference, AllowRenewalLimitOverride,
that, if YES, allows the renewal limit to be manually overridden. It
updates C4::Circulation and reserve/renewscript.pl to obey this.

Adapted for 3.0 : Henri-Damien LAURENT
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:11:42 +01:00
Joe Atzberger 558546fc33 Circ cleanup.
Removed unused $dbh variables, converted to loop_context_var instead of togglecolor.
Prevented double comparison in sort.  The rest is whitespace cleanup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:15:55 +01:00
Michael Hafen e3528b3e83 Add fine amount to display on circ pages.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:13:57 +01:00
Michael Hafen f9dce6fd89 bug: sticky due date isn't stick if there is a question about an issue
the stickyduedate input isn't sent on from the question dialogs.  This
causes it to un-stick if there is a question.

Also removed month, day, and year as there seems to be no use for them.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:40:14 +01:00
Galen Charlton 1c69c063dc bug 2521: distinguish types of hold requests
Title-level and item-level requests are now more
clearly distinguished in the patron details page
and the patron checkout page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:51:06 +01:00
Danny Bouman 36fbcb8d1e bug2580: category name and home library will now correctly display on all patron tabs
This patch fixes several improperly named variables and includes the home library variable on the pages that were missing it. The category
description was added to the GetMemberDetails function since a couple of the pages using that function required the variable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:29 +01:00
Henri-Damien LAURENT 3fd62098ce Bug fixing : 2516
There was a problem with names ordering in circ/circulation.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:28 +01:00
Danny Bouman 9330ecd7a0 bug 2569: added the zipcode to display along with the patron address
Added the zipcode to display along with the patron address when you are viewing a Patron from the intranet.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:28 +01:00
Jesse Weaver b9f814e57f fix for bug 2371: Change fine block message behavior...
This adds a variable to the checkout form, debt_confirmed, that is 1 when the de
bt block message has been canceled for this session.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:15:13 -05:00
Jesse Weaver 1157ed9457 fix for bug 1551: Renewing doesn't move item...
This makes C4::Circulation::AddRenewal update lastreneweddate, then has circulation.pl check today's date against issuedate or lastreneweddate. It also cl
eans up a little parenthesis spacing.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-16 18:26:16 -05:00
Jesse Weaver 19b46abad1 fix number two for 2181: Late Items in Red
This new patch uses faster Perl string comparison when comparing dates for overdue checking.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-14 20:10:08 -05:00
Joshua Ferraro 508d7643ca Revert "fix for 2181: Late Items in Red"
This used Date::Manip which we went to great lengths to remove about a year ago.

This reverts commit 36b2897430.
2008-07-10 21:30:03 -05:00
Jesse Weaver 36b2897430 fix for 2181: Late Items in Red
Modified overdue check in circ/circulation.pl to use Date::Manip's Date_Cmp. This would likely be useful other places in the file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-10 15:03:37 -05:00
Owen Leonard 1e2ff18e95 More changes to update-child process. Many scripts missing necessary data for checking how to process an update-child request. Also cleaning up update-child.tmpl for formatting. Minor text change (translation problem?)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-08 18:09:38 -05:00
Owen Leonard 52c933c413 Scripts missing check for Child category type would not correctly show 'update child patron' link in toolbar.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-08 18:09:36 -05:00
Joe Atzberger 579021df92 Bugfix 1978 - on circ, check date specified output is later than now.
This resolves all remaining significant parts of the bug.
Note that this may have to be revisited for hourly or partial-day circ functionality
for 3.2.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-16 15:37:11 -05:00
Galen Charlton 28fb7a6c19 kohabug 2180 - improve display when fines block checkouts
If a patron's fine balance is over the limit set by the
noissuecharges syspref, checkouts are blocked.  However,
this was not made very clear in the interface.

Improved the display by doing the following:

[1] If the fine balance is over the noissuecharges limit, use the "blocker"
styling (i.e., make all of the text red).
[2] Add wording to explicitly signal whether or not the fine balance is
blocking charges.

Documentation changes: new screenshots of blocked checkouts.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:37 -05:00
Joe Atzberger 74d3dc35ee Bugfix 1978 - if invalid duedate specified, return error, do not issue.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:40:06 -05:00
Owen Leonard 157b5a1eb6 Adding checks for dateformat preference so that tablesorter script can be passed an extra parameter for proper sorting of metric dates (Bug 2089, dates & table ordering with jquery)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:06:32 -05:00
Henri-Damien LAURENT 9fb4a72122 Bug Fixing 1782 patch
Adding a new routine GetBorrowercategoryList in C4/Member
Displaying categoryname when listing categories in memberentrygen.pl
using categorytype returned with GetMember wherever it is possible.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:42:25 -05:00
Ryan HIggins 92ca50980f only pass needsconfirmation to template if issuing is possible
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 07:03:52 -05:00
Henri-Damien LAURENT d08d9e3fb7 Addressing bug 1782
Adding New Systempreference AddPatronLists
This systempreference allow administrator to choose if patrons are created on categorycode lists or category_type ones.

Overloading GetBorrowerCategory so that if no parameter provided, it returns the list of category records
Changing memberentry.pl in order to use the categorycode when provided.
Bug Fixing Circulation.pl so that doesnot come up with Error 500
with no category selected for GetBorrowerCategory

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 05:49:27 -05:00
Ryan Higgins f4f840da2c Small template cleanup: display library name and cat description instead of codes
in circ-menu include.  Also, change 'Default' on main login page to 'My Library'.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 17:54:19 -05:00
Owen Leonard 6594407b73 Formatting patron expiration date output (or was there a reason why this was commented out previously?)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:59:32 -05:00
Owen Leonard 193207c614 Identifying "waiting at" branch on screen.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:59:29 -05:00
Galen Charlton a2c59f25e2 various date-related cleanups in circ
* use Date::Calc to perform date arithmetic
* use Date::Calc::Today to consistently format the current date
* format date per syspref in overdue report

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-03 14:42:14 -05:00
Owen Leonard 200e00e347 Reformatting holds list to better match checkouts list
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-25 07:22:32 -05:00
Galen Charlton 2c5b25c1fc more item-level_itypes fixes
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:10 -05:00
Galen Charlton 0e0a2e74b2 removed use of TMPL_IF EXPR in circulation.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:36:39 -05:00
Chris Nighswonger c767c99051 Correcting code to display patronimage correctly
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-07 07:40:38 -06:00
Ryan Higgins 1cd6263dde Adding barcode_decode syspref
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-19 20:22:01 -06:00
Chris Nighswonger c6d6f60013 More fixes for patron images
Added GetPatronImage function to Members.pm
Added code to circulation.pl, boraccount.pl, readingrec.pl, and moremember.pl to grab patron image and pass it off to the template
Corrected code in circ-menu.inc to properly display patron image.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:24:28 -06:00
Chris Cormack 0b4862b133 Finishing off bug 1427, if the person has ReturnBeforeExpiry set they are
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-14 16:48:32 -06:00
Chris Cormack 6fcd1a6ae3 Fix for bug 1428
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-14 16:48:08 -06:00
Chris Cormack 052861306b Fix to redirect the user ot the select branch page if they try to use
circulation without a branch set

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-01 20:03:08 -06:00
Chris Cormack 48b4d54408 Fix for bug 1515
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 20:51:22 -06:00
Chris Cormack ddd0140ef1 Fix for bug 1626, whitespace stripped from barcodes
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 16:24:30 -06:00
Chris Cormack bcc60a1117 Fix for bug 1552, fix ordering of issued items
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 16:24:27 -06:00
Chris Cormack 39fad89745 Fix for bug 1253 borrowers names sorted case sensitivly in circulation.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 12:07:59 -06:00
Galen Charlton 26fa7bf58d use syspref date format for manual due date
NOTE: will fail if user manages to enter date
in wrong format.  This is not a change from before
this patch, but is pointed out.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 19:14:41 -06:00
Galen Charlton af0b208bdf use standard template var for DHTML date format
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 19:13:59 -06:00
Chris Cormack 6cfe88b7b2 Fix for bug 1427
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-19 18:55:20 -06:00
Owen Leonard 0e675ef820 - Changes to the way patron renewals are handled. Circulation page now offers 'renew' link alongside warning about patron expiration (as in dev_week), using the new setstatus script.
- Member pages now use member toolbar include instead of circ one
- setstatus.pl now uses 3.0's patron renewal function
- Adding missing item-bullet.gif (Bug 1659)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-17 19:24:49 -06:00