From ffcc2a5a9fa51cfd38ed6704b7956b12bc394d04 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Wed, 12 Feb 2025 16:34:47 +0000
Subject: [PATCH] Bug 39053: Add page-section div to reports results pages

This patch adds a "page-section" wrapping div around reports results
pages where it is missing.

Note: This patch contains indentation changes.

To test, apply the patch and test the following reports, confirming that
the results page looks correct:

- Patrons with the most checkouts
- Acquisitions statistics
- Patrons with no checkouts
- Patrons statistics
- Most-circulated items
- Catalog statistics
- Average loan time
- Circulation statistics
- Lost items
- Catalog by item types
- Holds statistics

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit bf1e45e4908192fd30895d422ba8ca544869c7da)
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
---
 .../prog/en/modules/reports/acquisitions_stats.tt             | 4 +++-
 .../intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt   | 3 +++
 .../intranet-tmpl/prog/en/modules/reports/borrowers_out.tt    | 3 +++
 .../intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt  | 3 +++
 .../intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt   | 3 +++
 .../intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt  | 3 +++
 .../intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt | 3 +++
 .../intranet-tmpl/prog/en/modules/reports/issues_stats.tt     | 3 +++
 koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt  | 3 +++
 koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt  | 3 +++
 .../intranet-tmpl/prog/en/modules/reports/reserves_stats.tt   | 4 +++-
 11 files changed, 33 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt
index e0cc08369a..947fb5bf56 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt
@@ -70,7 +70,7 @@
                 </p>
 			[% END %]
 		[% END %]
-
+            <div class="page-section">
 		<table>
 			<tr >
 				<th>[% mainloo.line | html %] / [% mainloo.column | html %]</th>
@@ -105,6 +105,8 @@
 					<th>[% mainloo.total | html %]</th>
 				</tr>
 		</table>
+            </div>
+            <!-- /.page-section -->
 	[% END %]
 [% ELSE %]
 	<form method="get" action="/cgi-bin/koha/reports/acquisitions_stats.pl">
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt
index 0c429f02fe..bd0d9a56e1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt
@@ -84,6 +84,7 @@
             [% END %]
 		[% END %]
 		
+            <div class="page-section">
 		<table>
 			<tr>
 				<th rowspan="2">Rank</th>
@@ -114,6 +115,8 @@
 				</tr>
 				[% END %]
 		</table>
+            </div>
+            <!-- /.page-section -->
 	[% END %]
 [% ELSE %]
     <h1>Patrons with the most checkouts</h1>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt
index e65914b3ed..37ae4e6e94 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt
@@ -52,6 +52,7 @@
             [% END %]
         [% END %]
         
+            <div class="page-section">
         <table>
             <tr>
                 <th>Num/Patrons</th>
@@ -69,6 +70,8 @@
                     </tr>
                 [% END %]
         </table>
+            </div>
+            <!-- /.page-section -->
     [% END %]
 [% ELSE %]
     <h1>Patrons with no checkouts</h1>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt
index a53f6212c5..cdeed7ee28 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt
@@ -63,6 +63,7 @@
 				</p>
 			[% END %]
 		[% END %]
+            <div class="page-section">
 		<table>
 			<tr>
 				<th>[% mainloo.line | html %] / [% mainloo.column | html %]</th>
@@ -91,6 +92,8 @@
 					<th>[% mainloo.total | html %]</th>
 				</tr>
 		</table>
+            </div>
+            <!-- /.page-section -->
 	[% END %]
 [% ELSE %]
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt
index 4e83c3e0df..17f7f09654 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt
@@ -57,6 +57,7 @@
 			[% END %]
 		[% END %]
 		
+            <div class="page-section">
 		<table>
 <tr>				<th>Rank/Biblioitemnumbers</th>
 				[% FOREACH loopco IN mainloo.loopcol %]
@@ -88,6 +89,8 @@
 					</tr>
 				[% END %]
 		</table>
+            </div>
+            <!-- /.page-section -->
 	[% END %]
 [% ELSE %]
     <h1>Most-circulated items</h1>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt
index 70e20b5be3..2eb9527e0c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt
@@ -56,6 +56,7 @@
 			[% END %]
 		[% END %]
 		
+            <div class="page-section">
         <table id="catalogue_stats">
             <thead>
                 <tr>
@@ -96,6 +97,8 @@
 				</tr>
             </tfoot>
 		</table>
+            </div>
+            <!-- /.page-section -->
 	[% END %]
 [% ELSE %]
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt
index 98f58de4c7..1990c39586 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt
@@ -53,6 +53,7 @@
 			[% END %]
 		[% END %]
 		
+            <div class="page-section">
 		<table>
 			<tr>
 				<th>[% mainloo.line | html %] / [% mainloo.column | html %]</th>
@@ -85,6 +86,8 @@
 					<th>[% mainloo.total | html %]</th>
 				</tr>
 		</table>
+            </div>
+            <!-- /.page-section -->
 	[% END %]
 [% ELSE %]
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt
index b9bdf2931a..8e96897db9 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt
@@ -86,6 +86,7 @@
             </ul>
         [% END %]
         
+            <div class="page-section">
         <table> 
             <tr>
                 <th>[% mainloo.line | html %] / [% mainloo.column | html %]</th>
@@ -111,6 +112,8 @@
                 <th>[% mainloo.total | html %]</th>
             </tr>
         </table>
+            </div>
+            <!-- /.page-section -->
     [% END %]
 [% ELSE %]
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
index cccb96b822..69562df208 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
@@ -84,6 +84,7 @@
             </div>
         [% END %]
 
+            <div class="page-section">
         <table id="lostitems-table">
             <thead>
                 <tr>
@@ -140,6 +141,8 @@
                 [% END %]
             </tbody>
         </table>
+            </div>
+            <!-- /.page-section -->
     [% END %]
 	[% ELSE %]
 	
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt
index b280d104d4..ddb5b25de9 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt
@@ -51,6 +51,7 @@
 [% IF ( do_it ) %]
 [% FOREACH mainloo IN mainloop %]
     <h1>Reports on item types [% IF branch %] held at [% Branches.GetName( branch ) | html %][% END %]</h1>
+            <div class="page-section">
 	<table id="itemtypest">
 		<thead>
 		<tr>
@@ -73,6 +74,8 @@
 			[% END %]
 		</tbody>
 	</table>
+            </div>
+            <!-- /.page-section -->
 [% END %]
 [% ELSE %]
         <h1>View a count of items held at your library grouped by item type</h1>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt
index 591608e743..7e1129f1a7 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt
@@ -81,7 +81,7 @@
         [% END %]
 		
     [% FOREACH mainloo IN mainloop %]
-        
+	<div class="page-section">
         <table> 
             <tr>
                 <th>[% mainloo.line | html %] / [% mainloo.column | html %]</th>
@@ -109,6 +109,8 @@
                 <th>[% mainloo.total | html %]</th>
             </tr>
         </table>
+                </div>
+                <!-- /.page-section -->
     [% END %]
     [% END %]
 [% ELSE %]