gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24807: (QA follow-up) Remove uneccessary tests 

These tests fail now, the code expects a real response from ES in Indexer.pm
but these tests mock 'bulk' and so don't have the necessary fields.

We are testing the same code above and can just add the _id == biblionumber test

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Nick Clemens 2020-09-18 10:35:43 +00:00 committed by Jonathan Druart
parent d45a699975
commit ffc156f84e
1 changed files with 3 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t
View File

@ -17,7 +17,7 @@
use Modern::Perl;
use Test::More tests => 3;
use Test::More tests => 2;
use Test::MockModule;
use t::lib::Mocks;
@ -30,7 +30,7 @@ my $schema = Koha::Database->schema();
use_ok('Koha::SearchEngine::Elasticsearch::Indexer');
subtest 'create_index() tests' => sub {
plan tests => 5;
plan tests => 6;
my $se = Test::MockModule->new( 'Koha::SearchEngine::Elasticsearch' );
$se->mock( '_read_configuration', sub {
my ($self, $sub ) = @_;
@ -63,6 +63,7 @@ subtest 'create_index() tests' => sub {
my $response = $indexer->update_index([1], $records);
is( $response->{errors}, 0, "no error on update_index" );
is( scalar(@{$response->{items}}), 1, "1 item indexed" );
is( $response->{items}[0]->{index}->{_id},"1", "We should get a string matching the bibnumber passed in");
is(
$indexer->drop_index(),
@ -70,29 +71,3 @@ subtest 'create_index() tests' => sub {
'Dropping the index'
);
};
subtest 'update_index() tests' => sub {
plan tests => 2;
my $kse = Test::MockModule->new( 'Koha::SearchEngine::Elasticsearch' );
$kse->mock( 'marc_records_to_documents', sub {
my ($self, $params ) = @_;
return [1];
});
my $indexer;
ok(
$indexer = Koha::SearchEngine::Elasticsearch::Indexer->new({ 'index' => 'biblios' }),
'Creating a new indexer object'
);
my $searcher = $indexer->get_elasticsearch();
my $se = Test::MockModule->new( ref $searcher );
$se->mock( 'bulk', sub {
my ($self, %params ) = @_;
return $params{body};
});
my $bibnumber_array = $indexer->update_index([13],["faked"]);
is( $bibnumber_array->[0]->{index}->{_id},"13", "We should get a string matching the bibnumber");
};