gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 30730: Unit tests 

Added an entry in holds for an item with negative notforloan value to
test if get_items_that_can_fill returns the right items.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Shi Yao Wang 2022-05-17 11:37:21 -04:00 committed by Fridolin Somers
parent 5679d5df5f
commit fdfb75eaf6
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
t/db_dependent/Koha/Holds.t
View File

@ -426,7 +426,7 @@ subtest 'get_items_that_can_fill' => sub {
my $item_5 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, itype => $itype_2->itemtype } );
my $lost = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, itemlost => 1 } );
my $withdrawn = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, withdrawn => 1 } );
my $notforloan = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, notforloan => 1 } );
my $notforloan = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, notforloan => -1 } );
my $patron_1 = $builder->build_object( { class => 'Koha::Patrons' } );
my $patron_2 = $builder->build_object( { class => 'Koha::Patrons' } );
@ -466,6 +466,15 @@ subtest 'get_items_that_can_fill' => sub {
}
);
my $notforloan_reserve_id = C4::Reserves::AddReserve(
{
borrowernumber => $patron_2->borrowernumber,
biblionumber => $biblio->biblionumber,
priority => 0,
itemnumber => $notforloan->itemnumber,
}
);
# item 3 is on loan
AddIssue( $patron_3->unblessed, $item_3->barcode );
@ -483,7 +492,7 @@ subtest 'get_items_that_can_fill' => sub {
$holds = Koha::Holds->search(
{
reserve_id => [ $reserve_id_1, $reserve_id_2, $waiting_reserve_id, ]
reserve_id => [ $reserve_id_1, $reserve_id_2, $waiting_reserve_id, $notforloan_reserve_id, ]
}
);