Bug 23185: ->update can only be called on instantiated classes

Since our use ok Koha::Objects, there's been an implicit instantiation
happening in ->search that has somehow hidden the fact that classes need
instantiation...

This change in ->delete and ->update made it clear because of the
failures/hangs on the tests.

This patch instantiates Koha::Patron::Categories before attempting to
call ->update.

The original patches for this bug are correct and the only issue here is
that we need to document better than for some methods, instantiation is
not implicit and is required first. This is awkward and I would prefer
to force everyone to call ->new first. But I understand it would be
inconvenient.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Template/Plugin/Categories.t
=> FAIL: Notice it hangs, Ctrl+c to abort
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests dong hang, and in fact pass
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Tomas Cohen Arazi 2020-05-07 18:05:29 -03:00
parent 185d88bac6
commit fdea245e99
2 changed files with 3 additions and 2 deletions

View File

@ -196,7 +196,8 @@ sub delete {
=head3 update
$object->update( $fields, [ { no_triggers => 0/1 } ] );
my $objects = Koha::Objects->new; # or Koha::Objects->search
$objects->update( $fields, [ { no_triggers => 0/1 } ] );
This method overloads the DBIC inherited one so if code-level triggers exist
(through the use of an overloaded I<update> or I<store> method in the Koha::Object

View File

@ -65,7 +65,7 @@ subtest 'can_any_reset_password() tests' => sub {
$schema->storage->txn_begin;
# Make sure all existing categories have reset_password set to 0
Koha::Patron::Categories->update({ reset_password => 0 });
Koha::Patron::Categories->search->update({ reset_password => 0 });
ok( !Koha::Template::Plugin::Categories->new->can_any_reset_password, 'No category is allowed to reset password' );