From fb7ed498e9f5400f56ae09a080c6b50b06e9ab78 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 5 Sep 2024 12:57:57 +0000 Subject: [PATCH] Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses Rather than add a style to a whole table row I think we should use BS5's badge classes to style debug mode and default configuration information. To test you should have at least one SMTP server set as default and at least one with debug mode turned on. Go to Administration -> SMTP servers and view the table of SMTP servers. Any server with debug mode turned on should show "On" styled as a yellow badge with black text. A server set as default should show "Default" styled as a green badge with white text. Signed-off-by: Olivier V Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer (cherry picked from commit 8145d526e99519cdde38054a2c5cf98753228b98) Signed-off-by: Paul Derscheid --- .../prog/en/modules/admin/smtp_servers.tt | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt index 389394b88a..6fc48a973f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt @@ -403,7 +403,8 @@ { "data": function( row, type, val, meta ) { if ( row.debug ) { - return "[% tp("Active", "On") | html %]"; + let result = '' + "[% tp("Active", "On") | html %]" + ''; + return result; } else { return _(""); @@ -415,7 +416,8 @@ { "data": function( row, type, val, meta ) { if ( row.is_default ) { - return _("Default"); + let result = '' + _("Default") + ''; + return result; } else { return ""; } @@ -433,14 +435,6 @@ "orderable": false } ], - createdRow: function (row, data, dataIndex) { - if ( data.is_default ) { - $(row).addClass('default'); - } - if ( data.debug ) { - $(row).addClass('debug'); - } - }, }); $('#smtp_servers').on( "click", '.delete_server', function () {