gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 27855: Make GET /patrons/:patron_id use objects.find 

This patch makes the route for fetching a patron use the objects.find
helper instead of a plain Koha::Patrons->find. This gives the controller
embedding superpowers.

To test, we just need to check nothing broke:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Tomas Cohen Arazi 2021-03-04 06:43:01 -03:00 committed by Jonathan Druart
parent f790ca45ab
commit fa7a80a475
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Koha/REST/V1/Patrons.pm
View File

@ -73,13 +73,19 @@ sub get {
return try {
my $patron_id = $c->validation->param('patron_id');
my $patron = Koha::Patrons->find($patron_id);
my $patron = $c->objects->find( Koha::Patrons->new, $patron_id );
unless ($patron) {
return $c->render( status => 404, openapi => { error => "Patron not found." } );
return $c->render(
status => 404,
openapi => { error => "Patron not found." }
);
}
return $c->render( status => 200, openapi => $patron->to_api );
return $c->render(
status => 200,
openapi => $patron
);
}
catch {
$c->unhandled_exception($_);