From fa3aacffd85c9b8c3b969b9db4d0a7796668641e Mon Sep 17 00:00:00 2001 From: Andrew Fuerste Henry Date: Fri, 1 May 2026 17:35:06 +0000 Subject: [PATCH] Bug 42490: Update unit tests Prove t/db_dependent/HoldsQueue.t Sponsored-by: The Main Library Alliance Signed-off-by: Trevor Diamond Signed-off-by: Martin Renvoize Signed-off-by: Pedro Amorim --- t/db_dependent/HoldsQueue.t | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/HoldsQueue.t b/t/db_dependent/HoldsQueue.t index 285dcce8e2..d9f2cfd814 100755 --- a/t/db_dependent/HoldsQueue.t +++ b/t/db_dependent/HoldsQueue.t @@ -1102,10 +1102,11 @@ subtest "Test Local Holds Priority - Bib level" => sub { }; subtest "Test Local Holds Priority - Item level" => sub { - plan tests => 2; + plan tests => 4; Koha::Biblios->delete(); t::lib::Mocks::mock_preference( 'LocalHoldsPriority', 'GiveLibrary' ); + t::lib::Mocks::mock_preference( 'LocalHoldsPriorityScope', 'checkin_and_queue' ); t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'PickupLibrary' ); t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'homebranch' ); my $branch = $builder->build_object( { class => 'Koha::Libraries' } ); @@ -1171,6 +1172,21 @@ subtest "Test Local Holds Priority - Item level" => sub { $local_patron->borrowernumber, "We should pick the local hold over the next available" ); + + t::lib::Mocks::mock_preference( 'LocalHoldsPriorityScope', 'checkin_only' ); + C4::HoldsQueue::CreateQueue(); + + my $queue_rs2 = $schema->resultset('TmpHoldsqueue'); + my $q2 = $queue_rs2->next; + is( + $queue_rs2->count(), 1, + "Hold queue contains one hold" + ); + is( + $q2->borrowernumber->borrowernumber, + $other_patron->borrowernumber, + "We should not pick the local hold over the next available" + ); }; subtest "Test Local Holds Priority - Item level hold over Record level hold (Bug 23934)" => sub { @@ -1180,6 +1196,7 @@ subtest "Test Local Holds Priority - Item level hold over Record level hold (Bug t::lib::Mocks::mock_preference( 'LocalHoldsPriority', 'GiveLibrary' ); t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'PickupLibrary' ); t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'homebranch' ); + t::lib::Mocks::mock_preference( 'LocalHoldsPriorityScope', 'checkin_and_queue' ); my $branch = $builder->build_object( { class => 'Koha::Libraries' } ); my $branch2 = $builder->build_object( { class => 'Koha::Libraries' } ); my $category = $builder->build_object(