From f3482ddb93183bc3e287b7af2e478e9ca38e75f3 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Wed, 22 Apr 2026 08:31:41 -0400
Subject: [PATCH] Bug 42438: Remove event attributes from icon selection
 include file

This patch removes an "onmousedown" event attribute from the include
file used by item types and authorized values administration in icon
selection. The event handling is copied to each page's JS block.

To test, apply the patch and go to Administraion -> Item types.

In the "Choose an icon" section, click the "Remote image" tab. Click
the text input field. The corresponding radio button should be
checked.

Perform the same check on Administration -> Authorized values.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 3160983a6d3e462eb5fd93104b278ddcb6066a2b)
Signed-off-by: Jacob O'Mara <Jacob.omara@openfifth.co.uk>
---
 .../intranet-tmpl/prog/en/includes/admin-icon-selection.inc   | 2 +-
 .../intranet-tmpl/prog/en/modules/admin/authorised_values.tt  | 4 ++++
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt    | 4 ++++
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-icon-selection.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-icon-selection.inc
index f1b8078e7e..189a737e67 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-icon-selection.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-icon-selection.inc
@@ -78,7 +78,7 @@
                 <img src="[% image_location | html %]" alt="" />
             [% ELSE %]
                 <input type="radio" id="remote_image_check" name="image" value="remoteImage" />
-                <input type="text" name="remoteImage" size="48" maxlength="200" value="" onmousedown="document.getElementById('remote_image_check').checked = true;" />
+                <input type="text" id="remoteImage" name="remoteImage" size="48" maxlength="200" value="" />
             [% END %]
         [% END %]
     [% END # /tab_panels %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
index 05384025ba..e91800e837 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
@@ -444,6 +444,10 @@
                 $("#library_limitation")[0].style.minWidth = "450px";
                 $("#library_limitation").select2();
             }
+
+            $("#remoteImage").on("mousedown", function () {
+                $("#remote_image_check").prop("checked", true);
+            });
         });
     </script>
 [% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
index 53e0757b5d..ee985536dd 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
@@ -591,6 +591,10 @@
                 $("#library_limitation")[0].style.minWidth = "450px";
                 $("#library_limitation").select2();
             }
+
+            $("#remoteImage").on("mousedown", function () {
+                $("#remote_image_check").prop("checked", true);
+            });
         });
     </script>
 [% END %]