gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 10728: fix log noise generated by subscription-renew.pl 

Error log is showing warnings because mode is undefined
and we are doing string comparisons on it.

Set it to a default value (we were already assigning it a variable
which we were not using) and use the the result in the comparison

To test, after applying the patch:

[1] Use the renew link from the subscription detail page to renew
    a subscription.
[2] Verifying that doing this did not add a warning containing
    'subscription-renew.pl: Use of uninitialized value $mode in string eq '
    to the Apache error log.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 27edb618dd)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 70681a47f2)
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
(cherry picked from commit 70681a47f2)
Signed-off-by: Chris Hall <followingthepath@gmail.com>
(cherry picked from commit f17210a19c)
This commit is contained in:
Colin Campbell 2013-08-14 15:26:34 +01:00 committed by Chris Hall
parent 4b7a656f4a
commit f2a5af88e7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
serials/subscription-renew.pl
View File

@ -59,7 +59,7 @@ use C4::Serials;
my $query = new CGI;
my $dbh = C4::Context->dbh;
my $mode = $query->param('mode');
my $mode = $query->param('mode') || q{};
my $op = $query->param('op') || q{};
my $subscriptionid = $query->param('subscriptionid');
my $done = 0; # for after form has been submitted
@ -99,7 +99,7 @@ $template->param(
subscriptionid => $subscriptionid,
bibliotitle => $subscription->{bibliotitle},
$op => 1,
popup => ($query->param('mode')eq "popup"),
popup => ($mode eq 'popup'),
);
# Print the page