From f099cb0d622bbe86a27670ad4eef2076e884513b Mon Sep 17 00:00:00 2001
From: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date: Mon, 15 Jun 2026 15:10:09 +0000
Subject: [PATCH] Bug 28915: (RM follow-up): Remove dead code + typo fix

Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
---
 Koha/SimpleMARC.pm                                     | 10 ++++------
 .../bug_28915_increase_from_subfield_size.pl           |  4 ++--
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/Koha/SimpleMARC.pm b/Koha/SimpleMARC.pm
index 7065502cd9..ef0edae9c0 100644
--- a/Koha/SimpleMARC.pm
+++ b/Koha/SimpleMARC.pm
@@ -346,12 +346,10 @@ sub _update_controlfield {
             parameter => 'subfield',
         );
     }
-    my $position      = $params->{position} ? $params->{position} + 0 : 0;    # converts 01 to 1
-    my @values        = @{ $params->{values} };
-    my $value         = $values[0];
-    my $dont_erase    = $params->{dont_erase};
-    my $field_numbers = $params->{field_numbers} // [];
-    my $i             = 0;
+    my $position   = $params->{position} ? $params->{position} + 0 : 0;    # converts 01 to 1
+    my @values     = @{ $params->{values} };
+    my $value      = $values[0];
+    my $dont_erase = $params->{dont_erase};
 
     my $field = $record->field($fieldName);
 
diff --git a/installer/data/mysql/atomicupdate/bug_28915_increase_from_subfield_size.pl b/installer/data/mysql/atomicupdate/bug_28915_increase_from_subfield_size.pl
index 240ba73f26..4400a03911 100755
--- a/installer/data/mysql/atomicupdate/bug_28915_increase_from_subfield_size.pl
+++ b/installer/data/mysql/atomicupdate/bug_28915_increase_from_subfield_size.pl
@@ -13,10 +13,10 @@ return {
 
         # Print useful stuff here
         # tables
-        say $out "Modifying marc_modification_template_actions.from_subfield to VARCHR(2)";
+        say $out "Modifying marc_modification_template_actions.from_subfield to VARCHAR(2)";
 
         # Other information
-        say_success( $out, "Modified marc_modification_template_actions.from_subfield to VARCHR(2)" );
+        say_success( $out, "Modified marc_modification_template_actions.from_subfield to VARCHAR(2)" );
 
     },
 };