From f07f8be825aa0541fefbb898bf9b1187b0b9f6cb Mon Sep 17 00:00:00 2001
From: Fridolin Somers <fridolin.somers@biblibre.com>
Date: Mon, 9 Dec 2024 12:48:12 +0100
Subject: [PATCH] Bug 38653: Remove call on system preference
 'OPACLocalCoverImagesPriority'

This is in opac/opac-search.pl a call on system preference
OPACLocalCoverImagesPriority. This preference does not exists elsewhere
and dates back to Koha 3.8 from Bug 1633

This patch removes the call and fixes folding of if.

Check this returns empty : git grep OPACLocalCoverImagesPriority

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit bf82831913f80acb3255688f5798d464de2ee3b9)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: wainuiwitikapark <wainuiwitikapark@catalyst.net.nz>
(cherry picked from commit 35bee8465a6296184b90976524615e838a49d1fa)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 opac/opac-search.pl | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/opac/opac-search.pl b/opac/opac-search.pl
index 540b693ace..92d15a1a90 100755
--- a/opac/opac-search.pl
+++ b/opac/opac-search.pl
@@ -799,9 +799,8 @@ for (my $i=0;$i<@servers;$i++) {
                 SEARCH_RESULTS => \@newresults,
                 suppress_result_number => $hide,
                             );
-            if (C4::Context->preference("OPACLocalCoverImages")){
-            $template->param(OPACLocalCoverImages => 1);
-            $template->param(OPACLocalCoverImagesPriority => C4::Context->preference("OPACLocalCoverImagesPriority"));
+            if ( C4::Context->preference("OPACLocalCoverImages") ) {
+                $template->param( OPACLocalCoverImages => 1 );
             }
             ## Build the page numbers on the bottom of the page
             my ( $page_numbers, $hits_to_paginate, $pages, $current_page_number, $previous_page_offset, $next_page_offset, $last_page_offset ) =