Bug 26114: ILL should mark status=RET only if a return happened
The original code assumed every codepath should be trated as a
successful check-in. Such is not the case and the regression tests
verify that the code acknowledges this.
To test:
1. Apply the regression tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/Illrequests.t
=> FAIL: Tests fail
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit f916269465)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
parent
c2a765959a
commit
f0791ad68b
|
|
@ -2126,7 +2126,7 @@ sub AddReturn {
|
|||
|
||||
# Check if this item belongs to a biblio record that is attached to an
|
||||
# ILL request, if it is we need to update the ILL request's status
|
||||
if (C4::Context->preference('CirculateILL')) {
|
||||
if ( $doreturn and C4::Context->preference('CirculateILL')) {
|
||||
my $request = Koha::Illrequests->find(
|
||||
{ biblio_id => $item->biblio->biblionumber }
|
||||
);
|
||||
|
|
|
|||
Loading…
Reference in New Issue