gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 18276: (follow-up) Remove GetBiblioFromItemNumber - Easy ones 

- Item does not have a title attribute, it comes from biblio
- There is an additional call to effective_itemtype done on AddReturn,
so we need to catch both warnings

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2017-07-10 12:54:35 -03:00
parent f4ded893c5
commit eed1447a63
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
C4/Circulation.pm
View File

@ -2877,7 +2877,7 @@ sub AddRenewal {
VALUES (now(),?,?,?,?,?,?,?,?)"
);
$sth->execute( $borrowernumber, $accountno, $charge, $manager_id,
"Renewal of Rental Item " . $item_object->title . " $item->{'barcode'}",
"Renewal of Rental Item " . $biblio->title . " $item->{'barcode'}",
'Rent', $charge, $itemnumber );
}

3
t/db_dependent/Circulation/Returns.t
View File

@ -175,7 +175,8 @@ subtest "AddReturn logging on statistics table (item-level_itypes=1)" => sub {
is( $stat->itemtype, $ilevel_itemtype,
"item-level itype recorded on statistics for return");
warning_like { AddIssue( $borrower, $item_without_itemtype->{ barcode } ) }
qr/^item-level_itypes set but no itemtype set for item/,
[qr/^item-level_itypes set but no itemtype set for item/,
qr/^item-level_itypes set but no itemtype set for item/],
'Item without itemtype set raises warning on AddIssue';
warning_like { AddReturn( $item_without_itemtype->{ barcode }, $branch ) }
qr/^item-level_itypes set but no itemtype set for item/,