Bug 5399: Follow up style patch, moving exits out of subroutine

(cherry picked from commit 12741cfafa)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
This commit is contained in:
Chris Cormack 2011-01-17 22:53:28 +13:00 committed by Chris Nighswonger
parent 78da7f4c7c
commit ed1fc0cd06
1 changed files with 3 additions and 1 deletions

View File

@ -4,6 +4,7 @@
#written by john.soros@biblibre.com 01/10/2008
# Copyright 2008 - 2009 BibLibre SARL
# Parts Copyright Catalyst 2010
#
# This file is part of Koha.
#
@ -245,7 +246,6 @@ sub printbasketgrouppdf{
);
my $pdf = printpdf($basketgroup, $bookseller, $baskets, \%orders, $bookseller->{gstrate} || C4::Context->preference("gist")) || die "pdf generation failed";
print $pdf;
exit; # FIXME bad form to exit out of a subroutine like this
}
my $op = $input->param('op');
@ -383,10 +383,12 @@ if ( $op eq "add" ) {
CloseBasketgroup($basketgroupid);
printbasketgrouppdf($basketgroupid);
exit;
}elsif ($op eq 'print'){
my $basketgroupid = $input->param('basketgroupid');
printbasketgrouppdf($basketgroupid);
exit;
}elsif( $op eq "delete"){
my $basketgroupid = $input->param('basketgroupid');
DelBasketgroup($basketgroupid);