From eba0060286a650cdfce45e8f0f7d5d839cd87753 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 23 Oct 2025 09:17:56 +0200 Subject: [PATCH] Bug 41042: default_save_state is enabled by default If 'default_save_state' is not in the yaml file then the feature is enabled by default. Caught by the following failure: t/db_dependent/selenium/patrons_search.t .. # Failed test 'Search works when category of patrons is limited to a library we are not signed in at' # at t/db_dependent/selenium/patrons_search.t line 471. # got: 'Showing 1 to 5 of 26 entries (filtered from 82 total entries)' # expected: 'Showing 1 to 15 of 26 entries (filtered from 82 total entries)' # Looks like you failed 1 test of 1. Signed-off-by: Lucas Gass --- C4/Utils/DataTables/TablesSettings.pm | 2 +- t/db_dependent/TablesSettings.t | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/C4/Utils/DataTables/TablesSettings.pm b/C4/Utils/DataTables/TablesSettings.pm index e67520295c..3aef0531e9 100644 --- a/C4/Utils/DataTables/TablesSettings.pm +++ b/C4/Utils/DataTables/TablesSettings.pm @@ -121,7 +121,7 @@ sub get_table_settings { $default_sort_order //= $table_settings->{default_sort_order}; my $default_save_state = $rs && $rs->default_save_state; - $default_save_state //= $table_settings->{default_save_state} // 0; + $default_save_state //= $table_settings->{default_save_state} // 1; my $default_save_state_search = $rs && $rs->default_save_state_search; $default_save_state_search //= $table_settings->{default_save_state_search} // 0; diff --git a/t/db_dependent/TablesSettings.t b/t/db_dependent/TablesSettings.t index 15d605686b..6953c0fab3 100755 --- a/t/db_dependent/TablesSettings.t +++ b/t/db_dependent/TablesSettings.t @@ -467,8 +467,10 @@ subtest 'test upgrade' => sub { default_display_length => undef, default_sort_order => undef, - # default_save_state is disabled by default but can be enabled. - default_save_state => 0, + # default_save_state is enabled by default but can be disabled + default_save_state => 1, + + # default_save_state_search is disabled by default but can be enabled default_save_state_search => 0, } );