From ea3b9d9c14ba055acd66ebc98352000264bc390e Mon Sep 17 00:00:00 2001 From: David Cook Date: Fri, 24 Apr 2026 04:14:44 +0000 Subject: [PATCH] Bug 42406: (QA follow-up) fix little inconsistencies and errors Signed-off-by: David Cook Signed-off-by: Lucas Gass --- installer/data/mysql/atomicupdate/bug_42406.pl | 8 ++++---- .../prog/en/includes/guided-reports-view.inc | 4 +++- .../intranet-tmpl/prog/en/modules/reports/reports-home.tt | 2 +- t/Koha/Auth/Permissions.t | 6 ++++-- 4 files changed, 12 insertions(+), 8 deletions(-) diff --git a/installer/data/mysql/atomicupdate/bug_42406.pl b/installer/data/mysql/atomicupdate/bug_42406.pl index 27b0e58ca0..90dfee5df2 100755 --- a/installer/data/mysql/atomicupdate/bug_42406.pl +++ b/installer/data/mysql/atomicupdate/bug_42406.pl @@ -2,8 +2,8 @@ use Modern::Perl; use Koha::Installer::Output qw(say_warning say_success say_info); return { - bug_number => "BUG_NUMBER", - description => "A single line description", + bug_number => "42406", + description => "Split delete_reports into 'own' and 'all'", up => sub { my ($args) = @_; my ( $dbh, $out ) = @$args{qw(dbh out)}; @@ -11,8 +11,8 @@ return { $dbh->do( q{ INSERT IGNORE INTO permissions (module_bit, code, description) VALUES - ( 16, 'delete_own_reports', 'Delete reports you have created'), - ( 16, 'delete_all_reports', 'Delete any reports') + ( 16, 'delete_own_reports', 'Delete SQL reports you have created'), + ( 16, 'delete_all_reports', 'Delete SQL reports created by anyone') } ); say $out "Added new permissions 'delete_own_reports' AND 'delete_all_reports'"; diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/guided-reports-view.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/guided-reports-view.inc index fff76083c3..71e9a4b11f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/guided-reports-view.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/guided-reports-view.inc @@ -2,7 +2,9 @@