gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 30772: Terminology: Replace instances of "reserve" with "hold" 

There were several templates where we were still using the term
"reserve" instead of "hold." This patch corrects the ones I found,
including in a couple of HTML comments.

To test, apply the patch and confirm that the changes look correct and
affect only the relevant term.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2022-05-17 12:04:41 +00:00 committed by Tomas Cohen Arazi
parent 169c535e88
commit e68ecb3311
No known key found for this signature in database
GPG Key ID: 0A272EA1B2F3C15F
6 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
View File

@ -279,7 +279,7 @@
[%# FIXME Here we block the cancellation if holds exist. Actually it could be possible if items will be exist after the deletion %]
[%# Some additional checks should be added in the pl file %]
[% span_title = BLOCK %]
<span>Cannot cancel receipt of this order line because at least one reservation exists on the records.</span>
<span>Cannot cancel receipt of this order line because at least one hold exists on the records.</span>
[% END %]
[% END %]
<span title="[% span_title | collapse | html %]">

8
koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
View File

@ -42,7 +42,7 @@
<table>
<caption>
[% IF ( reserved ) %]
Reserve found for [% INCLUDE 'patron-title.inc' patron => hold.patron | html %] (<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber | uri %]">[% borrowernumber | html %]</a>).
Hold found for [% INCLUDE 'patron-title.inc' patron => hold.patron | html %] (<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber | uri %]">[% borrowernumber | html %]</a>).
[% END %]
[% IF ( waiting ) %]
Item is marked waiting at [% branchname | html %] for [% name | html %] (<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber | uri %]">[% borrowernumber | html %]</a>).
@ -54,9 +54,9 @@
<tr>
<th>
[% IF ( reserved ) %]
Set reserve to transit and transfer book to [% Branches.GetName( hold.branchcode ) | html %]:
Transfer item to [% Branches.GetName( hold.branchcode ) | html %]:
[% END %]
[% IF ( waiting or transferred ) %]Cancel reservation and then attempt transfer: [% END %]
[% IF ( waiting or transferred ) %]Cancel hold and then attempt transfer: [% END %]
</th>
<td>
<form method="post" name="mainform" id="mainform" action="branchtransfers.pl">
@ -83,7 +83,7 @@
</tr>
[% IF ( reserved ) %]
<tr>
<th>Cancel reservation and then attempt transfer:</th>
<th>Cancel hold and then attempt transfer:</th>
<td>
<form method="post" name="mainform" id="mainform" action="branchtransfers.pl">
[% FOREACH trsfitemloo IN trsfitemloop %]

2
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
View File

@ -216,7 +216,7 @@
</script>
[% END %]
[% IF NOT checkout_info.IMPOSSIBLE && ( CAN_user_circulate_force_checkout || checkout_info.HIGHHOLDS ) && ( checkout_info.RESERVED || checkout_info.RESERVE_WAITING || checkout_info.TRANSFERRED || checkout_info.PROCESSING ) %] <!-- arbitrary choice, revert the reserve is not possible-->
[% IF NOT checkout_info.IMPOSSIBLE && ( CAN_user_circulate_force_checkout || checkout_info.HIGHHOLDS ) && ( checkout_info.RESERVED || checkout_info.RESERVE_WAITING || checkout_info.TRANSFERRED || checkout_info.PROCESSING ) %] <!-- arbitrary choice, revert the hold is not possible-->
<li><i class="fa fa-li fa-warning"></i>This item is on hold for another patron. The hold will be overridden, but not cancelled.</li>
[% ELSIF checkout_info.RESERVED %]
<li><i class="fa fa-li fa-warning"></i>This item is on hold for another patron.</li>

2
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
View File

@ -624,7 +624,7 @@
</div> <!-- /#item-transfer-modal -->
[% END # /IF transfer || needstransfer %]
<!-- case of simple return no issue or transfer but with a reservation -->
<!-- case of simple return no issue or transfer but with a hold -->
[% IF ( reserved and !recalled and !waitingrecall ) %]
<!-- reserved -->
<div id="hold-found2" class="modal fade audio-alert-action block">

2
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
View File

@ -664,7 +664,7 @@
[% ELSIF itemloo.not_holdable == 'pickupNotInHoldGroup' %]
<span>Only pickup locations within the same hold group are allowed</span>
[% ELSIF itemloo.not_holdable == 'noReservesAllowed' %]
<span>No reserves are allowed on this item</span>
<span>No holds are allowed on this item</span>
[% ELSIF itemloo.not_holdable == 'libraryNotPickupLocation' %]
<span>Library is not a pickup location</span>
[% ELSIF itemloo.not_holdable == 'no_valid_pickup_location' %]

2
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
View File

@ -197,7 +197,7 @@
[% UNLESS ( bibitemloo.holdable ) %]
[% IF ( bibitemloo.ageRestricted ) %]
<div class="alert alert-warning">Sorry, you are too young to reserve this material.</div>
<div class="alert alert-warning">Sorry, you are too young to hold this material.</div>
[% END %]
[% IF ( bibitemloo.already_reserved ) %]
<div class="alert alert-warning">You have already requested this title.</div>