gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 23083: Fix course reserve item editing if one of the value is set to UNCHANGED 

Test plan:
0: Do not apply the patches
1: Create an item with itype, ccode, location, and holding branch set
2: Create a course
3: Add item to course, changing the values for itype, ccode, and location
4: Click Edit for that item on course-details.pl
5: Assign new values for itype, ccode, and location but leave the holding library dropdown set to LEAVE UNCHANGED
6: Hit Save
7: Back on course-details.pl, observe that the item is still showing the values set in step 3
8: Apply this patch
9: Repeat 4 to 6
10: Back on course-details.pl, observe that the item is now showing the correct values
11: Edit the course reserve again, setting new values for itype, ccode, and location and setting the holding library dropdown to whatever the holding library for the item is currently
12: hit save
13: On course-details.pl, see that the change actually happened, the item is now showing the values set in step 9

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2019-06-19 20:08:04 -05:00 committed by Martin Renvoize
parent 44469cf4c3
commit e4ee363630
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
C4/CourseReserves.pm
View File

@ -531,11 +531,12 @@ sub _UpdateCourseItem {
unless ($course_item);
$ci_id = $course_item->{'ci_id'} unless ($ci_id);
my %mod_params;
foreach (@FIELDS) {
$mod_params{$_} = $params{$_};
}
my %mod_params =
map {
defined $params{$_} && $params{$_} ne ''
? ( $_ => $params{$_} )
: ()
} @FIELDS;
ModItem( \%mod_params, undef, $course_item->{'itemnumber'} );
}