From e05e0f1f1d5e315cf30cbe09ef088ac079d3df2a Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Tue, 8 Apr 2025 13:43:28 +0000 Subject: [PATCH] Bug 38201: Fix setWarning call in titles+packages 'this' is scoped inside forEarch, an error was thrown when submiting the form with errors Signed-off-by: Michaela Sieber Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass --- .../js/vue/components/ERM/EHoldingsLocalPackageResource.vue | 4 +--- .../js/vue/components/ERM/EHoldingsLocalTitleResource.vue | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageResource.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageResource.vue index 71befaa443..fa28d8e798 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageResource.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageResource.vue @@ -311,9 +311,7 @@ export default { errors.push(this.$__("An agreement is used several times")); } - errors.forEach(function (e) { - this.setWarning(e); - }); + this.setWarning(errors.join("
")); return !errors.length; }, onSubmit(e, packageToSave) { diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitleResource.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitleResource.vue index ae88a4bec9..a32f1c6098 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitleResource.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitleResource.vue @@ -439,9 +439,7 @@ export default { errors.push(this.$__("A package is used several times")); } - errors.forEach(function (e) { - this.setWarning(e); - }); + this.setWarning(errors.join("
")); return !errors.length; }, onSubmit(e, titleToSave) {