Bug 24001: Fix Card template/rpinter profile creation and edit
This patch adjusts the template/profiles to use the default of '0' This should probably be NULL, and the columns foreign keys, this code could use a further rewrite, but this should fix a long standing bug To test: 1 - Using the fresh install, with all the sample data. 2 - Go to Home › Tools › Patron card creator › Templates 3 - New > Card template 4 - Save 5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 6 - Edit an existing template 7 - Save 8 - Error: Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line 89 9 - Create a new 'Printer profile' 10 - Save 11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'template_id' at row 1 12 - Apply the attached patch. 13 - Verify you can create a new 'Card template' and 'Printer profile' with no errors 14 - Verify you can edit and save both of the newly created objects above Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
parent
b3142cfe43
commit
dedc0ae83f
|
|
@ -59,7 +59,7 @@ sub new {
|
|||
my $type = ref($invocant) || $invocant;
|
||||
my $self = {
|
||||
printer_name => 'Default Printer',
|
||||
template_id => '',
|
||||
template_id => 0,
|
||||
paper_bin => 'Tray 1',
|
||||
offset_horz => 0,
|
||||
offset_vert => 0,
|
||||
|
|
|
|||
Loading…
Reference in New Issue