Bug 40866: Remove unused $message variable from circulation

The $message variable was declared in circ/circulation.pl but never
actually set, making the "No patron matched" template block unreachable.

This is a remnant from old code that was incompletely cleaned when that
functionality was changed/removed.

This patch removes the unused variable, template parameter, and the
unreachable template block.

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Martin Renvoize 2025-10-08 17:49:23 +01:00 committed by Lucas Gass
parent 3c41dfbe3f
commit de962e15cf
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
2 changed files with 0 additions and 8 deletions

View File

@ -326,8 +326,6 @@ if ($patron) {
# STEP 3 : ISSUING
#
#
my $message;
if ( @$barcodes && $op eq 'cud-checkout' ) {
my $checkout_infos;
for my $barcode (@$barcodes) {
@ -784,7 +782,6 @@ $template->param(
stickyduedate => $stickyduedate,
duedatespec => $duedatespec,
restoreduedatespec => $restoreduedatespec,
message => $message,
totaldue => sprintf( '%.2f', $balance ), # FIXME not used in template?
inprocess => $inprocess,
$view => 1,

View File

@ -787,11 +787,6 @@
<p>Item checked out</p>
[% END %]
[% IF ( message ) %]
[% INCLUDE 'patron-toolbar.inc' %]
<h4>No patron matched <span class="ex">[% message | html %]</span></h4>
[% END %]
<!-- BARCODE ENTRY -->
[% IF patron %]